Skip to contentSkip to conversation

network-manager: fix DHCP support.

PATCH New Eric Le Bihan 3 participants 6 messages Jan 7, 2014 – Jan 9, 2014

lore
Share & tools
lore
#0 lore raw

cover network-manager: fix DHCP support.

This patch series fixes DHCP support for NetworkManager.

The DHCP client used by NetworkManager can be configured in the "[main]" section of /etc/NetworkManager/NetworkManager.conf either as:

dhcp=dhclient

or

dhcp=dhcpcd

The support for either client is enabled by the './configure' script. When network-manager was built, the instance of the client installed on the development machine was detected and its location used. Most of the time, this resulted in dhclient being the only choice...

This patch series:

- installs dhcpcd in the proper directory.
- configures network-manager according to the DHCP client package selected.
- bumps network-manager to its latest version.

Best regards,
ELB

Eric Le Bihan (3):
dhcpcd: install dhcpcd as /usr/sbin/dhcpcd.
network-manager: fix DHCP clients detection.
network-manager: bump to version 0.9.8.2

 package/dhcpcd/dhcpcd.mk                   |    2 +-
 package/network-manager/network-manager.mk |   10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

--
1.7.9.5

#1 lore raw

PATCH 1/3 dhcpcd: install dhcpcd as /usr/sbin/dhcpcd.

GNU/Linux distributions usually install dhcpcd in /usr/sbin. NetworkManager will look for it in this directory.

---
 package/dhcpcd/dhcpcd.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/dhcpcd/dhcpcd.mk +1 -1
index 8037706..01ced3a 100644
@@ -32,7 +32,7 @@ endef
 
 define DHCPCD_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 0755 $(@D)/dhcpcd \
-		$(TARGET_DIR)/usr/bin/dhcpcd
+		$(TARGET_DIR)/usr/sbin/dhcpcd
 	$(INSTALL) -D -m 0644 $(@D)/dhcpcd.conf \
 		$(TARGET_DIR)/etc/dhcpcd.conf
 	$(INSTALL) -D -m 0755 $(@D)/dhcpcd-run-hooks \
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 2/3 network-manager: fix DHCP clients detection.

In reply to Eric Le Bihan

If either dhclient or dhcpcd are selected, network-manager is now configured with the proper paths.

This allows 'dhcp=dhclient' or 'dhcp=dhcpcd' to be set in /etc/NetworkManager/NetworkManager.conf.

---
 package/network-manager/network-manager.mk |    8 ++++++++
 1 file changed, 8 insertions(+)
package/network-manager/network-manager.mk +8 -0
index 7c9cc88..e847f25 100644
@@ -34,6 +34,14 @@ NETWORK_MANAGER_CONF_OPT = \
 		--disable-ifupdown \
 		--disable-ifnet
 
+ifeq ($(BR2_PACKAGE_DHCP_CLIENT),y)
+NETWORK_MANAGER_CONF_OPT += --with-dhclient=/usr/sbin/dhclient
+endif
+
+ifeq ($(BR2_PACKAGE_DHCPCD),y)
+NETWORK_MANAGER_CONF_OPT += --with-dhcpcd=/usr/sbin/dhcpcd
+endif
+
 # uClibc by default doesn't have backtrace support, so don't use it
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 NETWORK_MANAGER_CONF_OPT += --disable-crashtrace
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 3/3 network-manager: bump to version 0.9.8.2

In reply to Eric Le Bihan
---
 package/network-manager/network-manager.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/network-manager/network-manager.mk +1 -1
index e847f25..cd8b528 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 NETWORK_MANAGER_VERSION_MAJOR = 0.9
-NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).8.0
+NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).8.2
 NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz
 NETWORK_MANAGER_SITE = http://ftp.gnome.org/pub/GNOME/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR)
 NETWORK_MANAGER_INSTALL_STAGING = YES
Signature · 1 line
1.7.9.5
#5 lore raw

cover network-manager: fix DHCP support.

In reply to Eric Le Bihan
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Eric" == Eric Le Bihan <[email protected]> writes:

This patch series fixes DHCP support for NetworkManager.
The DHCP client used by NetworkManager can be configured in the "[main]" section of /etc/NetworkManager/NetworkManager.conf either as:

dhcp=dhclient

or

dhcp=dhcpcd

The support for either client is enabled by the './configure' script. When network-manager was built, the instance of the client installed on the development machine was detected and its location used. Most of the time, this resulted in dhclient being the only choice...

Quoted 5 lines

This patch series:

- installs dhcpcd in the proper directory.
- configures network-manager according to the DHCP client package selected.
- bumps network-manager to its latest version.

Committed series, thanks.

Signature · 1 line
Bye, Peter Korsgaard