Skip to contentSkip to conversation

irqchip: exynos-combiner: call handle_bad_irq directly

PATCH New Pankaj Dubey 3 participants 5 messages Jan 10, 2014 – Feb 13, 2014

Subsystems (2)
Arm Samsung Exynos irqchip drivers
lore
Share & tools
lore

Pankaj Dubey

author
#0 lore raw

PATCH 1/3 irqchip: exynos-combiner: call handle_bad_irq directly

This patch is inspired from following commit
aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h"

Signed-off-by Pankaj Dubey <[email protected]>
---
 drivers/irqchip/exynos-combiner.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/irqchip/exynos-combiner.c +1 -2
index 40e6440..f8636a6 100644
@@ -17,7 +17,6 @@
 #include <linux/irqchip/chained_irq.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <asm/mach/irq.h>
 
 #include "irqchip.h"
 

@@ -81,7 +80,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
 	cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq);
 
 	if (unlikely(!cascade_irq))
-		do_bad_IRQ(irq, desc);
+		handle_bad_irq(irq, desc);
 	else
 		generic_handle_irq(cascade_irq);
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/3 irqchip: exynos-combiner: call handle_bad_irq directly

Quoted 7 lines · Pankaj Dubey

This patch is inspired from following commit
aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h"

Signed-off-by Pankaj Dubey <[email protected]>

This is single patch only. By mistake sent as Patch[1/3].

Quoted 25 lines
---
  drivers/irqchip/exynos-combiner.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/irqchip/exynos-combiner.c +1 -2
index 40e6440..f8636a6 100644
@@ -17,7 +17,6 @@
  #include <linux/irqchip/chained_irq.h>
  #include <linux/of_address.h>
  #include <linux/of_irq.h>
-#include <asm/mach/irq.h>
 
  #include "irqchip.h"
 

@@ -81,7 +80,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
  	cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq);
 
  	if (unlikely(!cascade_irq))
-		do_bad_IRQ(irq, desc);
+		handle_bad_irq(irq, desc);
  	else
  		generic_handle_irq(cascade_irq);
#2 lore raw

PATCH 1/3 irqchip: exynos-combiner: call handle_bad_irq directly

In reply to Pankaj Dubey

Hi Pankaj,

Quoted 10 lines · Pankaj Dubey

This patch is inspired from following commit
aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h"

Signed-off-by Pankaj Dubey <[email protected]>
---
  drivers/irqchip/exynos-combiner.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by Tomasz Figa <[email protected]>

Best regards,
Tomasz

author
#3 lore raw

PATCH 1/3 irqchip: exynos-combiner: call handle_bad_irq directly

Quoted 14 lines · Tomasz Figa

Hi Pankaj,

Quoted 10 lines · Pankaj Dubey

This patch is inspired from following commit
aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h"

Signed-off-by Pankaj Dubey <[email protected]>
---
  drivers/irqchip/exynos-combiner.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 5 lines
Reviewed-by Tomasz Figa <[email protected]>

Best regards,
Tomasz

Ping.

Thanks,
Pankaj Dubey

Applied
#4 lore raw

PATCH 1/3 irqchip: exynos-combiner: call handle_bad_irq directly

In reply to Tomasz Figa
Quoted 9 lines · Tomasz Figa

Hi Pankaj,

Quoted 6 lines · Pankaj Dubey

This patch is inspired from following commit
aec0095653: (irqchip: gic: Call handle_bad_irq() directly)

Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h"

Quoted 7 lines
Quoted 4 lines
Signed-off-by Pankaj Dubey <[email protected]>

---
drivers/irqchip/exynos-combiner.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by Tomasz Figa <[email protected]>

Applied, thanks.

- Kukjin