Skip to contentSkip to conversation

net: qlcnic: fix warning for incorrect type in argument

PATCH Applied Ding Tianhong 2 participants 2 messages Jan 11, 2014 – Jan 14, 2014

Subsystems (3)
Networking Network drivers QLogic qlcnic (1/10)Gb Ethernet driver
lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH 1/2 net: qlcnic: fix warning for incorrect type in argument

The commit 6878f79a8b71e8c7b0587a1185584f54fd31f185 (net: qlcnic: slight optimization of addr compare) cause a warning "sparse: incorrect type in argument 2 (different type sizes)", so fix it.

I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.

Cc Himanshu Madhani <[email protected]>
Cc Rajesh Borundia <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c +1 -1
index 6373f60..24714de 100644
@@ -346,7 +346,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
 	head = &(adapter->fhash.fhead[hindex]);
 
 	hlist_for_each_entry_safe(tmp_fil, n, head, fnode) {
-		if (ether_addr_equal(tmp_fil->faddr, &src_addr) &&
+		if (ether_addr_equal(tmp_fil->faddr, (u8 *)&src_addr) &&
 		    tmp_fil->vlan_id == vlan_id) {
 			if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil->ftime))
 				qlcnic_change_filter(adapter, &src_addr,
Signature · 1 line
1.8.0
maintainer Applied
#1 lore raw

From: Ding Tianhong <[email protected]>
Date: Sat, 11 Jan 2014 16:23:35 +0800

Quoted 10 lines

The commit 6878f79a8b71e8c7b0587a1185584f54fd31f185 (net: qlcnic: slight optimization of addr compare) cause a warning "sparse: incorrect type in argument 2 (different type sizes)", so fix it.

I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.

Cc Himanshu Madhani <[email protected]>
Cc Rajesh Borundia <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>

Applied.