Skip to contentSkip to conversation

net: 3com: fix warning for incorrect type in argument

PATCH Applied Ding Tianhong 2 participants 2 messages Jan 11, 2014 – Jan 14, 2014

Subsystems (3)
Networking Network drivers 3C509 network driver
lore
Share & tools
lore

Ding Tianhong

author
#0 lore raw

PATCH 2/2 net: 3com: fix warning for incorrect type in argument

The commit c466a9b2b329f7d9982c14eedc83a923d3bc711c (net: 3com: slight optimization of addr compare) cause a warning: "passing argument 1 of 'ether_addr_equal' from incompatible pointer type", so fix it.

I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.

Cc "David S. Miller" <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>
---
 drivers/net/ethernet/3com/3c509.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/3com/3c509.c +1 -1
index 9142b47..c53384d 100644
@@ -252,7 +252,7 @@ static int el3_isa_id_sequence(__be16 *phys_addr)
 		for (i = 0; i < el3_cards; i++) {
 			struct el3_private *lp = netdev_priv(el3_devs[i]);
 			if (lp->type == EL3_PNP &&
-			    ether_addr_equal(phys_addr, el3_devs[i]->dev_addr)) {
+			    ether_addr_equal((u8 *)phys_addr, el3_devs[i]->dev_addr)) {
 				if (el3_debug > 3)
 					pr_debug("3c509 with address %02x %02x %02x %02x %02x %02x was found by ISAPnP\n",
 						phys_addr[0] & 0xff, phys_addr[0] >> 8,
Signature · 1 line
1.8.0
maintainer Applied
#1 lore raw

From: Ding Tianhong <[email protected]>
Date: Sat, 11 Jan 2014 16:23:37 +0800

Quoted 9 lines

The commit c466a9b2b329f7d9982c14eedc83a923d3bc711c (net: 3com: slight optimization of addr compare) cause a warning: "passing argument 1 of 'ether_addr_equal' from incompatible pointer type", so fix it.

I think julia will convert ether_addr_equal to ether_addr_equal_64bits later.

Cc "David S. Miller" <[email protected]>
Signed-off-by Ding Tianhong <[email protected]>

Applied.