Skip to contentSkip to conversation

spi: ti-qspi: Fixup driver name

RFC PATCH Applied Axel Lin 3 participants 3 messages Jan 12, 2014 – Jan 13, 2014 SPI

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

RFC PATCH 1/1 spi: ti-qspi: Fixup driver name

The driver name in current code looks like a compatible string which is not the naming convention for platform drivers.
Fix it and also add modalias since this driver can be built as a module.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi-ti-qspi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-ti-qspi.c +2 -1
index 2a1ab49..3d09265 100644
@@ -567,7 +567,7 @@ static struct platform_driver ti_qspi_driver = {
 	.probe	= ti_qspi_probe,
 	.remove = ti_qspi_remove,
 	.driver = {
-		.name	= "ti,dra7xxx-qspi",
+		.name	= "ti-qspi",
 		.owner	= THIS_MODULE,
 		.pm =   &ti_qspi_pm_ops,
 		.of_match_table = ti_qspi_match,

@@ -579,3 +579,4 @@ module_platform_driver(ti_qspi_driver);
 MODULE_AUTHOR("Sourav Poddar <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("TI QSPI controller driver");
+MODULE_ALIAS("platform:ti-qspi");
Signature · 8 lines
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Axel Lin

The driver name in current code looks like a compatible string which is not the naming convention for platform drivers.
Fix it and also add modalias since this driver can be built as a module.

Signed-off-by Axel Lin<[email protected]>
---
  drivers/spi/spi-ti-qspi.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spi/spi-ti-qspi.c +1 -1
index 2a1ab49..3d09265 100644
@@ -567,7 +567,7 @@ static struct platform_driver ti_qspi_driver = {
  	.probe	= ti_qspi_probe,
  	.remove = ti_qspi_remove,
  	.driver = {
-		.name	= "ti,dra7xxx-qspi",
+		.name	= "ti-qspi",
  		.owner	= THIS_MODULE,
  		.pm =&ti_qspi_pm_ops,
  		.of_match_table = ti_qspi_match,

drivers/spi/spi-ti-qspi.c module_platform_driver(ti_qspi_driver); · line 582

Quoted 4 lines
drivers/spi/spi-ti-qspi.c +1 -0
@@ -579,3 +579,4 @@ module_platform_driver(ti_qspi_driver);
  MODULE_AUTHOR("Sourav Poddar<[email protected]>");
  MODULE_LICENSE("GPL v2");
  MODULE_DESCRIPTION("TI QSPI controller driver");
+MODULE_ALIAS("platform:ti-qspi");
Acked-by Sourav Poddar <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw
In reply to Axel Lin
Quoted 3 lines · Axel Lin

The driver name in current code looks like a compatible string which is not the naming convention for platform drivers.
Fix it and also add modalias since this driver can be built as a module.

Applied, thanks.