Skip to contentSkip to conversation

mainline build: 11 warnings 0 failures (mainline/v3.13-rc8)

PATCH New Russell King - ARM Linux 4 participants 5 messages Jan 12, 2014 – Jan 15, 2014 1 message not in the archive SPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Russell King - ARM Linux

author
#1 lore raw
Quoted 10 lines · Olof's autobuilder

Warnings:
1 drivers/leds/leds-pwm.c:88:22: warning: unused variable 'node' [-Wunused-variable]
1 drivers/net/ethernet/ti/cpsw.c:2140:2: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t' [-Wformat=] 1 drivers/net/ethernet/ti/davinci_cpdma.c:182:3: warning: passing argument 3 of 'dma_alloc_attrs' from incompatible pointer type [enabled by default] 1 drivers/net/ethernet/ti/davinci_cpdma.c:222:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 drivers/net/ethernet/ti/davinci_cpdma.c:223:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'resource_size_t' [-Wformat=] 1 drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t' [-Wformat=] 2 drivers/mtd/nand/gpmi-nand/gpmi-nand.c:123:13: warning: 'set_geometry_by_ecc_info' defined but not used [-Wunused-function]
2 net/netfilter/ipvs/ip_vs_sync.c:1640:8: warning: unused variable 'ret' [-Wunused-variable]

Every time I look at these build reports, I see these same old warnings time and time again, which no one is addressing. Some warnings are more serious than others. In this case:

warning: format 'XX' expects argument of type 'unsigned int', but argument X has type 'resource_size_t' [-Wformat=]

is a serious warning that's a real bug and really needs fixing. Why?

It means that format expects to see a 32-bit argument, but has been passed a potential 64-bit argument instead.

Firstly, remember that on EABI, 64-bit arguments need natural alignment in memory and in registers. So, if the 32-bit argument would've been in r1, it actually gets passed in r2/r3 and r1 is unused. The result will be that we will print r1.

Secondly, any following arguments are not correctly accessed. If any of the following arguments are a pointer which we're going to dereference (eg, due to a %s format or one of these new fangled %p formats), we will not dereference the pointer that we think we should be - taking the above example, the next argument will be r2, rather than the first stacked argument.

All these resource_size_t warnings need to be fixed, and stay fixed.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#2 lore raw

PATCH 1/1 spi: davinci: fix build warning when printing resource_size_t vars

Use %pa format specifier when printing variables of resource_size_t type
to fix build warnings:
drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'resource_size_t' drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t'

Signed-off-by Grygorii Strashko <[email protected]>
---
 drivers/spi/spi-davinci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-davinci.c +2 -2
index 50b2d88..d3f6386 100644
@@ -963,8 +963,8 @@ static int davinci_spi_probe(struct platform_device *pdev)
 			goto free_clk;
 
 		dev_info(&pdev->dev, "DMA: supported\n");
-		dev_info(&pdev->dev, "DMA: RX channel: %d, TX channel: %d, "
-				"event queue: %d\n", dma_rx_chan, dma_tx_chan,
+		dev_info(&pdev->dev, "DMA: RX channel: %pa, TX channel: %pa, "
+				"event queue: %d\n", &dma_rx_chan, &dma_tx_chan,
 				pdata->dma_event_q);
 	}
Signature · 1 line
1.7.9.5
maintainer
#3 lore raw

PATCH 1/1 spi: davinci: fix build warning when printing resource_size_t vars

Quoted 4 lines · Grygorii Strashko

Use %pa format specifier when printing variables of resource_size_t type
to fix build warnings:
drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'resource_size_t' drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t'

This doesn't apply against current code, it seems the same patch has
already been applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140114/fc47ddf5/attachment.sig>

#4 lore raw

PATCH 1/1 spi: davinci: fix build warning when printing resource_size_t vars

Quoted 9 lines · Mark Brown
Quoted 4 lines · Grygorii Strashko

Use %pa format specifier when printing variables of resource_size_t type
to fix build warnings:
drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'resource_size_t' drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t'

This doesn't apply against current code, it seems the same patch has already been applied.

Yeah. I did send same patch last merge window time-frame which has been applied by you.

Regards,
Santosh

#5 lore raw

PATCH 1/1 spi: davinci: fix build warning when printing resource_size_t vars

Quoted 7 lines · Santosh Shilimkar
Quoted 6 lines · Mark Brown
Quoted 4 lines · Grygorii Strashko

Use %pa format specifier when printing variables of resource_size_t type
to fix build warnings:
drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'resource_size_t' drivers/spi/spi-davinci.c:966:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'resource_size_t'

Quoted 5 lines
Quoted 3 lines

This doesn't apply against current code, it seems the same patch has already been applied.

Yeah. I did send same patch last merge window time-frame which has been applied by you.

Ops. Sorry for the noise.