Skip to contentSkip to conversation

Add SMS Tools Server 3 package

PATCH New julien.boibessot at free.fr 2 participants 5 messages Jan 8, 2014 – Jan 17, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add SMS Tools Server 3 package

From: Julien Boibessot <[email protected]>

---
 package/Config.in              |    1 +
 package/smstools3/Config.in    |   24 ++++++++++++++++++++++
 package/smstools3/S50smsd      |   43 ++++++++++++++++++++++++++++++++++++++++
 package/smstools3/smstools3.mk |   35 ++++++++++++++++++++++++++++++++
 4 files changed, 103 insertions(+), 0 deletions(-)
 create mode 100644 package/smstools3/Config.in
 create mode 100644 package/smstools3/S50smsd
 create mode 100644 package/smstools3/smstools3.mk
package/Config.in +1 -0
index e502cde..1f4fe14 100644
@@ -901,6 +901,7 @@ source "package/samba/Config.in"
 source "package/sconeserver/Config.in"
 source "package/ser2net/Config.in"
 source "package/smcroute/Config.in"
+source "package/smstools3/Config.in"
 source "package/socat/Config.in"
 source "package/socketcand/Config.in"
 source "package/spawn-fcgi/Config.in"
package/smstools3/Config.in new file +24 -0
new file mode 100644
index 0000000..e0ea0f7
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_SMSTOOLS3
+	bool "smstools3"
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  The SMS Server Tools 3 is a SMS Gateway software which can send and
+	  receive short messages through GSM modems and mobile phones.
+
+	  http://smstools3.kekekasvi.com/
+
+if BR2_PACKAGE_SMSTOOLS3
+
+config BR2_PACKAGE_SMSTOOLS3_NB_MODEMS
+	string "Number of modems to support"
+	default 1
+
+config BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT
+	bool "Start SMS Server Tools at system boot"
+	default y
+
+endif
+
+comment "smstools3 needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/smstools3/S50smsd new file +43 -0

43 lines not on this page · raw message

package/smstools3/smstools3.mk new file +35 -0
new file mode 100644
index 0000000..2403b6f
@@ -0,0 +1,35 @@
+#############################################################
+#
+# smstools3
+#
+#############################################################
+
+SMSTOOLS3_VERSION = 3.1.15
+SMSTOOLS3_SITE = http://smstools3.kekekasvi.com/packages/
+SMSTOOLS3_LICENSE = GPLv2+
+SMSTOOLS3_LICENSE_FILES = doc/license.html LICENSE
+
+SMSTOOLS3_NB_MODEMS = $(call qstrip,$(BR2_PACKAGE_SMSTOOLS3_NB_MODEMS))
+SMSTOOLS3_CFLAGS = $(TARGET_CFLAGS)
+SMSTOOLS3_CFLAGS += -D NUMBER_OF_MODEMS=$(SMSTOOLS3_NB_MODEMS)
+SMSTOOLS3_CFLAGS += -D NOSTATS
+
+define SMSTOOLS3_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" CFLAGS="$(SMSTOOLS3_CFLAGS)" -C $(@D)
+endef
+
+ifeq ($(BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT),y)
+SMSTOOLS3_INIT_SCRIPT_NAME = S50smsd
+else
+SMSTOOLS3_INIT_SCRIPT_NAME = 50smsd
+endif
+
+define SMSTOOLS3_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/src/smsd $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/scripts/sendsms $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/examples/smsd.conf.easy $(TARGET_DIR)/etc/
+	$(INSTALL) -m 0755 -D package/smstools3/S50smsd $(TARGET_DIR)/etc/init.d/$(SMSTOOLS3_INIT_SCRIPT_NAME)
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 Add SMS Tools Server 3 package

ping ?

Quoted 146 lines · julien.boibessot at free.fr

From: Julien Boibessot <[email protected]>

---
 package/Config.in              |    1 +
 package/smstools3/Config.in    |   24 ++++++++++++++++++++++
 package/smstools3/S50smsd      |   43 ++++++++++++++++++++++++++++++++++++++++
 package/smstools3/smstools3.mk |   35 ++++++++++++++++++++++++++++++++
 4 files changed, 103 insertions(+), 0 deletions(-)
 create mode 100644 package/smstools3/Config.in
 create mode 100644 package/smstools3/S50smsd
 create mode 100644 package/smstools3/smstools3.mk
package/Config.in +1 -0
index e502cde..1f4fe14 100644
@@ -901,6 +901,7 @@ source "package/samba/Config.in"
 source "package/sconeserver/Config.in"
 source "package/ser2net/Config.in"
 source "package/smcroute/Config.in"
+source "package/smstools3/Config.in"
 source "package/socat/Config.in"
 source "package/socketcand/Config.in"
 source "package/spawn-fcgi/Config.in"
package/smstools3/Config.in new file +24 -0
new file mode 100644
index 0000000..e0ea0f7
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_SMSTOOLS3
+	bool "smstools3"
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  The SMS Server Tools 3 is a SMS Gateway software which can send and
+	  receive short messages through GSM modems and mobile phones.
+
+	  http://smstools3.kekekasvi.com/
+
+if BR2_PACKAGE_SMSTOOLS3
+
+config BR2_PACKAGE_SMSTOOLS3_NB_MODEMS
+	string "Number of modems to support"
+	default 1
+
+config BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT
+	bool "Start SMS Server Tools at system boot"
+	default y
+
+endif
+
+comment "smstools3 needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/smstools3/S50smsd new file +43 -0
new file mode 100644
index 0000000..ded4189
@@ -0,0 +1,43 @@
+#!/bin/sh
+#
+# Starts the SMS Server Tools 3
+#
+
+NAME=smsd
+DAEMON=/usr/local/bin/$NAME
+PIDFILE=/var/run/$NAME.pid
+SPOOL=/var/spool/sms
+
+start()
+{
+	echo -n "Starting $NAME: "
+	mkdir -p $SPOOL/outgoing
+	mkdir -p $SPOOL/incoming
+	mkdir -p $SPOOL/checked
+	start-stop-daemon -S -q -p $PIDFILE --exec $DAEMON -- -c /etc/smsd.conf && echo "OK" || echo "Failed"
+}
+
+stop()
+{
+	echo -n "Stopping $NAME: "
+	start-stop-daemon -K -q -p $PIDFILE && echo "OK" || echo "Failed"
+	rm -f $PIDFILE
+}
+
+case "$1" in
+	start)
+		start
+		;;
+	stop)
+		stop
+		;;
+	restart|reload)
+		stop
+		start
+		;;
+	*)
+		echo "Usage: $0 {start|stop|restart}"
+		exit 1
+esac
+
+exit $?
package/smstools3/smstools3.mk new file +35 -0
new file mode 100644
index 0000000..2403b6f
@@ -0,0 +1,35 @@
+#############################################################
+#
+# smstools3
+#
+#############################################################
+
+SMSTOOLS3_VERSION = 3.1.15
+SMSTOOLS3_SITE = http://smstools3.kekekasvi.com/packages/
+SMSTOOLS3_LICENSE = GPLv2+
+SMSTOOLS3_LICENSE_FILES = doc/license.html LICENSE
+
+SMSTOOLS3_NB_MODEMS = $(call qstrip,$(BR2_PACKAGE_SMSTOOLS3_NB_MODEMS))
+SMSTOOLS3_CFLAGS = $(TARGET_CFLAGS)
+SMSTOOLS3_CFLAGS += -D NUMBER_OF_MODEMS=$(SMSTOOLS3_NB_MODEMS)
+SMSTOOLS3_CFLAGS += -D NOSTATS
+
+define SMSTOOLS3_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" CFLAGS="$(SMSTOOLS3_CFLAGS)" -C $(@D)
+endef
+
+ifeq ($(BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT),y)
+SMSTOOLS3_INIT_SCRIPT_NAME = S50smsd
+else
+SMSTOOLS3_INIT_SCRIPT_NAME = 50smsd
+endif
+
+define SMSTOOLS3_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/src/smsd $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/scripts/sendsms $(TARGET_DIR)/usr/local/bin
+	cp $(@D)/examples/smsd.conf.easy $(TARGET_DIR)/etc/
+	$(INSTALL) -m 0755 -D package/smstools3/S50smsd $(TARGET_DIR)/etc/init.d/$(SMSTOOLS3_INIT_SCRIPT_NAME)
+endef
+
+$(eval $(generic-package))
#2 lore raw

PATCH 1/1 Add SMS Tools Server 3 package

In reply to julien.boibessot at free.fr

On 01/08/2014 12:18 PM, julien.boibessot at free.fr wrote:

Hi. Let's see...

package/smstools3/Config.in line 15

Quoted 3 lines
package/smstools3/Config.in new file +3 -0
+config BR2_PACKAGE_SMSTOOLS3_NB_MODEMS
+	string "Number of modems to support"
+	default 1

What does this knob do in/to the code?

package/smstools3/Config.in line 19

Quoted 4 lines
package/smstools3/Config.in new file +4 -0
+
+config BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT
+	bool "Start SMS Server Tools at system boot"
+	default y

Ehhmm no, we don't make initscripts conditional that way, there are various hooks to get rid of it if someone doesn't want it that way or they run services their own way.

Quoted 11 lines
package/smstools3/Config.in new file +5 -0
+
+endif
+
+comment "smstools3 needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/smstools3/S50smsd new file +0 -0
new file mode 100644
index 0000000..ded4189

package/smstools3/S50smsd line 7

Quoted 7 lines
package/smstools3/S50smsd new file +7 -0
@@ -0,0 +1,43 @@
+#!/bin/sh
+#
+# Starts the SMS Server Tools 3
+#
+
+NAME=smsd
+DAEMON=/usr/local/bin/$NAME

/usr/local? Why?

package/smstools3/S50smsd line 12

Quoted 5 lines
package/smstools3/S50smsd new file +5 -0
+ifeq ($(BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT),y)
+SMSTOOLS3_INIT_SCRIPT_NAME = S50smsd
+else
+SMSTOOLS3_INIT_SCRIPT_NAME = 50smsd
+endif

Please use SMSTOOLS3_INSTALL_INIT_SYSV for the script. See docs/manual/adding-packages-generic.txt for the reason.

Otherwise looking good in general without testing it though. Regards.

#3 lore raw

PATCH 1/1 Add SMS Tools Server 3 package

Hello Gustavo,

and thanks for the review !

Quoted 8 lines · Gustavo Zacarias

On 01/08/2014 12:18 PM, julien.boibessot at free.fr wrote:

Hi. Let's see...

package/smstools3/Config.in line 15

Quoted 3 lines
package/smstools3/Config.in new file +3 -0
+config BR2_PACKAGE_SMSTOOLS3_NB_MODEMS
+	string "Number of modems to support"
+	default 1

What does this knob do in/to the code?

It (NUMBER_OF_MODEMS) is used in a very large number of loops of the program and by default set to 64.

Doc says: "If you are running SMSTools3 in an embedded device, you can use NUMBER_OF_MODEMS=1 to save memory."

Don't know why the author didn't choose to take dynamic command parameters instead of static code define...

Quoted 8 lines

package/smstools3/Config.in line 19

Quoted 5 lines
package/smstools3/Config.in new file +4 -0
+
+config BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT
+	bool "Start SMS Server Tools at system boot"
+	default y

Ehhmm no, we don't make initscripts conditional that way, there are various hooks to get rid of it if someone doesn't want it that way or they run services their own way.

ok !

Quoted 12 lines
Quoted 12 lines
package/smstools3/Config.in new file +5 -0
+
+endif
+
+comment "smstools3 needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/smstools3/S50smsd new file +0 -0
new file mode 100644
index 0000000..ded4189
@@ -0,0 +1,43 @@
Quoted 8 lines

package/smstools3/S50smsd line 7

Quoted 7 lines
package/smstools3/S50smsd new file +7 -0
+#!/bin/sh
+#
+# Starts the SMS Server Tools 3
+#
+
+NAME=smsd
+DAEMON=/usr/local/bin/$NAME

/usr/local? Why?

Well... no particular reason :-)
/usr would be ok ?

Quoted 8 lines

package/smstools3/S50smsd line 12

Quoted 6 lines
package/smstools3/S50smsd new file +5 -0
+ifeq ($(BR2_PACKAGE_SMSTOOLS3_START_AT_BOOT),y)
+SMSTOOLS3_INIT_SCRIPT_NAME = S50smsd
+else
+SMSTOOLS3_INIT_SCRIPT_NAME = 50smsd
+endif

Please use SMSTOOLS3_INSTALL_INIT_SYSV for the script. See docs/manual/adding-packages-generic.txt for the reason.

ok !

Quoted 2 lines

Otherwise looking good in general without testing it though.

Thanks !
I will send a corrected version tomorrow.

Regards,
Julien

#4 lore raw

PATCH 1/1 Add SMS Tools Server 3 package

Quoted 5 lines · Julien Boibessot
Quoted 4 lines

package/smstools3/Config.in line 15

Quoted 3 lines
package/smstools3/Config.in new file +3 -0
+config BR2_PACKAGE_SMSTOOLS3_NB_MODEMS
+	string "Number of modems to support"
+	default 1

What does this knob do in/to the code?

Quoted 8 lines

It (NUMBER_OF_MODEMS) is used in a very large number of loops of the program and by default set to 64.

Doc says: "If you are running SMSTools3 in an embedded device, you can use NUMBER_OF_MODEMS=1 to save memory."

Don't know why the author didn't choose to take dynamic command parameters instead of static code define...

Ok, i'm usually not comfortable with this kind of tuning but it's up to upstream to fix it.

Quoted 2 lines

Well... no particular reason :-)
/usr would be ok ?

Yes, /usr is the usual install directory, /usr/local is normally outside of the PATH and not practical.
Historically it's reserved for customizations so it shouldn't be used for a "default target".

Quoted 2 lines

Thanks !
I will send a corrected version tomorrow.

Thanks, looking forward to it :)
Regards.