Skip to contentSkip to conversation

osm_trap_rcv.c: Minimize time holding RW lock for, SystemImageGUID changed trap 145

PATCH New Hal Rosenstock 1 participant 1 message Jan 15, 2014 InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 3/4 osm_trap_rcv.c: Minimize time holding RW lock for, SystemImageGUID changed trap 145

Quoted 1 line

From e7c4ec39fff6c6c243ac57434eb8f8bbe6f783f8 Mon Sep 17 00:00:00 2001

From: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Thu, 15 Nov 2012 18:09:57 +0200
Subject: [PATCH 3/4] osm_trap_rcv.c: Minimize time holding RW lock for
SystemImageGUID changed trap 145

Release RW lock after updating SystemImageGUID and reacquire RO lock

Found-by Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 opensm/osm_trap_rcv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
opensm/osm_trap_rcv.c +2 -0
index 27f3e4a..2623536 100644
@@ -566,6 +566,8 @@ static void trap_rcv_process_request(IN osm_sm_t * sm,
 				p_physp->p_node->node_info.sys_guid =
 					p_ntci->data_details.ntc_145.new_sys_guid;
 			}
+			CL_PLOCK_RELEASE(sm->p_lock);
+			CL_PLOCK_ACQUIRE(sm->p_lock);
 		} else
 			OSM_LOG(sm->p_log, OSM_LOG_ERROR,
 				"ERR 3813: No physical port found for "
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html