2 bugs (errno = EINTR) in v4l2grab.c and v4l2gl.c?

PATCH Andreas Weber 1 participant 1 message Jan 16, 2014 Media (V4L/DVB)

Share & tools

Andreas Weber

author

2014-01-16 17:45 UTC #0 lore raw

Dear maintainers,

I guess these are 2 bugs:
contrib/test/v4l2grab.c:132: } while ((r == -1 && (errno = EINTR)));
contrib/test/v4l2gl.c:227: } while ((r == -1 && (errno = EINTR)));

please consider my attached patch if it's really a bug. Regards, Andy

Quoted 1 line

From 63d4fd18cb91852b64c81bf63d0d4100fc53d38d Mon Sep 17 00:00:00 2001

From: Andreas Weber <[email protected]>
Date: Thu, 16 Jan 2014 18:43:31 +0100
Subject: [PATCH] bugfix for errno assignment in while loop

---
 contrib/test/v4l2gl.c   |    2 +-
 contrib/test/v4l2grab.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

contrib/test/v4l2gl.c +1 -1

index e921212..4b549c1 100644
@@ -224,7 +224,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames,
 			tv.tv_usec = 0;
 
 			r = select(fd + 1, &fds, NULL, NULL, &tv);
-		} while ((r == -1 && (errno = EINTR)));
+		} while ((r == -1 && (errno == EINTR)));
 		if (r == -1) {
 			perror("select");
 			return errno;

contrib/test/v4l2grab.c +1 -1

index a93ad43..14d2a8f 100644
@@ -129,7 +129,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames,
 			tv.tv_usec = 0;
 
 			r = select(fd + 1, &fds, NULL, NULL, &tv);
-		} while ((r == -1 && (errno = EINTR)));
+		} while ((r == -1 && (errno == EINTR)));
 		if (r == -1) {
 			perror("select");
 			return errno;

Signature · 1 line

1.7.10.4