drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
PATCH 1/1 drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
Since we agreed on legacy implementation of "eeprom_{read|write}"
(http://patchwork.ozlabs.org/patch/295825/) I had to fix/make it work again DesignWare I2C driver for cases when 1 EEPROM IC fake I2C with anumber of "built-in" ICs with different chip addresses.
--- drivers/i2c/designware_i2c.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)
drivers/i2c/designware_i2c.c +38 -0
@@ -266,6 +266,25 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len) {unsigned long start_time_rx; +#ifdef CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW +/* +* EEPROM chips that implement "address overflow" are ones +* like Catalyst 24WC04/08/16 which has 9/10/11 bits of +* address and the extra bits end up in the "chip address" +* bit slots. This makes a 24WC08 (1Kbyte) chip look like +* four 256 byte chips. +* +* Note that we consider the length of the address field to +* still be one byte because the extra address bits are +* hidden in the chip address. +*/ + chip |= ((addr >> (alen *8 )) &CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW ); + addr &= ~(CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW << (alen *8 )); + +debug ("%s: fix addr_overflow: chip %02x addr %02x\n" , __func__, chip, + addr); +#endif +if (check_params (addr, alen, buffer, len))return 1 ;
@@ -307,6 +326,25 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len)int nb = len;unsigned long start_time_tx; +#ifdef CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW +/* +* EEPROM chips that implement "address overflow" are ones +* like Catalyst 24WC04/08/16 which has 9/10/11 bits of +* address and the extra bits end up in the "chip address" +* bit slots. This makes a 24WC08 (1Kbyte) chip look like +* four 256 byte chips. +* +* Note that we consider the length of the address field to +* still be one byte because the extra address bits are +* hidden in the chip address. +*/ + chip |= ((addr >> (alen *8 )) &CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW ); + addr &= ~(CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW << (alen *8 )); + +debug ("%s: fix addr_overflow: chip %02x addr %02x\n" , __func__, chip, + addr); +#endif +if (check_params (addr, alen, buffer, len))return 1 ;
Signature · 1 line
1.8.4.2
PATCH 1/1 drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
Quoted 4 lines · Alexey Brodkin
Since we agreed on legacy implementation of "eeprom_{read|write}"
(http://patchwork.ozlabs.org/patch/295825/) I had to fix/make it work again DesignWare I2C driver for cases when 1 EEPROM IC fake I2C with anumber of "built-in" ICs with different chip addresses.
Hi Heiko,
any chance to get this one applied?
Note this is not an enhancement - this is a required fix due to roll-back (http://patchwork.ozlabs.org/patch/295825/) of my previous fix in http://patchwork.ozlabs.org/patch/289346/
Regards,
Alexey
PATCH 1/1 drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
Hello Alexey,
Am 15.01.2014 16:37, schrieb Alexey Brodkin:
Quoted 9 lines · Alexey Brodkin
Quoted 4 lines
Since we agreed on legacy implementation of "eeprom_{read|write}"
(http://patchwork.ozlabs.org/patch/295825/) I had to fix/make it work again DesignWare I2C driver for cases when 1 EEPROM IC fake I2C with anumber of "built-in" ICs with different chip addresses.Hi Heiko,
any chance to get this one applied?
I picked it up, see:
http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=summary
http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=commit;h=32d041e218c6a22e92d91629902fd03a90934b6a
Quoted 3 lines
Note this is not an enhancement - this is a required fix due to roll-back (http://patchwork.ozlabs.org/patch/295825/) of my previous fix in http://patchwork.ozlabs.org/patch/289346/
Waiting for a testreport for another patch ... If I get no response, I send a pull request for this patch tomorrow ...
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 1/1 drivers/designware_i2c - add suppor of CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW
Quoted 6 lines · Heiko Schocher
Hello Alexey,
I picked it up, see:http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=summary
http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=commit;h=32d041e218c6a22e92d91629902fd03a90934b6a
Quoted 6 lines
Quoted 3 lines
Note this is not an enhancement - this is a required fix due to roll-back (http://patchwork.ozlabs.org/patch/295825/) of my previous fix in http://patchwork.ozlabs.org/patch/289346/
Waiting for a testreport for another patch ... If I get no response, I send a pull request for this patch tomorrow ...
Oops, sorry I didn't look at your tree before reminding. Thanks so much for your time.
-Alexey