turbostat, servers do not support uncore power register
PATCH 1/1 turbostat, servers do not support uncore power register
Quoted 1 line
From the Intel Software Developer's Manual section 14.7.4,
"For server platforms, PP1 domain is not supported, but its PP0 domain supports the MSR_PP0_PERF_STATUS interface."
When I run 'turbostat ls' I see the following error:
/dev/cpu/0/msr offset 0x641 read failed
because the server doesn't support the MSR_PP1_ENERGY_STATUS register (0x641). This patch implements a get_msr_nowarn() which suppresses the above warning and then sets !RAPL_GFX.
--- tools/power/x86/turbostat/turbostat.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)
tools/power/x86/turbostat/turbostat.c +18 -5
@@ -219,7 +219,7 @@ int cpu_migrate(int cpu)return 0 ; } -int get_msr (int cpu,off_t offset,unsigned long long *msr) +int _get_msr (int cpu,off_t offset,unsigned long long *msr,int warn) {ssize_t retval;char pathname[32 ];
@@ -234,13 +234,25 @@ int get_msr(int cpu, off_t offset, unsigned long long *msr)close (fd);if (retval !=sizeof *msr) { -fprintf (stderr,"%s offset 0x%zx read failed\n" , pathname, offset); +if (warn) +fprintf (stderr,"%s offset 0x%zx read failed\n" , + pathname, offset);return -1 ; }return 0 ; } +int get_msr (int cpu,off_t offset,unsigned long long *msr) +{ +return _get_msr (cpu, offset, msr,1 ); +} + +int get_msr_nowarn (int cpu,off_t offset,unsigned long long *msr) +{ +return _get_msr (cpu, offset, msr,0 ); +} +void print_header (void ) {if (show_pkg)
@@ -953,9 +965,10 @@ int get_counters(struct thread_data *t, struct core_data *c, struct pkg_data *p) p->energy_dram = msr &0xFFFFFFFF ; }if (do_rapl &RAPL_GFX ) { -if (get_msr (cpu,MSR_PP1_ENERGY_STATUS , &msr)) -return -16 ; - p->energy_gfx = msr &0xFFFFFFFF ; +if (get_msr_nowarn (cpu,MSR_PP1_ENERGY_STATUS , &msr)) + do_rapl &= ~RAPL_GFX ;/* unsupported on servers */ +else + p->energy_gfx = msr &0xFFFFFFFF ; }if (do_rapl &RAPL_PKG_PERF_STATUS ) {if (get_msr (cpu,MSR_PKG_PERF_STATUS , &msr))
Signature · 1 line
1.7.9.3
Rafael J. Wysocki
AppliedQuoted 13 lines · Prarit Bhargava
From the Intel Software Developer's Manual section 14.7.4,
"For server platforms, PP1 domain is not supported, but its PP0 domain supports the
MSR_PP0_PERF_STATUSinterface."When I run 'turbostat ls' I see the following error:
/dev/cpu/0/msroffset0x641read failedbecause the server doesn't support the
MSR_PP1_ENERGY_STATUSregister (0x641). This patch implements aget_msr_nowarn()which suppresses the above warning and then sets !RAPL_GFX.
Quoted 5 lines
Signed-off-by Prarit Bhargava <[email protected]>Cc Len Brown <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Josh Triplett <[email protected]>Cc Kristen Carlson Accardi <[email protected]>
Queued up for 3.14, thanks!
Quoted 59 lines
--- tools/power/x86/turbostat/turbostat.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-)tools/power/x86/turbostat/turbostat.c +18
-5@@ -219,7 +219,7 @@ int cpu_migrate(int cpu)return 0 ; } -int get_msr (int cpu,off_t offset,unsigned long long *msr) +int _get_msr (int cpu,off_t offset,unsigned long long *msr,int warn) {ssize_t retval;char pathname[32 ];@@ -234,13 +234,25 @@ int get_msr(int cpu, off_t offset, unsigned long long *msr)close (fd);if (retval !=sizeof *msr) { -fprintf (stderr,"%s offset 0x%zx read failed\n" , pathname, offset); +if (warn) +fprintf (stderr,"%s offset 0x%zx read failed\n" , + pathname, offset);return -1 ; }return 0 ; } +int get_msr (int cpu,off_t offset,unsigned long long *msr) +{ +return _get_msr (cpu, offset, msr,1 ); +} + +int get_msr_nowarn (int cpu,off_t offset,unsigned long long *msr) +{ +return _get_msr (cpu, offset, msr,0 ); +} +void print_header (void ) {if (show_pkg)@@ -953,9 +965,10 @@ int get_counters(struct thread_data *t, struct core_data *c, struct pkg_data *p) p->energy_dram = msr &0xFFFFFFFF ; }if (do_rapl &RAPL_GFX ) { -if (get_msr (cpu,MSR_PP1_ENERGY_STATUS , &msr)) -return -16 ; - p->energy_gfx = msr &0xFFFFFFFF ; +if (get_msr_nowarn (cpu,MSR_PP1_ENERGY_STATUS , &msr)) + do_rapl &= ~RAPL_GFX ;/* unsupported on servers */ +else + p->energy_gfx = msr &0xFFFFFFFF ; }if (do_rapl &RAPL_PKG_PERF_STATUS ) {if (get_msr (cpu,MSR_PKG_PERF_STATUS , &msr))
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
Len Brown
maintainerQuoted 8 lines · Prarit Bhargava
From the Intel Software Developer's Manual section 14.7.4,
"For server platforms, PP1 domain is not supported, but its PP0 domain supports the
MSR_PP0_PERF_STATUSinterface."When I run 'turbostat ls' I see the following error:
/dev/cpu/0/msroffset0x641read failed
Let me know if you see this when running turbostat v3.6 or later. you can find that version in the linux-next tree.
thanks,
Len Brown, Intel Open Source Technology Center
Quoted 6 lines · Len Brown
Quoted 5 lines · Prarit Bhargava
From the Intel Software Developer's Manual section 14.7.4,
"For server platforms, PP1 domain is not supported, but its PP0 domain supports the
MSR_PP0_PERF_STATUSinterface."
Quoted 7 lines
Quoted 3 lines
When I run 'turbostat ls' I see the following error:
/dev/cpu/0/msroffset0x641read failedLet me know if you see this when running turbostat v3.6 or later. you can find that version in the linux-next tree.
Len, looks like v3.6 works -- I'll do some additional testing to confirm but AFAICT it does work on the affected systems.
P.
Quoted 2 lines
thanks,
Len Brown, Intel Open Source Technology Center