Skip to contentSkip to conversation

mmc: core add the property for hs200

PATCH Superseded Jaehoon Chung 3 participants 5 messages Jan 28, 2014

Subsystems (2)
Device tree bindings MMC, SD and SDIO

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jaehoon Chung

author
#0 lore raw

PATCH v2 1/8 mmc: core add the property for hs200

mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.

Signed-off-by Jaehoon Chung <[email protected]>

---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt

 Documentation/devicetree/bindings/mmc/mmc.txt |    2 ++
 drivers/mmc/core/host.c                       |    4 ++++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/mmc/mmc.txt +2 -0
index 458b57f..4bb3894 100644
@@ -29,6 +29,8 @@ Optional properties:
 - cap-power-off-card: powering off the card is safe
 - cap-sdio-irq: enable SDIO IRQ signalling on this interface
 - full-pwr-cycle: full power cycle of the card is supported
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
drivers/mmc/core/host.c +4 -0
index 49bc403..5a82e81 100644
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
 		host->pm_caps |= MMC_PM_KEEP_POWER;
 	if (of_find_property(np, "enable-sdio-wakeup", &len))
 		host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+	if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+		host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+	if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+		host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
 
 	return 0;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 17 lines · Jaehoon Chung

mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.

Signed-off-by Jaehoon Chung <[email protected]>

---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt

 Documentation/devicetree/bindings/mmc/mmc.txt |    2 ++
 drivers/mmc/core/host.c                       |    4 ++++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/mmc/mmc.txt +0 -0
index 458b57f..4bb3894 100644

Documentation/devicetree/bindings/mmc/mmc.txt Optional properties: · line 31

Quoted 3 lines
Documentation/devicetree/bindings/mmc/mmc.txt +0 -0
@@ -29,6 +29,8 @@ Optional properties:
 - cap-power-off-card: powering off the card is safe
 - cap-sdio-irq: enable SDIO IRQ signalling on this interface
 - full-pwr-cycle: full power cycle of the card is supported

Why remove above? I guess a typo? :-)

Quoted 21 lines
Documentation/devicetree/bindings/mmc/mmc.txt +2 -0
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
drivers/mmc/core/host.c +4 -1
index 49bc403..5a82e81 100644
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
                host->pm_caps |= MMC_PM_KEEP_POWER;
        if (of_find_property(np, "enable-sdio-wakeup", &len))
                host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+       if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+       if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
 
        return 0;
 
--
Quoted 1 line

1.7.9.5

Once you fixed the above; you have my ack.

Kind regards
Uffe

author
#2 lore raw

Dear, Ulf.

Quoted 13 lines · Ulf Hansson
Quoted 12 lines · Jaehoon Chung

mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.

Signed-off-by Jaehoon Chung <[email protected]>

---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt

 Documentation/devicetree/bindings/mmc/mmc.txt |    2 ++
 drivers/mmc/core/host.c                       |    4 ++++
 2 files changed, 6 insertions(+)
Quoted 10 lines

Documentation/devicetree/bindings/mmc/mmc.txt Optional properties: · line 31

Quoted 8 lines
Documentation/devicetree/bindings/mmc/mmc.txt +0 -0
index 458b57f..4bb3894 100644
@@ -29,6 +29,8 @@ Optional properties:
 - cap-power-off-card: powering off the card is safe
 - cap-sdio-irq: enable SDIO IRQ signalling on this interface
 - full-pwr-cycle: full power cycle of the card is supported

Why remove above? I guess a typo? :-)

It's not removed. Just symbol in front of sentence. :)

Best Regards,
Jaehoon Chung

Quoted 33 lines
Quoted 22 lines
Documentation/devicetree/bindings/mmc/mmc.txt +2 -0
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
drivers/mmc/core/host.c +4 -1
index 49bc403..5a82e81 100644
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
                host->pm_caps |= MMC_PM_KEEP_POWER;
        if (of_find_property(np, "enable-sdio-wakeup", &len))
                host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+       if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+       if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
 
        return 0;
 
--
Quoted 1 line

1.7.9.5

Once you fixed the above; you have my ack.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 26 lines · Jaehoon Chung

Dear, Ulf.

Quoted 13 lines · Ulf Hansson
Quoted 12 lines · Jaehoon Chung

mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.

Signed-off-by Jaehoon Chung <[email protected]>

---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt

 Documentation/devicetree/bindings/mmc/mmc.txt |    2 ++
 drivers/mmc/core/host.c                       |    4 ++++
 2 files changed, 6 insertions(+)
Quoted 10 lines

Documentation/devicetree/bindings/mmc/mmc.txt Optional properties: · line 31

Quoted 8 lines
Documentation/devicetree/bindings/mmc/mmc.txt +0 -0
index 458b57f..4bb3894 100644
@@ -29,6 +29,8 @@ Optional properties:
 - cap-power-off-card: powering off the card is safe
 - cap-sdio-irq: enable SDIO IRQ signalling on this interface
 - full-pwr-cycle: full power cycle of the card is supported

Why remove above? I guess a typo? :-)

Quoted 1 line

It's not removed. Just symbol in front of sentence. :)

Hehehe. My bad, sorry for spamming.

You have my ack, then!

Kind regards
Uffe

Quoted 41 lines

Best Regards,
Jaehoon Chung

Quoted 26 lines
Quoted 22 lines
Documentation/devicetree/bindings/mmc/mmc.txt +2 -0
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
drivers/mmc/core/host.c +4 -1
index 49bc403..5a82e81 100644
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
                host->pm_caps |= MMC_PM_KEEP_POWER;
        if (of_find_property(np, "enable-sdio-wakeup", &len))
                host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+       if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+       if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+               host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;
 
        return 0;
 
--
Quoted 1 line

1.7.9.5

Once you fixed the above; you have my ack.

Quoted 7 lines

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
In reply to Jaehoon Chung
Quoted 31 lines · Jaehoon Chung

mmc-hs200-1.8v and mmc-hs200-1.2v can be used to the general capability.

Signed-off-by Jaehoon Chung <[email protected]>

---
Changelog V2:
- Rename the mmc-hs200-1_8v/1_2v instead of "_caps2_"
- Add the properties into Documentation/devicetree/bindings/mmc/mmc.txt

 Documentation/devicetree/bindings/mmc/mmc.txt |    2 ++
 drivers/mmc/core/host.c                       |    4 ++++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/mmc/mmc.txt +2 -0
index 458b57f..4bb3894 100644
@@ -29,6 +29,8 @@ Optional properties:
 - cap-power-off-card: powering off the card is safe
 - cap-sdio-irq: enable SDIO IRQ signalling on this interface
 - full-pwr-cycle: full power cycle of the card is supported
+- mmc-hs200-1_8v: HS200 mode(1.8V I/O) is supported
+- mmc-hs200-1_2v: HS200 mode(1.2V I/O) is supported
 
 *NOTE* on CD and WP polarity. To use common for all SD/MMC host controllers line
 polarity properties, we have to fix the meaning of the "normal" and "inverted"
drivers/mmc/core/host.c +0 -0
index 49bc403..5a82e81 100644

drivers/mmc/core/host.c int mmc_of_parse(struct mmc_host *host) · line 435

Quoted 7 lines
drivers/mmc/core/host.c +4 -0
@@ -429,6 +429,10 @@ int mmc_of_parse(struct mmc_host *host)
 		host->pm_caps |= MMC_PM_KEEP_POWER;
 	if (of_find_property(np, "enable-sdio-wakeup", &len))
 		host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
+	if (of_find_property(np, "mmc-hs200-1_8v", NULL))
+		host->caps2 |= MMC_CAP2_HS200_1_8V_SDR;
+	if (of_find_property(np, "mmc-hs200-1_2v", NULL))
+		host->caps2 |= MMC_CAP2_HS200_1_2V_SDR;

3rd argument(NULL) is replaced with 'len' at patch 2/8. Can be done here.

Thanks,
Seungwon Jeon

Quoted 9 lines
drivers/mmc/core/host.c +0 -1
 	return 0;
 
--

1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html