Add support for the ARC700 architecture

Signed-off-by Alexey Brodkin<[email protected]>

arch/arc/include/asm/arcregs.h new file +92 -0

new file mode 100644
index 0000000..87b0a60
@@ -0,0 +1,324 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _ASM_ARC_ARCREGS_H
+#define _ASM_ARC_ARCREGS_H
+
+#ifdef __KERNEL__
+
+/* Build Configuration Registers */
+#define ARC_REG_DCCMBASE_BCR	0x61	/* DCCM Base Addr */
+#define ARC_REG_CRC_BCR		0x62
+#define ARC_REG_DVFB_BCR	0x64
+#define ARC_REG_EXTARITH_BCR	0x65
+#define ARC_REG_VECBASE_BCR	0x68
+#define ARC_REG_PERIBASE_BCR	0x69
+#define ARC_REG_FP_BCR		0x6B	/* Single-Precision FPU */
+#define ARC_REG_DPFP_BCR	0x6C	/* Dbl Precision FPU */
+#define ARC_REG_DCCM_BCR	0x74	/* DCCM Present + SZ */
+#define ARC_REG_TIMERS_BCR	0x75
+#define ARC_REG_ICCM_BCR	0x78
+#define ARC_REG_XY_MEM_BCR	0x79
+#define ARC_REG_MAC_BCR		0x7a
+#define ARC_REG_MUL_BCR		0x7b
+#define ARC_REG_SWAP_BCR	0x7c
+#define ARC_REG_NORM_BCR	0x7d
+#define ARC_REG_MIXMAX_BCR	0x7e
+#define ARC_REG_BARREL_BCR	0x7f
+#define ARC_REG_D_UNCACH_BCR	0x6A
+
+/* status32 Bits Positions */
+#define STATUS_AE_BIT		5	/* Exception active */
+#define STATUS_DE_BIT		6	/* PC is in delay slot */
+#define STATUS_U_BIT		7	/* User/Kernel mode */
+#define STATUS_L_BIT		12	/* Loop inhibit */
+
+/* These masks correspond to the status word(STATUS_32) bits */
+#define STATUS_AE_MASK		(1<<STATUS_AE_BIT)
+#define STATUS_DE_MASK		(1<<STATUS_DE_BIT)
+#define STATUS_U_MASK		(1<<STATUS_U_BIT)
+#define STATUS_L_MASK		(1<<STATUS_L_BIT)
+
+/*
+ * ECR: Exception Cause Reg bits-n-pieces
+ * [23:16] = Exception Vector
+ * [15: 8] = Exception Cause Code
+ * [ 7: 0] = Exception Parameters (for certain types only)
+ */
+#define ECR_VEC_MASK			0xff0000
+#define ECR_CODE_MASK			0x00ff00
+#define ECR_PARAM_MASK			0x0000ff
+
+/* Exception Cause Vector Values */
+#define ECR_V_INSN_ERR			0x02
+#define ECR_V_MACH_CHK			0x20
+#define ECR_V_ITLB_MISS			0x21
+#define ECR_V_DTLB_MISS			0x22
+#define ECR_V_PROTV			0x23
+#define ECR_V_TRAP			0x25
+
+/* Protection Violation Exception Cause Code Values */
+#define ECR_C_PROTV_INST_FETCH		0x00
+#define ECR_C_PROTV_LOAD		0x01
+#define ECR_C_PROTV_STORE		0x02
+#define ECR_C_PROTV_XCHG		0x03
+#define ECR_C_PROTV_MISALIG_DATA	0x04
+
+#define ECR_C_BIT_PROTV_MISALIG_DATA	10
+
+/* Machine Check Cause Code Values */
+#define ECR_C_MCHK_DUP_TLB		0x01
+
+/* DTLB Miss Exception Cause Code Values */
+#define ECR_C_BIT_DTLB_LD_MISS		8
+#define ECR_C_BIT_DTLB_ST_MISS		9
+
+/* Dummy ECR values for Interrupts */
+#define event_IRQ1		0x0031abcd
+#define event_IRQ2		0x0032abcd
+
+/* Auxiliary registers */
+#define AUX_IDENTITY		4
+#define AUX_INTR_VEC_BASE	0x25
+
+
+/*
+ * Floating Pt Registers
+ * Status regs are read-only (build-time) so need not be saved/restored
+ */
+#define ARC_AUX_FP_STAT         0x300

arch/arc/include/asm/arcregs.h new file +47 -0

+
+#define read_aux_reg(reg)		\
+({					\
+	unsigned int __ret;		\
+	__asm__ __volatile__(		\
+	"	lr    %0, [%1]"		\
+	: "=r"(__ret)			\
+	: "i"(reg));			\
+	__ret;				\
+})
+
+/*
+ * Aux Reg address is specified as long immediate by caller
+ * e.g.
+ *    write_aux_reg(0x69, some_val);
+ * This generates tightest code.
+ */
+#define write_aux_reg(reg_imm, val)	\
+({					\
+	__asm__ __volatile__(		\
+	"	sr   %0, [%1]\n"	\
+	:				\
+	: "ir"(val), "i"(reg_imm));	\
+})
+
+/*
+ * Aux Reg address is specified in a variable
+ *  * e.g.
+ *      reg_num = 0x69
+ *      write_aux_reg2(reg_num, some_val);
+ * This has to generate glue code to load the reg num from
+ *  memory to a reg hence not recommended.
+ */
+#define write_aux_reg2(reg_in_var, val)		\
+({						\
+	unsigned int tmp;			\
+						\
+	__asm__ __volatile__(			\
+	"	ld   %0, [%2]\n\t"		\
+	"	sr   %1, [%0]\n\t"		\
+	: "=&r"(tmp)				\
+	: "r"(val), "memory"(&reg_in_var));	\
+})
+
+#endif
+
+#define READ_BCR(reg, into)				\

arch/arc/include/asm/arcregs.h new file +6 -0

+
+/* Helpers */
+#define TO_KB(bytes)		((bytes)>>  10)
+#define TO_MB(bytes)		(TO_KB(bytes)>>  10)
+#define PAGES_TO_KB(n_pages)	((n_pages)<<  (PAGE_SHIFT - 10))
+#define PAGES_TO_MB(n_pages)	(PAGES_TO_KB(n_pages)>>  10)

arch/arc/include/asm/ptrace.h new file +2 -0

new file mode 100644
index 0000000..3b2df87
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. All rights reserved.

arch/arc/include/asm/types.h new file +55 -0

new file mode 100644
index 0000000..7475db1
@@ -0,0 +1,55 @@
+/*
+ * Copyright (C) 2013-2014 Synopsys, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __ASM_ARC_TYPES_H
+#define __ASM_ARC_TYPES_H
+
+typedef unsigned short umode_t;
+
+/*
+ * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the
+ * header files exported to user space
+ */
+
+typedef __signed__ char __s8;
+typedef unsigned char __u8;
+
+typedef __signed__ short __s16;
+typedef unsigned short __u16;
+
+typedef __signed__ int __s32;
+typedef unsigned int __u32;
+
+#if defined(__GNUC__)&&  !defined(__STRICT_ANSI__)
+typedef __signed__ long long __s64;
+typedef unsigned long long __u64;
+#endif
+
+/*
+ * These aren't exported outside the kernel to avoid name space clashes
+ */
+typedef signed char s8;
+typedef unsigned char u8;
+
+typedef signed short s16;
+typedef unsigned short u16;
+
+typedef signed int s32;
+typedef unsigned int u32;
+
+typedef signed long long s64;
+typedef unsigned long long u64;
+
+#define BITS_PER_LONG 32
+
+/* Dma addresses are 32-bits wide.  */
+
+typedef u32 dma_addr_t;
+
+typedef unsigned long phys_addr_t;
+typedef unsigned long phys_size_t;
+
+#endif /* __ASM_ARC_TYPES_H */

arch/arc/include/asm/u-boot.h new file +15 -0

new file mode 100644
index 0000000..e354edf
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2013-2014 Synopsys, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __ASM_ARC_U_BOOT_H__
+#define __ASM_ARC_U_BOOT_H__
+
+#include<asm-generic/u-boot.h>
+
+/* For image.h:image_check_target_arch() */
+#define IH_ARCH_DEFAULT IH_ARCH_ARC
+
+#endif	/* __ASM_ARC_U_BOOT_H__ */

arch/arc/include/asm/unaligned.h new file +0 -0

new file mode 100644
index 0000000..6cecbbb

Hello Alexey,

Thanks for your patches, more or less just nitpicking comments ...

Am 29.01.2014 00:09, schrieb Alexey Brodkin:

Quoted 1 line

Signed-off-by Alexey Brodkin<[email protected]>

No commit message, please add one. (Are this files from the Linux kernel? If so please add a comment in the commit message + add a hint which linux commit you used, thanks!)

arch/arc/include/asm/arch-arc700/hardware.h

Quoted 3 lines

arch/arc/include/asm/arch-arc700/hardware.h new file +0 -0

new file mode 100644
index 0000000..e69de29

Empty file ?

Quoted 3 lines

arch/arc/include/asm/arcregs.h new file +0 -0

new file mode 100644
index 0000000..87b0a60

arch/arc/include/asm/arcregs.h line 102

Quoted 5 lines

arch/arc/include/asm/arcregs.h new file +5 -0

+
+#ifndef __ASSEMBLY__
+
+/*
+ ******************************************************************

Bad comment style

arch/arc/include/asm/arcregs.h line 115

Quoted 13 lines

+ * Inline ASM macros to read/write AUX Regs
+ * Essentially invocation of lr/sr insns from "C"
+ */

arch/arc/include/asm/arcregs.h new file +10 -0

+
+#if 1
+
+#define read_aux_reg(reg)	__builtin_arc_lr(reg)
+
+/* gcc builtin sr needs reg param to be long immediate */
+#define write_aux_reg(reg_immed, val)		\
+		__builtin_arc_sr((unsigned int)val, reg_immed)
+
+#else

Please remove dead code ...

Quoted 2 lines

arch/arc/include/asm/arcregs.h new file +2 -0

+
+#define read_aux_reg(reg)		\

arch/arc/include/asm/arcregs.h line 172

Quoted 3 lines

arch/arc/include/asm/arcregs.h new file +3 -0

+		bogus_undefined();			\
+	}						\
+}

Why do you use defines here instead of real functions?

arch/arc/include/asm/arcregs.h line 184

Quoted 12 lines

arch/arc/include/asm/arcregs.h new file +12 -0

+
+#define WRITE_BCR(reg, into)				\
+{							\
+	unsigned int tmp;				\
+	if (sizeof(tmp) == sizeof(into)) {		\
+		tmp = (*(unsigned int *)(into));	\
+		write_aux_reg(reg, tmp);		\
+	} else  {					\
+		extern void bogus_undefined(void);	\
+		bogus_undefined();			\
+	}						\
+}

and here?

arch/arc/include/asm/processor.h

Quoted 3 lines

arch/arc/include/asm/processor.h new file +0 -0

new file mode 100644
index 0000000..e69de29

Hups, one more empty file ...

Quoted 12 lines

arch/arc/include/asm/ptrace.h new file +6 -0

new file mode 100644
index 0000000..3b2df87
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+

arch/arc/include/asm/ptrace.h line 12

Quoted 6 lines

arch/arc/include/asm/ptrace.h new file +6 -0

+#ifndef __ASM_ARC_PTRACE_H
+#define __ASM_ARC_PTRACE_H
+
+#ifndef __ASSEMBLY__
+
+/* THE pt_regs: Defines how regs are saved during entry into kernel */

Is the "THE" a shortcut?

arch/arc/include/asm/string.h

Quoted 3 lines

arch/arc/include/asm/string.h new file +0 -0

new file mode 100644
index 0000000..e69de29

empty file

Hello Heiko,

Quoted 3 lines · Heiko Schocher

Hello Alexey,

Thanks for your patches, more or less just nitpicking comments ...

Thanks for prompt review.

Quoted 6 lines

Am 29.01.2014 00:09, schrieb Alexey Brodkin:

Quoted 1 line

Signed-off-by Alexey Brodkin<[email protected]>

No commit message, please add one. (Are this files from the Linux kernel? If so please add a comment in the commit message + add a hint which linux commit you used, thanks!)

I thought from commit subject it's already clear what's presented in each particular patch so I left commit messages empty. Frankly I'm not sure still what info may I put in commit messages except mention of headers borrowed from Linux - or this is exactly what is needed?

Agree I forgot to mention which header files came from Linux kernel. Will add mentions.

Quoted 5 lines

arch/arc/include/asm/arch-arc700/hardware.h

Quoted 3 lines

arch/arc/include/asm/arch-arc700/hardware.h new file +0 -0

new file mode 100644
index 0000000..e69de29

Empty file ?

Right, it looks weird, but I had to add this empty file just because of "designware_i2c" driver which refers to "asm/arch/hardware.h".

http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/i2c/designware_i2c.c;h=9ed929521a8944dc870fc2eff546507632b6e86a;hb=HEAD

And to remove "asm/arch/hardware.h" I would need to modify "arch/hardware.h" and "include/configs/..." files for platform/boards I don't own.

Basically this is just a work-around that allows me to use "designware_i2c" driver as it is.

There was a similar dependency ("asm/arch/clk.h") in "dw_mmc" but in that case it was possible to just remove it - what I did -
http://git.denx.de/?p=u-boot.git;a=commit;h=ca6d4d0f8f0fb8ae09a7ba271177367bdfdf3136

So if you insist on removal of this file we would need to fix "designware_i2c" first.

Please let me know what do you think about this item.

Quoted 3 lines

Quoted 3 lines

arch/arc/include/asm/arcregs.h new file +0 -0

new file mode 100644
index 0000000..87b0a60

...

Quoted 26 lines

arch/arc/include/asm/arcregs.h line 102

Quoted 5 lines

arch/arc/include/asm/arcregs.h new file +5 -0

+
+#ifndef __ASSEMBLY__
+
+/*
+ ******************************************************************

Bad comment style

arch/arc/include/asm/arcregs.h line 115

Quoted 13 lines

+ * Inline ASM macros to read/write AUX Regs
+ * Essentially invocation of lr/sr insns from "C"
+ */

arch/arc/include/asm/arcregs.h new file +10 -0

+
+#if 1
+
+#define read_aux_reg(reg)	__builtin_arc_lr(reg)
+
+/* gcc builtin sr needs reg param to be long immediate */
+#define write_aux_reg(reg_immed, val)		\
+		__builtin_arc_sr((unsigned int)val, reg_immed)
+
+#else

Please remove dead code ...

Quoted 2 lines

arch/arc/include/asm/arcregs.h new file +2 -0

+
+#define read_aux_reg(reg)		\

...

Quoted 6 lines

arch/arc/include/asm/arcregs.h line 172

Quoted 3 lines

arch/arc/include/asm/arcregs.h new file +3 -0

+		bogus_undefined();			\
+	}						\
+}

Why do you use defines here instead of real functions?

Quoted 14 lines

arch/arc/include/asm/arcregs.h line 184

Quoted 12 lines

arch/arc/include/asm/arcregs.h new file +12 -0

+
+#define WRITE_BCR(reg, into)				\
+{							\
+	unsigned int tmp;				\
+	if (sizeof(tmp) == sizeof(into)) {		\
+		tmp = (*(unsigned int *)(into));	\
+		write_aux_reg(reg, tmp);		\
+	} else  {					\
+		extern void bogus_undefined(void);	\
+		bogus_undefined();			\
+	}						\
+}

and here?

Ok, so this header is borrowed from Linux sources. That's why I didn't do any modifications and took it as it is on kernel.org.

Quoted 5 lines

arch/arc/include/asm/processor.h

Quoted 3 lines

arch/arc/include/asm/processor.h new file +0 -0

new file mode 100644
index 0000000..e69de29

Hups, one more empty file ...

I thought it was required by some common file. Double-checked and now see that it could be safely removed.

Quoted 12 lines

Quoted 12 lines

arch/arc/include/asm/ptrace.h new file +6 -0

new file mode 100644
index 0000000..3b2df87
@@ -0,0 +1,101 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. All rights reserved.
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+

Quoted 9 lines

arch/arc/include/asm/ptrace.h line 12

Quoted 6 lines

arch/arc/include/asm/ptrace.h new file +6 -0

+#ifndef __ASM_ARC_PTRACE_H
+#define __ASM_ARC_PTRACE_H
+
+#ifndef __ASSEMBLY__
+
+/* THE pt_regs: Defines how regs are saved during entry into kernel */

Is the "THE" a shortcut?

Another copy from Linux sources - thus taken as it is.

Quoted 5 lines

arch/arc/include/asm/string.h

Quoted 3 lines

arch/arc/include/asm/string.h new file +0 -0

new file mode 100644
index 0000000..e69de29

empty file

Somehow I missed a fact that ARC already has optimized "string" routines. Will add them in re-spin.

Will send a v2 series soon.

Maybe this site helps you:

http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign

Quoted 26 lines

Agree I forgot to mention which header files came from Linux kernel. Will add mentions.

Quoted 5 lines

arch/arc/include/asm/arch-arc700/hardware.h

Quoted 3 lines

arch/arc/include/asm/arch-arc700/hardware.h new file +0 -0

new file mode 100644
index 0000000..e69de29

Empty file ?

Right, it looks weird, but I had to add this empty file just because of "designware_i2c" driver which refers to "asm/arch/hardware.h".

http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/i2c/designware_i2c.c;h=9ed929521a8944dc870fc2eff546507632b6e86a;hb=HEAD

And to remove "asm/arch/hardware.h" I would need to modify "arch/hardware.h" and "include/configs/..." files for platform/boards I don't own.

Basically this is just a work-around that allows me to use "designware_i2c" driver as it is.

There was a similar dependency ("asm/arch/clk.h") in "dw_mmc" but in that case it was possible to just remove it - what I did -
http://git.denx.de/?p=u-boot.git;a=commit;h=ca6d4d0f8f0fb8ae09a7ba271177367bdfdf3136

Quoted 4 lines

So if you insist on removal of this file we would need to fix "designware_i2c" first.

Please let me know what do you think about this item.

Hmm.. at least you should an comment in this file, why it is necessary.

Ok, hope to find time for your other patches ...