Skip to contentSkip to conversation

ARM: keystone: config: fix build warning when CONFIG_DMADEVICES is not set

PATCH New Santosh Shilimkar 2 participants 3 messages Jan 9, 2014 – Jan 31, 2014

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Texas instrument Keystone architecture
lore
Share & tools
lore

Santosh Shilimkar

author
#0 lore raw

PATCH 1/1 ARM: keystone: config: fix build warning when CONFIG_DMADEVICES is not set

From: Grygorii Strashko <[email protected]>

Drop automatic selection of TI_EDMA from Keystone Kconfig file, as it produces build warning in case if CONFIG_DMADEVICES is not set:

warning: (ARCH_KEYSTONE) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))

Instead enable TI EDMA support from defconfig.

Reported-by Russell King <[email protected]>
Signed-off-by Grygorii Strashko <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

---

Kevin, Olof, Arnd,

Please let me know if you can pick this patch in 3.14 arm-soc queue or you prefer a pull request for the same. It applies against 'next/soc' cleanly.

Regards,
Santosh

 arch/arm/configs/keystone_defconfig |    1 +
 arch/arm/mach-keystone/Kconfig      |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/keystone_defconfig +1 -0
index a018244..4582e16 100644
@@ -142,6 +142,7 @@ CONFIG_USB_DWC3_DEBUG=y
 CONFIG_USB_DWC3_VERBOSE=y
 CONFIG_KEYSTONE_USB_PHY=y
 CONFIG_DMADEVICES=y
+CONFIG_TI_EDMA=y
 CONFIG_COMMON_CLK_DEBUG=y
 CONFIG_MEMORY=y
 CONFIG_EXT4_FS=y
arch/arm/mach-keystone/Kconfig +0 -1
index dabc5ee..90a708f 100644
@@ -10,7 +10,6 @@ config ARCH_KEYSTONE
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_ERRATA_798181 if SMP
 	select COMMON_CLK_KEYSTONE
-	select TI_EDMA
 	select ARCH_SUPPORTS_BIG_ENDIAN
 	select ZONE_DMA if ARM_LPAE
 	help
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: keystone: config: fix build warning when CONFIG_DMADEVICES is not set

Quoted 12 lines · Santosh Shilimkar

From: Grygorii Strashko <[email protected]>

Drop automatic selection of TI_EDMA from Keystone Kconfig file, as it produces build warning in case if CONFIG_DMADEVICES is not set:

warning: (ARCH_KEYSTONE) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))

Instead enable TI EDMA support from defconfig.

Reported-by Russell King <[email protected]>
Signed-off-by Grygorii Strashko <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>
Quoted 7 lines

---

Kevin, Olof, Arnd,

Please let me know if you can pick this patch in 3.14 arm-soc queue or you prefer a pull request for the same. It applies against 'next/soc' cleanly.

Seems like it was missed, I've applied it to fixes now.

-Olof

author
#2 lore raw

PATCH 1/1 ARM: keystone: config: fix build warning when CONFIG_DMADEVICES is not set

Quoted 15 lines · Olof Johansson
Quoted 14 lines · Santosh Shilimkar

From: Grygorii Strashko <[email protected]>

Drop automatic selection of TI_EDMA from Keystone Kconfig file, as it produces build warning in case if CONFIG_DMADEVICES is not set:

warning: (ARCH_KEYSTONE) selects TI_EDMA which has unmet direct dependencies (DMADEVICES && (ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE))

Instead enable TI EDMA support from defconfig.

Reported-by Russell King <[email protected]>
Signed-off-by Grygorii Strashko <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

---

Quoted 8 lines
Quoted 5 lines

Kevin, Olof, Arnd,

Please let me know if you can pick this patch in 3.14 arm-soc queue or you prefer a pull request for the same. It applies against 'next/soc' cleanly.

Seems like it was missed, I've applied it to fixes now.

Yep. Thanks.

Regards,
Santosh