Skip to contentSkip to conversation

mmc: set rca to 1 for MMC cards

PATCH New Stephen Warren 3 participants 3 messages Jan 30, 2014 – Feb 7, 2014 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: set rca to 1 for MMC cards

From: Stephen Warren <[email protected]>

U-Boot currently sets MMC cards' RCA register to 0. This value is reserved according to the specification. Use a value of 1 instead, just like the Linux kernel.

---
 drivers/mmc/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index c6a1c23fbf1c..7efc2bedbe11 100644
@@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
 	mmc->ocr = cmd.response[0];
 
 	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
-	mmc->rca = 0;
+	mmc->rca = 1;
 
 	return 0;
 }
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 mmc: set rca to 1 for MMC cards

Quoted 25 lines · Stephen Warren

From: Stephen Warren <[email protected]>

U-Boot currently sets MMC cards' RCA register to 0. This value is reserved according to the specification. Use a value of 1 instead, just like the Linux kernel.

---
 drivers/mmc/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index c6a1c23fbf1c..7efc2bedbe11 100644
@@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
 	mmc->ocr = cmd.response[0];
 
 	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
-	mmc->rca = 0;
+	mmc->rca = 1;
 
 	return 0;
 }
#2 lore raw

PATCH 1/1 mmc: set rca to 1 for MMC cards

In reply to Stephen Warren

Looks good.

Quoted 27 lines · Stephen Warren

From: Stephen Warren <[email protected]>

U-Boot currently sets MMC cards' RCA register to 0. This value is reserved according to the specification. Use a value of 1 instead, just like the Linux kernel.

---
drivers/mmc/mmc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/mmc.c +1 -1
index c6a1c23fbf1c..7efc2bedbe11 100644
@@ -430,7 +430,7 @@ int mmc_complete_op_cond(struct mmc *mmc)
 	mmc->ocr = cmd.response[0];
 
 	mmc->high_capacity = ((mmc->ocr & OCR_HCS) == OCR_HCS);
-	mmc->rca = 0;
+	mmc->rca = 1;
 
 	return 0;
 }
Signature · 1 line
1.8.1.5

Applied, Thanks.