Skip to contentSkip to conversation

clk: at91: remove redundant assignment

PATCH New Colin King 3 participants 3 messages Feb 6, 2014 – Feb 7, 2014

Subsystems (2)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 clk: at91: remove redundant assignment

From: Colin Ian King <[email protected]>

remove the redundant shift = shift assignment, it is extraneous.

---
 drivers/clk/at91/clk-programmable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-programmable.c +1 -1
index fd792b2..ff86efe 100644
@@ -109,7 +109,7 @@ static long clk_programmable_round_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long best_diff;
 	unsigned long new_diff;
 	unsigned long cur_rate;
-	int shift = shift;
+	int shift;
 
 	if (rate > *parent_rate)
 		return *parent_rate;
Signature · 1 line
1.9.rc1
#1 lore raw

PATCH 1/1 clk: at91: remove redundant assignment

On 06/02/2014 19:53, Colin King :

Quoted 5 lines

From: Colin Ian King <[email protected]>

remove the redundant shift = shift assignment, it is extraneous.

Thanks.

Boris, can you integrate this patch to the "fixes" series that will be sent to Mike during the 3.14 development cycle?

Bye,

Quoted 18 lines
---
 drivers/clk/at91/clk-programmable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-programmable.c +1 -1
index fd792b2..ff86efe 100644
@@ -109,7 +109,7 @@ static long clk_programmable_round_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long best_diff;
 	unsigned long new_diff;
 	unsigned long cur_rate;
-	int shift = shift;
+	int shift;
 
 	if (rate > *parent_rate)
 		return *parent_rate;
Signature · 1 line
Nicolas Ferre
#2 lore raw

PATCH 1/1 clk: at91: remove redundant assignment

Hi Nicolas, Colin,

Quoted 4 lines · Nicolas Ferre

On 06/02/2014 19:53, Colin King :

Quoted 3 lines

From: Colin Ian King <[email protected]>

remove the redundant shift = shift assignment, it is extraneous.

Thanks for reporting and fixing this.

Quoted 7 lines
Quoted 1 line

Thanks.

Boris, can you integrate this patch to the "fixes" series that will be sent to Mike during the 3.14 development cycle?

The round_rate function has been replaced by determine_rate and thus the bug is not present anymore.

See JJ's series:
http://us.generation-nt.com/patch-v2-0-4-clk-at91-better-support-pcks-help-213900572.html

Best Regards,

Boris

Quoted 21 lines

Bye,

Quoted 18 lines
---
  drivers/clk/at91/clk-programmable.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-programmable.c +1 -1
index fd792b2..ff86efe 100644
@@ -109,7 +109,7 @@ static long clk_programmable_round_rate(struct clk_hw *hw, unsigned long rate,
  	unsigned long best_diff;
  	unsigned long new_diff;
  	unsigned long cur_rate;
-	int shift = shift;
+	int shift;
 
  	if (rate > *parent_rate)
  		return *parent_rate;