Fix the arguments order of a few iscsi_conn_printk() calls
PATCH 1/1 Fix the arguments order of a few iscsi_conn_printk() calls
A few places had the opcode and itt arguments reversed. Fix the order.
--- drivers/scsi/libiscsi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/libiscsi.c +4 -4
@@ -1013,13 +1013,13 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,iscsi_conn_printk (KERN_ERR , conn,"pdu (op 0x%x itt 0x%x) rejected " "due to DataDigest error.\n" , - rejected_pdu.itt, opcode); + opcode, rejected_pdu.itt);break ;case ISCSI_REASON_IMM_CMD_REJECT :iscsi_conn_printk (KERN_ERR , conn,"pdu (op 0x%x itt 0x%x) rejected. Too many " "immediate commands.\n" , - rejected_pdu.itt, opcode); + opcode, rejected_pdu.itt);/* * We only send one TMF at a time so if the target could not * handle it, then it should get fixed (RFC mandates that
@@ -1059,8 +1059,8 @@ static int iscsi_handle_reject(struct iscsi_conn *conn, struct iscsi_hdr *hdr,default :iscsi_conn_printk (KERN_ERR , conn,"pdu (op 0x%x itt 0x%x) rejected. Reason " -"code 0x%x\n" , rejected_pdu.itt, - rejected_pdu.opcode, reject->reason); +"code 0x%x\n" , rejected_pdu.opcode, + rejected_pdu.itt, reject->reason);break ; }return rc;
Signature · 1 line
1.8.5.3
Quoted 5 lines · Michele Baldessari
A few places had the opcode and itt arguments reversed. Fix the order.
Reported-by Josef Moellers <[email protected]>Signed-off-by Michele Baldessari <[email protected]>
Thanks. I just acked a patch to do the same:
https://lkml.org/lkml/2014/1/8/754
Have you been hitting that code and with what target and what type of command?
Hi Mike,
Quoted 10 lines · Mike Christie
Quoted 5 lines · Michele Baldessari
A few places had the opcode and itt arguments reversed. Fix the order.
Reported-by Josef Moellers <[email protected]>Signed-off-by Michele Baldessari <[email protected]>Thanks. I just acked a patch to do the same:
https://lkml.org/lkml/2014/1/8/754
ah ok. Too many mailing lists and I did not see it in git master yet ;)
Quoted 2 lines
Have you been hitting that code and with what target and what type of command?
I was made aware of it by a colleague who was looking at code. So no real-life situation here.
regards,
Michele
Signature · 2 lines
Michele Baldessari <[email protected]> C2A5 9DA3 9961 4FFB E01B D0BC DDD4 DCCB 7515 5C6D