Skip to contentSkip to conversation

zynq: Use full tftpboot command instead of shortcut tftp

PATCH New Michal Simek 3 participants 7 messages Feb 5, 2014 – Feb 13, 2014 Arm/Zynq architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

---

 include/configs/zynq-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/zynq-common.h +1 -1
index 36b9508..f03c653 100644
@@ -149,7 +149,7 @@
 		"fatload mmc 0 ${load_addr} ${fit_image} && " \
 		"bootm ${load_addr}\0" \
 	"jtagboot=echo TFTPing FIT to RAM... && " \
-		"tftp ${load_addr} ${fit_image} && " \
+		"tftpboot ${load_addr} ${fit_image} && " \
 		"bootm ${load_addr}\0"
 #define CONFIG_BOOTCOMMAND		"run $modeboot"
 #define CONFIG_BOOTDELAY		3 /* -1 to Disable autoboot */

--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140205/640c0c97/attachment.pgp>

#1 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

Hi Michal,

Quoted 2 lines · Michal Simek

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

Hi Michal,

On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek
<[email protected]> wrote:

Quoted 7 lines
Quoted 2 lines

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.

Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error.

It means for short variables I can't see any problem with it
and definitely will be better to use full command names instead of shortcut.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140210/4b7f8d66/attachment.pgp>
#3 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

Hi Michal,

Quoted 16 lines · Michal Simek

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

Hi Michal,

On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek
<[email protected]> wrote:

Quoted 7 lines
Quoted 2 lines

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.

Quoted 6 lines

Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error.

It means for short variables I can't see any problem with it
and definitely will be better to use full command names instead of shortcut.

Extending to "short variables" only is fine with me -- I'm not asking you to re-engineer config header files, only to perform a cheap and useful search-and-replace.

Quoted 2 lines

Thanks,
Michal

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

Hi Albert,

Quoted 25 lines · Albert ARIBAUD

Hi Michal,

Quoted 19 lines · Michal Simek

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

Hi Michal,

On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek
<[email protected]> wrote:

Quoted 7 lines
Quoted 2 lines

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.

Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error.

Quoted 6 lines
Quoted 2 lines

It means for short variables I can't see any problem with it
and definitely will be better to use full command names instead of shortcut.

Extending to "short variables" only is fine with me -- I'm not asking you to re-engineer config header files, only to perform a cheap and useful search-and-replace.

Let's wait for others what they think and separate this from this patch because there is one more patch depends on this which you can see in my pull request.
I think we shouldn't limit this just to include/configs/*.h but also to all READMEs and comments.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140210/799461a0/attachment.pgp>
#5 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

Hi Michal,

Quoted 35 lines · Michal Simek

Hi Albert,

Quoted 25 lines · Albert ARIBAUD

Hi Michal,

Quoted 19 lines · Michal Simek

Hi Albert,

Quoted 5 lines · Albert ARIBAUD

Hi Michal,

On Wed, 5 Feb 2014 07:56:07 +0100, Michal Simek
<[email protected]> wrote:

Quoted 7 lines
Quoted 2 lines

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

Do you think you could extend this patch to all config files where the 'tftp' shortcut exists? This would prevent future issues on targets other than Zynq and hopefully it is only a matter of grepping / sed'ing through include/configs/*.h.

Based on my experience it is better to use full commands in variables but on the other hand I have met with the case when adding these 4 chars caused that max variable size has been exceed with error.

Quoted 6 lines
Quoted 2 lines

It means for short variables I can't see any problem with it
and definitely will be better to use full command names instead of shortcut.

Extending to "short variables" only is fine with me -- I'm not asking you to re-engineer config header files, only to perform a cheap and useful search-and-replace.

Quoted 5 lines

Let's wait for others what they think and separate this from this patch because there is one more patch depends on this which you can see in my pull request.
I think we shouldn't limit this just to include/configs/*.h but also to all READMEs and comments.

Ok, so a separate patch. Fine with me -- this answers my question re your PR.

Quoted 2 lines

Thanks,
Michal

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

PATCH 1/1 zynq: Use full tftpboot command instead of shortcut tftp

In reply to Michal Simek

Hi Michal,

Quoted 23 lines · Michal Simek

The reason is enabling tftpput command where
tftp shorcut stops to work for tftpboot.

---

 include/configs/zynq-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/zynq-common.h +1 -2
index 36b9508..f03c653 100644
@@ -149,7 +149,7 @@
 		"fatload mmc 0 ${load_addr} ${fit_image} && " \
 		"bootm ${load_addr}\0" \
 	"jtagboot=echo TFTPing FIT to RAM... && " \
-		"tftp ${load_addr} ${fit_image} && " \
+		"tftpboot ${load_addr} ${fit_image} && " \
 		"bootm ${load_addr}\0"
 #define CONFIG_BOOTCOMMAND		"run $modeboot"
 #define CONFIG_BOOTDELAY		3 /* -1 to Disable autoboot */
--
Quoted 3 lines

1.8.2.3

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.