Skip to contentSkip to conversation

exynos4 / g2d

DISCUSSION Sachin Kamat 3 participants 6 messages Feb 10, 2014 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sachin Kamat

author
#1 lore raw

+cc linux-media list and some related maintainers

Hi,

Quoted 9 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

Signature · 2 lines
With warm regards,
Sachin
#2 lore raw

Hello!

Quoted 13 lines · Sachin Kamat

+cc linux-media list and some related maintainers

Hi,

Quoted 8 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Quoted 6 lines
Quoted 1 line

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

That doesn't make sense to me. From the initial commit message of the DRM code:
"The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA."
(https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a)

In fact, this doesn't even mention the Exynos5?!

Greets,
Tobias

author
#3 lore raw

+cc Joonyoung Shim

Hi,

Quoted 23 lines · Tobias Jakobi

Hello!

Quoted 13 lines · Sachin Kamat

+cc linux-media list and some related maintainers

Hi,

Quoted 8 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Quoted 6 lines
Quoted 1 line

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

Quoted 8 lines

That doesn't make sense to me. From the initial commit message of the DRM code:
"The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA."
(https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a)

In fact, this doesn't even mention the Exynos5?!

It does say "later Exynos series from Exynos4X12" which technically includes Exynos5 and
does not include previous Exynos series SoCs like 4210, etc. Anyway, I haven't tested this driver on Exynos4 based platforms and hence cannot confirm if it
supports 4x12 in the current form. I leave it to the original author and Inki to comment about it.

Signature · 2 lines
With warm regards,
Sachin
#4 lore raw

2014-02-10 17:44 GMT+09:00 Sachin Kamat <[email protected]>:

Quoted 35 lines

+cc Joonyoung Shim

Hi,

Quoted 30 lines · Tobias Jakobi

Hello!

Quoted 13 lines · Sachin Kamat

+cc linux-media list and some related maintainers

Hi,

Quoted 8 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Quoted 6 lines
Quoted 1 line

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

That doesn't make sense to me. From the initial commit message of the DRM code:
"The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA."
(https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a)

Quoted 4 lines
Quoted 1 line

In fact, this doesn't even mention the Exynos5?!

It does say "later Exynos series from Exynos4X12" which technically includes Exynos5 and

Right, supported.

Quoted 6 lines

does not include previous Exynos series SoCs like 4210, etc. Anyway, I haven't tested this driver on Exynos4 based platforms and hence cannot confirm if it
supports 4x12 in the current form. I leave it to the original author and Inki to comment about it.

Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to use g2d driver on exynos4212 SoC. We already tested this driver on Exynos4x12 SoC also. We didn't just post dt support patch for exynos4x12 series.

Thanks,
Inki Dae

Quoted 7 lines

--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
Quoted 50 lines · Inki Dae

2014-02-10 17:44 GMT+09:00 Sachin Kamat <[email protected]>:

Quoted 35 lines

+cc Joonyoung Shim

Hi,

Quoted 30 lines · Tobias Jakobi

Hello!

Quoted 13 lines · Sachin Kamat

+cc linux-media list and some related maintainers

Hi,

Quoted 8 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Quoted 6 lines
Quoted 1 line

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

That doesn't make sense to me. From the initial commit message of the DRM code:
"The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA."
(https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a)

Quoted 4 lines
Quoted 1 line

In fact, this doesn't even mention the Exynos5?!

It does say "later Exynos series from Exynos4X12" which technically includes Exynos5 and

Right, supported.

Quoted 6 lines

does not include previous Exynos series SoCs like 4210, etc. Anyway, I haven't tested this driver on Exynos4 based platforms and hence cannot confirm if it
supports 4x12 in the current form. I leave it to the original author and Inki to comment about it.

Quoted 4 lines

Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to use g2d driver on exynos4212 SoC. We already tested this driver on Exynos4x12 SoC also. We didn't just post dt support patch for exynos4x12 series.

If you prefer I could add that and send a patch. I wouldn't be able to test it though.

Signature · 2 lines
With warm regards,
Sachin
#6 lore raw
Quoted 48 lines · Sachin Kamat
Quoted 47 lines · Inki Dae

2014-02-10 17:44 GMT+09:00 Sachin Kamat <[email protected]>:

Quoted 35 lines

+cc Joonyoung Shim

Hi,

Quoted 30 lines · Tobias Jakobi

Hello!

Quoted 13 lines · Sachin Kamat

+cc linux-media list and some related maintainers

Hi,

Quoted 8 lines · Tobias Jakobi

Hello!

I noticed while here
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
the necessary entry for the dts was made, on the drm driver side
(https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/exynos/exynos_drm_g2d.c)
this was never added.

Quoted 6 lines
Quoted 1 line

Shouldn't "samsung,exynos4212-g2d" go into exynos_g2d_match as well?

The DRM version of G2D driver does not support Exynos4 based G2D IP yet. The support for this IP
is available only in the V4L2 version of the driver. Please see the file:
drivers/media/platform/s5p-g2d/g2d.c

That doesn't make sense to me. From the initial commit message of the DRM code:
"The G2D is a 2D graphic accelerator that supports Bit Block Transfer. This G2D driver is exynos drm specific and supports only G2D(version 4.1) of later Exynos series from Exynos4X12 because supporting DMA."
(https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpu/drm/exynos/exynos_drm_g2d.c?id=d7f1642c90ab5eb2d7c48af0581c993094f97e1a)

Quoted 3 lines
Quoted 1 line

In fact, this doesn't even mention the Exynos5?!

It does say "later Exynos series from Exynos4X12" which technically includes Exynos5 and

Right, supported.

Quoted 6 lines

does not include previous Exynos series SoCs like 4210, etc. Anyway, I haven't tested this driver on Exynos4 based platforms and hence cannot confirm if it
supports 4x12 in the current form. I leave it to the original author and Inki to comment about it.

Quoted 7 lines
Quoted 4 lines

Just add "samsung,exynos4212-g2d" to exynos_g2d_match if you want to use g2d driver on exynos4212 SoC. We already tested this driver on Exynos4x12 SoC also. We didn't just post dt support patch for exynos4x12 series.

If you prefer I could add that and send a patch. I wouldn't be able to test it though.

Thanks for the feedback!

The reason for bringing this up is the following. I'm trying to get the G2D block working through the DRM interface on a Hardkernel ODROID-X2, which is Exynos4412 based. Hardkernel provides a modified 3.8.y kernel, which they somehow "support". The problem is that the G2D doesn't work there. I can provide more specific details on that, if wanted.

So my plan was to check if the G2D at least works with a more recent kernel. I'm currently working on getting 3.13.y vanilla running on the device and then want to test the G2D block there (e.g. with the test tool that is included in the libdrm tree -- this is also the one that fails on the odroid kernel).

Obviously this would be huge waste of time, if you guys would tell me that the G2D isn't working (at least through the DRM) on the Exynos4412 platform anyway.

With best regards,
Tobias