ARM: dts: OMAP2+: Fix boot with multi_v7_defconfig
PATCH 1/1 ARM: dts: OMAP2+: Fix boot with multi_v7_defconfig
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with CONFIG_USB_EHCI_HCD_PLATFORM=y e.g. multi_v7_defconfig
--- arch/arm/boot/dts/omap3.dtsi | 2 +- arch/arm/boot/dts/omap4.dtsi | 2 +- arch/arm/boot/dts/omap5.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/omap3.dtsi +1 -1
@@ -641,7 +641,7 @@ }; usbhsehci: ehci at 48064800 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x48064800 0x400>; interrupt-parent = <&intc>; interrupts = <77>;
arch/arm/boot/dts/omap4.dtsi +1 -1
@@ -706,7 +706,7 @@ }; usbhsehci: ehci at 4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
arch/arm/boot/dts/omap5.dtsi +1 -1
@@ -784,7 +784,7 @@ }; usbhsehci: ehci at 4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
1.8.3.2
$subject probably needs clarity.
Quoted 2 lines · Roger Quadros
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
might want to refer to the change in drivers/usb/host/ehci-platform.c that created this regression as well.
we also probably want to make better explanation about this issue and why we think this is the correct fix for it - for example, question Kevin asked in [1]
Quoted 7 lines
This fixes boot on OMAP platforms with
CONFIG_USB_EHCI_HCD_PLATFORM=ye.g.multi_v7_defconfigReported-by Nishanth Menon <[email protected]>Signed-off-by Roger Quadros <[email protected]>---
[1] http://marc.info/?t=139204803900004&r=1&w=2
Signature · 2 lines
Regards, Nishanth Menon
Quoted 8 lines · Roger Quadros
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with
CONFIG_USB_EHCI_HCD_PLATFORM=ye.g.multi_v7_defconfigReported-by Nishanth Menon <[email protected]>Signed-off-by Roger Quadros <[email protected]>
Please ignore this patch as Hans has agreed to do a more proper fix in
http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015
cheers,
-roger
Quoted 46 lines
--- arch/arm/boot/dts/omap3.dtsi | 2 +- arch/arm/boot/dts/omap4.dtsi | 2 +- arch/arm/boot/dts/omap5.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)arch/arm/boot/dts/omap3.dtsi +1
-1@@ -641,7 +641,7 @@ }; usbhsehci: ehci at 48064800 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x48064800 0x400>; interrupt-parent = <&intc>; interrupts = <77>;arch/arm/boot/dts/omap4.dtsi +1
-1@@ -706,7 +706,7 @@ }; usbhsehci: ehci at 4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;arch/arm/boot/dts/omap5.dtsi +1
-1@@ -784,7 +784,7 @@ }; usbhsehci: ehci at 4a064c00 { - compatible = "ti,ehci-omap", "usb-ehci"; + compatible = "ti,ehci-omap"; reg = <0x4a064c00 0x400>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
Quoted 7 lines · Roger Quadros
Quoted 6 lines · Roger Quadros
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with
CONFIG_USB_EHCI_HCD_PLATFORM=ye.g.multi_v7_defconfig
Quoted 6 lines
Quoted 2 lines
Reported-by Nishanth Menon <[email protected]>Signed-off-by Roger Quadros <[email protected]>Please ignore this patch as Hans has agreed to do a more proper fix in
http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015
umm.. even then, drivers/usb/host/ehci-ppc-of.c claims compatibility with usb,ehci -> and we wont function with that driver either.
Signature · 2 lines
Regards, Nishanth Menon
Hi,
Quoted 8 lines · Nishanth Menon
Quoted 7 lines · Roger Quadros
Quoted 6 lines · Roger Quadros
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with
CONFIG_USB_EHCI_HCD_PLATFORM=ye.g.multi_v7_defconfig
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Reported-by Nishanth Menon <[email protected]>Signed-off-by Roger Quadros <[email protected]>Please ignore this patch as Hans has agreed to do a more proper fix in
http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015
umm.. even then,
drivers/usb/host/ehci-ppc-of.cclaims compatibility with usb,ehci -> and we wont function with that driver either.
Right, but that has never been an issue as no kernel will ever include both ppc and omap support.
Regards,
Hans
Quoted 12 lines · Hans de Goede
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Roger Quadros
Quoted 8 lines · Roger Quadros
The OMAP EHCI controller is not compatible with the EHCI platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with
CONFIG_USB_EHCI_HCD_PLATFORM=ye.g.multi_v7_defconfigReported-by Nishanth Menon <[email protected]>Signed-off-by Roger Quadros <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Please ignore this patch as Hans has agreed to do a more proper fix in
http://article.gmane.org/gmane.comp.hardware.netbook.arm.sunxi/7015
umm.. even then,
drivers/usb/host/ehci-ppc-of.cclaims compatibility with usb,ehci -> and we wont function with that driver either.Right, but that has never been an issue as no kernel will ever include both ppc and omap support.
Conceptually, we have compatibility string today in dts description that maps a driver that cant ever handle the device. I dont have strong opinions either way.. just something i noticed with a git grep..
Signature · 2 lines
Regards, Nishanth Menon