Skip to contentSkip to conversation

a package infrastructure for Perl/CPAN modules

PATCH Superseded Francois Perrad 3 participants 11 messages Feb 11, 2014 – Feb 13, 2014

v8 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v8 cover a package infrastructure for Perl/CPAN modules

delta V7 vs V8 :
- typo and minor improvements

delta V6 vs V7 :
- global
+ substitute 'perl_5' by 'Artistic or GPLv1+'
- scancpan
+ remove 'NO ABSTRACT'
+ check Module::CoreList::is_core with the target Perl version
+ add packages Module-CoreList and MetaCPAN-API-Tiny instead of use Fatpack
+ add GPL

delta V5 vs V6 :

- export PERL5LIB
- rename PKG_PERL_ARCHNAME to PERL_ARCHNAME
- remove $(2)_*_OPT (with empty default value)
- remove PERL_INSTALL_TARGET_GOALS

Francois Perrad (6):
pkg-perl: new infrastructure
scancpan: a new script
host-perl-xml-parser: rename and refactor with perl infrastructure
host-perl-module-build: new package
manual: adding packages perl
perl: remove PERL_INSTALL_TARGET_GOALS

 Config.in                                          |   11 +
 docs/manual/adding-packages-perl.txt               |  110 ++++++++++
 docs/manual/adding-packages.txt                    |    2 +
 package/Config.in                                  |    1 -
 package/Makefile.in                                |    4 +-
 package/intltool/intltool.mk                       |    2 +-
 package/libxml-parser-perl/Config.in               |   10 -
 package/libxml-parser-perl/libxml-parser-perl.mk   |   35 ---
 package/metacity/metacity.mk                       |    2 +-
 .../perl-metacpan-api-tiny.mk                      |   12 +
 package/perl-module-build/perl-module-build.mk     |   12 +
 .../perl-module-corelist/perl-module-corelist.mk   |   13 ++
 package/perl-xml-parser/perl-xml-parser.mk         |   17 ++
 package/perl/perl.mk                               |    4 +-
 package/pkg-perl.mk                                |  181 ++++++++++++++++
 support/scripts/scancpan                           |  229 ++++++++++++++++++++
 16 files changed, 593 insertions(+), 52 deletions(-)
 create mode 100644 docs/manual/adding-packages-perl.txt
 delete mode 100644 package/libxml-parser-perl/Config.in
 delete mode 100644 package/libxml-parser-perl/libxml-parser-perl.mk
 create mode 100644 package/perl-metacpan-api-tiny/perl-metacpan-api-tiny.mk
 create mode 100644 package/perl-module-build/perl-module-build.mk
 create mode 100644 package/perl-module-corelist/perl-module-corelist.mk
 create mode 100644 package/perl-xml-parser/perl-xml-parser.mk
 create mode 100644 package/pkg-perl.mk
 create mode 100755 support/scripts/scancpan
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v8 1/6 pkg-perl: new infrastructure

---
 Config.in           |   11 ++++
 package/Makefile.in |    4 +-
 package/pkg-perl.mk |  181 +++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 195 insertions(+), 1 deletion(-)
 create mode 100644 package/pkg-perl.mk
Config.in +11 -0
index bcfefc7..c0b44d7 100644
@@ -225,6 +225,17 @@ config BR2_LUAROCKS_MIRROR
 
 	  See http://luarocks.org
 
+config BR2_CPAN_MIRROR
+	string "CPAN mirror (Perl packages)"
+	default "http://search.cpan.org/CPAN"
+	help
+	  CPAN (Comprehensive Perl Archive Network) is a repository
+	  of Perl packages. It has multiple software mirrors scattered
+	  around the world. This option allows you to select a mirror.
+
+	  The list of mirrors is available at:
+	  http://search.cpan.org/mirror
+
 endmenu
 
 config BR2_JLEVEL
package/Makefile.in +3 -1
index eea7043..454f614 100644
@@ -206,7 +206,8 @@ HOST_PATH=$(HOST_DIR)/bin:$(HOST_DIR)/usr/bin:$(PATH)
 HOSTCC_VERSION:=$(shell $(HOSTCC_NOCCACHE) --version | \
 	sed -n 's/^.* \([0-9]*\)\.\([0-9]*\)\.\([0-9]*\)[ ]*.*$$/\1\2\3/p')
 
-export PERL5LIB := $(HOST_DIR)/usr/lib/perl
+HOST_PERL_ARCHNAME := $(shell perl -MConfig -e "print Config->{archname}")
+export PERL5LIB := $(HOST_DIR)/usr/lib/perl5/$(HOST_PERL_ARCHNAME):$(HOST_DIR)/usr/lib/perl5
 
 TARGET_CONFIGURE_OPTS=PATH=$(TARGET_PATH) \
 		AR="$(TARGET_AR)" \
@@ -359,5 +360,6 @@ include package/pkg-download.mk
 include package/pkg-autotools.mk
 include package/pkg-cmake.mk
 include package/pkg-luarocks.mk
+include package/pkg-perl.mk
 include package/pkg-python.mk
 include package/pkg-generic.mk
package/pkg-perl.mk new file +181 -0

181 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v8 2/6 scancpan: a new script

In reply to Francois Perrad

which creates Perl/CPAN package files

The 2 dependencies will be installed by the Perl infrastructure.

---
 .../perl-metacpan-api-tiny.mk                      |   12 +
 .../perl-module-corelist/perl-module-corelist.mk   |   13 ++
 support/scripts/scancpan                           |  229 ++++++++++++++++++++
 3 files changed, 254 insertions(+)
 create mode 100644 package/perl-metacpan-api-tiny/perl-metacpan-api-tiny.mk
 create mode 100644 package/perl-module-corelist/perl-module-corelist.mk
 create mode 100755 support/scripts/scancpan
package/perl-metacpan-api-tiny/perl-metacpan-api-tiny.mk new file +12 -0
new file mode 100644
index 0000000..c94835e
@@ -0,0 +1,12 @@
+################################################################################
+#
+# perl-metacpan-api-tiny
+#
+################################################################################
+
+PERL_METACPAN_API_TINY_VERSION = 1.131730
+PERL_METACPAN_API_TINY_SOURCE = MetaCPAN-API-Tiny-$(PERL_METACPAN_API_TINY_VERSION).tar.gz
+PERL_METACPAN_API_TINY_SITE = $(BR2_CPAN_MIRROR)/authors/id/N/NP/NPEREZ/
+PERL_METACPAN_API_TINY_LICENSE = Artistic or GPLv1+
+
+$(eval $(host-perl-package))
package/perl-module-corelist/perl-module-corelist.mk new file +13 -0
new file mode 100644
index 0000000..0f979dd
@@ -0,0 +1,13 @@
+################################################################################
+#
+# perl-module-corelist
+#
+################################################################################
+
+# aligned with Perl 5.18.2
+PERL_MODULE_CORELIST_VERSION = 3.03
+PERL_MODULE_CORELIST_SOURCE = Module-CoreList-$(PERL_MODULE_CORELIST_VERSION).tar.gz
+PERL_MODULE_CORELIST_SITE = $(BR2_CPAN_MIRROR)/authors/id/B/BI/BINGOS/
+PERL_MODULE_CORELIST_LICENSE = Artistic or GPLv1+
+
+$(eval $(host-perl-package))
support/scripts/scancpan new file +229 -0

229 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#3 lore raw

PATCH v8 3/6 host-perl-xml-parser: rename and refactor with perl infrastructure

In reply to Francois Perrad

Even though libxml-parser-perl had a Config.in file with an option to enable it on the target, this option was hidden by a dependency on BR2_HOST_ONLY. So in practice, it was not possible to enable libxml-parser-perl on the target. This allows us to rename libxml-parser-perl to perl-xml-parser to follow the new naming convention of Perl packages, without having to introduce Config.in.legacy material.

In addition to this rename, the package is converted to use the newly introduced Perl package infrastructure.

---
 package/Config.in                                |    1 -
 package/intltool/intltool.mk                     |    2 +-
 package/libxml-parser-perl/Config.in             |   10 -------
 package/libxml-parser-perl/libxml-parser-perl.mk |   35 ----------------------
 package/metacity/metacity.mk                     |    2 +-
 package/perl-xml-parser/perl-xml-parser.mk       |   17 +++++++++++
 6 files changed, 19 insertions(+), 48 deletions(-)
 delete mode 100644 package/libxml-parser-perl/Config.in
 delete mode 100644 package/libxml-parser-perl/libxml-parser-perl.mk
 create mode 100644 package/perl-xml-parser/perl-xml-parser.mk
package/Config.in +0 -1
index fca61d6..68b4870 100644
@@ -616,7 +616,6 @@ source "package/json-c/Config.in"
 source "package/json-glib/Config.in"
 source "package/libjson/Config.in"
 source "package/libroxml/Config.in"
-source "package/libxml-parser-perl/Config.in"
 source "package/libxml2/Config.in"
 source "package/libxmlpp/Config.in"
 source "package/libxslt/Config.in"
package/intltool/intltool.mk +1 -1
index 58b46e6..6b2a704 100644
@@ -9,7 +9,7 @@ INTLTOOL_SITE = https://launchpad.net/intltool/trunk/$(INTLTOOL_VERSION)/+downlo
 INTLTOOL_LICENSE = GPLv2+
 INTLTOOL_LICENSE_FILES = COPYING
 
-HOST_INTLTOOL_DEPENDENCIES = host-gettext host-libxml-parser-perl
+HOST_INTLTOOL_DEPENDENCIES = host-gettext host-perl-xml-parser
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
package/libxml-parser-perl/Config.in deleted +0 -10
deleted file mode 100644
index bdda236..0000000
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_LIBXML_PARSER_PERL
-	bool "libxml-parser-perl"
-	select BR2_PACKAGE_EXPAT
-	# Hide from configuration as we only support the host package
-	# for the moment
-	depends on BR2_HOST_ONLY
-	help
-	  The Perl XML::Parser module.
-
-	  http://www.cpan.org/modules/by-module/XML/
package/libxml-parser-perl/libxml-parser-perl.mk deleted +0 -35
deleted file mode 100644
index 53f3bcf..0000000
@@ -1,35 +0,0 @@
-################################################################################
-#
-# libxml-parser-perl
-#
-################################################################################
-
-LIBXML_PARSER_PERL_VERSION = 2.36
-LIBXML_PARSER_PERL_SOURCE = XML-Parser-$(LIBXML_PARSER_PERL_VERSION).tar.gz
-LIBXML_PARSER_PERL_SITE = http://www.cpan.org/modules/by-module/XML/
-
-LIBXML_PARSER_PERL_DEPENDENCIES = expat
-
-define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
- (cd $(@D) ; \
-   $(HOST_CONFIGURE_OPTS) perl Makefile.PL \
-        PREFIX=$(HOST_DIR)/usr \
-        EXPATLIBPATH=$(HOST_DIR)/usr/lib \
-        EXPATINCPATH=$(HOST_DIR)/usr/include \
-        INSTALLDIRS=site \
-        INSTALLSITELIB=$(HOST_DIR)/usr/lib/perl \
-        INSTALLSITEARCH=$(HOST_DIR)/usr/lib/perl \
-        USE_MM_LD_RUN_PATH=1 \
- )
-endef
-
-define HOST_LIBXML_PARSER_PERL_BUILD_CMDS
- $(HOST_MAKE_ENV) $(MAKE) -C $(@D)
-endef
-
-define HOST_LIBXML_PARSER_PERL_INSTALL_CMDS
- $(HOST_MAKE_ENV) $(MAKE) -C $(@D) install
-endef
-
-$(eval $(generic-package))
-$(eval $(host-generic-package))
package/metacity/metacity.mk +1 -1
index 9306b00..18f5c76 100644
@@ -19,7 +19,7 @@ METACITY_CONF_OPT = --x-includes=$(STAGING_DIR)/usr/include/X11 \
 
 METACITY_DEPENDENCIES = libgtk2 \
 	xlib_libX11 \
-	host-libxml-parser-perl \
+	host-perl-xml-parser \
 	xlib_libXcomposite \
 	xlib_libXfixes \
 	xlib_libXrender \
package/perl-xml-parser/perl-xml-parser.mk new file +17 -0
new file mode 100644
index 0000000..fb9bf0f
@@ -0,0 +1,17 @@
+################################################################################
+#
+# perl-xml-parser
+#
+################################################################################
+
+PERL_XML_PARSER_VERSION = 2.41
+PERL_XML_PARSER_SOURCE = XML-Parser-$(PERL_XML_PARSER_VERSION).tar.gz
+PERL_XML_PARSER_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TODDR/
+PERL_XML_PARSER_DEPENDENCIES = expat
+PERL_XML_PARSER_LICENSE = Artistic or GPLv1+
+
+HOST_LIBXML_PARSER_PERL_CONF_OPT = \
+	EXPATLIBPATH=$(HOST_DIR)/usr/lib \
+	EXPATINCPATH=$(HOST_DIR)/usr/include
+
+$(eval $(host-perl-package))
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v8 4/6 host-perl-module-build: new package

In reply to Francois Perrad

the version coming with host-perl is too old

---
 package/perl-module-build/perl-module-build.mk |   12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 package/perl-module-build/perl-module-build.mk
package/perl-module-build/perl-module-build.mk new file +12 -0
new file mode 100644
index 0000000..a95278d
@@ -0,0 +1,12 @@
+################################################################################
+#
+# perl-module-build
+#
+################################################################################
+
+PERL_MODULE_BUILD_VERSION = 0.4204
+PERL_MODULE_BUILD_SOURCE = Module-Build-$(PERL_MODULE_BUILD_VERSION).tar.gz
+PERL_MODULE_BUILD_SITE = $(BR2_CPAN_MIRROR)/authors/id/L/LE/LEONT/
+PERL_MODULE_BUILD_LICENSE = Artistic or GPLv1+
+
+$(eval $(host-perl-package))
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH v8 4/6 host-perl-module-build: new package

Quoted 4 lines · Francois Perrad

the version coming with host-perl is too old

Quoted 24 lines
---
 package/perl-module-build/perl-module-build.mk |   12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 package/perl-module-build/perl-module-build.mk
package/perl-module-build/perl-module-build.mk new file +12 -0
new file mode 100644
index 0000000..a95278d
@@ -0,0 +1,12 @@
+################################################################################
+#
+# perl-module-build
+#
+################################################################################
+
+PERL_MODULE_BUILD_VERSION = 0.4204
+PERL_MODULE_BUILD_SOURCE = Module-Build-$(PERL_MODULE_BUILD_VERSION).tar.gz
+PERL_MODULE_BUILD_SITE = $(BR2_CPAN_MIRROR)/authors/id/L/LE/LEONT/
+PERL_MODULE_BUILD_LICENSE = Artistic or GPLv1+
+
+$(eval $(host-perl-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw

PATCH v8 5/6 manual: adding packages perl

In reply to Francois Perrad
---
 docs/manual/adding-packages-perl.txt |  110 ++++++++++++++++++++++++++++++++++
 docs/manual/adding-packages.txt      |    2 +
 2 files changed, 112 insertions(+)
 create mode 100644 docs/manual/adding-packages-perl.txt
docs/manual/adding-packages-perl.txt new file +110 -0
new file mode 100644
index 0000000..d33ab3f
@@ -0,0 +1,110 @@
+// -*- mode:doc; -*-
+// vim: set syntax=asciidoc:
+
+Infrastructure for Perl/CPAN packages
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+[[perl-package-tutorial]]
+
++perl-package+ tutorial
+^^^^^^^^^^^^^^^^^^^^^^^
+
+First, let's see how to write a +.mk+ file for a Perl/CPAN package,
+with an example :
+
+------------------------
+01: ################################################################################
+02: #
+03: # perl-foo-bar
+04: #
+05: ################################################################################
+06:
+07: PERL_FOO_BAR_VERSION = 0.02
+08: PERL_FOO_BAR_SOURCE = Foo-Bar-$(PERL_FOO_BAR_VERSION).tar.gz
+09: PERL_FOO_BAR_SITE = $(BR2_CPAN_MIRROR)/authors/id/M/MO/MONGER/
+10: PERL_FOO_BAR_DEPENDENCIES = perl-strictures
+11: PERL_FOO_BAR_LICENSE = Artistic or GPLv1+
+12: PERL_FOO_BAR_LICENSE_FILES = LICENSE
+13:
+14: $(eval $(perl-package))
+------------------------
+
+On line 7, we declare the version of the package.
+
+On line 8 and 9, we declare the name of the tarball and the location
+of the tarball on a CPAN server. Buildroot will automatically download
+the tarball from this location.
+
+On line 10, we declare our dependencies, so that they are built
+before the build process of our package starts.
+
+On line 11 and 12, we give licensing details about the package (its
+license on line 11, and the file containing the license text on line
+12).
+
+Finally, on line 14, we invoke the +perl-package+ macro that
+generates all the Makefile rules that actually allow the package to be
+built.
+
+Most of these data can be retrieved from https://metacpan.org/.
+So, this file and the Config.in can be generated by running
+the script +supports/scripts/scancpan Foo-Bar+ in the +TOPDIR+ directory
+(or in the +BR2_EXTERNAL+ directory).
+This script recursively creates packages for all required Perl/CPAN
+dependencies.
+
+[[perl-package-reference]]
+
++perl-package+ reference
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+As a policy, packages that provide Perl/CPAN modules should all be
+named +perl-<something>+ in Buildroot.
+
+This infrastructure handles various Perl build systems :
++ExtUtils-MakeMaker+, +Module-Build+ and +Module-Build-Tiny+.
++Build.PL+ is always preferred when a package provides a +Makefile.PL+
+and a +Build.PL+.
+
+The main macro of the Perl/CPAN package infrastructure is
++perl-package+. It is similar to the +generic-package+ macro. The ability to
+have target and host packages is also available, with the
++host-perl-package+ macro.
+
+Just like the generic infrastructure, the Perl/CPAN infrastructure
+works by defining a number of variables before calling the
++perl-package+ macro.
+
+First, all the package metadata information variables that exist in the
+generic infrastructure also exist in the Perl/CPAN infrastructure:
++PERL_FOO_VERSION+, +PERL_FOO_SOURCE+,
++PERL_FOO_PATCH+, +PERL_FOO_SITE+,
++PERL_FOO_SUBDIR+, +PERL_FOO_DEPENDENCIES+,
++PERL_FOO_INSTALL_TARGET+.
+
+Note that:
+
+ * Setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect (unless
+   a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined), since
+   Perl modules generally don't need to be installed to the
+   +staging+ directory.
+
+A few additional variables, specific to the Perl/CPAN infrastructure,
+can also be defined. Many of them are only useful in very specific
+cases, typical packages will therefore only use a few of them.
+
+* +PERL_FOO_CONF_OPT+, to specify additional configure
+  options to pass to the +perl Makefile.PL+ or +perl Build.PL+.
+  By default, empty.
+
+* +PERL_FOO_BUILD_OPT+, to specify additional options to
+  pass to +make pure_all+ or +perl Build build+ in the build step.
+  By default, empty.
+
+* +PERL_FOO_INSTALL_TARGET_OPT+, to specify additional options to
+  pass to +make pure_install+ or +perl Build install+ in the install step.
+  By default, empty.
+
+* +HOST_PERL_FOO_INSTALL_OPT+, to specify additional options to
+  pass to +make pure_install+ or +perl Build install+ in the install step.
+  By default, empty.
docs/manual/adding-packages.txt +2 -0
index cc86529..745e33a 100644
@@ -22,6 +22,8 @@ include::adding-packages-python.txt[]
 
 include::adding-packages-luarocks.txt[]
 
+include::adding-packages-perl.txt[]
+
 include::adding-packages-hooks.txt[]
 
 include::adding-packages-gettext.txt[]
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH v8 5/6 manual: adding packages perl

docs/manual/adding-packages-perl.txt line 91

Quoted 7 lines · Francois Perrad
docs/manual/adding-packages-perl.txt new file +7 -0
+Note that:
+
+ * Setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect (unless
+   a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined), since
+   Perl modules generally don't need to be installed to the
+   +staging+ directory.
+

With only one bullet point, the bullet list is pointless. Also I think
the formulation of the explanation is not very clear. I proposed this alternative in reply to v6:

Note that setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect unless a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined. The perl infrastructure doesn't define these commands since Perl modules generally don't need to be installed to the +staging+ directory.

Otherwise, looks good to me.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#8 lore raw

PATCH v8 5/6 manual: adding packages perl

Hi Francois,

Quoted 13 lines · Arnout Vandecappelle

docs/manual/adding-packages-perl.txt line 91

Quoted 7 lines · Francois Perrad
docs/manual/adding-packages-perl.txt new file +7 -0
+Note that:
+
+ * Setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect (unless
+   a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined), since
+   Perl modules generally don't need to be installed to the
+   +staging+ directory.
+

With only one bullet point, the bullet list is pointless. Also I think
the formulation of the explanation is not very clear. I proposed this alternative in reply to v6:

Quoted 4 lines

Note that setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect unless a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined. The perl infrastructure doesn't define these commands since Perl modules generally don't need to be installed to the +staging+ directory.

Did you miss this mail? I didn't see this changed in v9.

Maybe you just disagree with what I say here, but then please say so
explicitly.

Regards,
Arnout

Quoted 7 lines

Otherwise, looks good to me.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#9 lore raw

PATCH v8 5/6 manual: adding packages perl

2014-02-13 7:28 GMT+01:00 Arnout Vandecappelle <[email protected]>:

Quoted 16 lines

Hi Francois,

Quoted 13 lines · Arnout Vandecappelle

docs/manual/adding-packages-perl.txt line 91

Quoted 7 lines · Francois Perrad
docs/manual/adding-packages-perl.txt new file +7 -0
+Note that:
+
+ * Setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect (unless
+   a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined), since
+   Perl modules generally don't need to be installed to the
+   +staging+ directory.
+

With only one bullet point, the bullet list is pointless. Also I think
the formulation of the explanation is not very clear. I proposed this alternative in reply to v6:

Quoted 7 lines
Quoted 4 lines

Note that setting +PERL_FOO_INSTALL_STAGING+ to +YES+ has no effect unless a +PERL_FOO_INSTALL_STAGING_CMDS+ variable is defined. The perl infrastructure doesn't define these commands since Perl modules generally don't need to be installed to the +staging+ directory.

Did you miss this mail? I didn't see this changed in v9.

I see it but after sending V9. Applied in V10.

Fran?ois.

Quoted 26 lines

Maybe you just disagree with what I say here, but then please say so
explicitly.

Regards,
Arnout

Quoted 7 lines

Otherwise, looks good to me.

Regards,
Arnout

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#10 lore raw

PATCH v8 6/6 perl: remove PERL_INSTALL_TARGET_GOALS

In reply to Francois Perrad

useless since previous commit (removal of BR2_HAVE_DOCUMENTATION)
see http://git.buildroot.net/buildroot/diff/package/perl/perl.mk?id=7164a32632d14cb83698ddec45e84ad2f3252e9e

---
 package/perl/perl.mk |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/perl/perl.mk +1 -3
index 5ede81b..51aeb14 100644
@@ -90,10 +90,8 @@ define PERL_INSTALL_STAGING_CMDS
 	$(MAKE1) -C $(@D) DESTDIR="$(STAGING_DIR)" install.perl
 endef
 
-PERL_INSTALL_TARGET_GOALS = install.perl
-
 define PERL_INSTALL_TARGET_CMDS
-	$(MAKE1) -C $(@D) DESTDIR="$(TARGET_DIR)" $(PERL_INSTALL_TARGET_GOALS)
+	$(MAKE1) -C $(@D) DESTDIR="$(TARGET_DIR)" install.perl
 endef
 
 $(eval $(generic-package))
Signature · 1 line
1.7.9.5