Skip to contentSkip to conversation

drm/vmwgfx: unlock on error path in vmw_execbuf_process()

PATCH In review Dan Carpenter 2 participants 2 messages Feb 11, 2014 – Feb 12, 2014

Subsystems (4)
DRM drivers DRM misc Kernel janitors DRM driver for VMware virtual GPU
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/vmwgfx: unlock on error path in vmw_execbuf_process()

There is a missing unlock on error here.

Fixes 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +1 -1
index 269b85cc875a..9fbbaaa9e541 100644
@@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
 	if (dev_priv->has_mob) {
 		ret = vmw_rebind_contexts(sw_context);
 		if (unlikely(ret != 0))
-			goto out_err;
+			goto out_unlock_binding;
 	}
 
 	cmd = vmw_fifo_reserve(dev_priv, command_size);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Dan Carpenter

There is a missing unlock on error here.

Fixes 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +0 -0
index 269b85cc875a..9fbbaaa9e541 100644

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c int vmw_execbuf_process(struct drm_file *file_priv, · line 2475

Quoted 8 lines
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +1 -1
@@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
 	if (dev_priv->has_mob) {
 		ret = vmw_rebind_contexts(sw_context);
 		if (unlikely(ret != 0))
-			goto out_err;
+			goto out_unlock_binding;
 	}
 
 	cmd = vmw_fifo_reserve(dev_priv, command_size);

Dan, thanks,

Reviewed-by Thomas Hellstrom <[email protected]>

Queued for next vmwgfx-fixes pull.

/Thomas