Skip to contentSkip to conversation

drm/vmwgfx: add error checking for kmalloc()

PATCH In review Dan Carpenter 2 participants 2 messages Feb 11, 2014 – Feb 12, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/vmwgfx: add error checking for kmalloc()

Return -ENOMEM if kmalloc() fails.

Fixes d5bde956630b ('drm/vmwgfx: Emulate legacy shaders on guest-backed devices v2')
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c +2 -0
index 217d941b8176..23a32fd59a57 100644
@@ -779,6 +779,8 @@ vmw_compat_shader_man_create(struct vmw_private *dev_priv)
 	int ret;
 
 	man = kzalloc(sizeof(*man), GFP_KERNEL);
+	if (!man)
+		return ERR_PTR(-ENOMEM);
 
 	man->dev_priv = dev_priv;
 	INIT_LIST_HEAD(&man->list);
#1 lore raw
Quoted 10 lines · Dan Carpenter

Return -ENOMEM if kmalloc() fails.

Fixes d5bde956630b ('drm/vmwgfx: Emulate legacy shaders on guest-backed devices v2')
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c +0 -0
index 217d941b8176..23a32fd59a57 100644

drivers/gpu/drm/vmwgfx/vmwgfx_shader.c vmw_compat_shader_man_create(struct vmw_private *dev_priv) · line 786

Quoted 8 lines
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c +2 -0
@@ -779,6 +779,8 @@ vmw_compat_shader_man_create(struct vmw_private *dev_priv)
 	int ret;
 
 	man = kzalloc(sizeof(*man), GFP_KERNEL);
+	if (!man)
+		return ERR_PTR(-ENOMEM);
 
 	man->dev_priv = dev_priv;
 	INIT_LIST_HEAD(&man->list);

Thanks, Dan.
A patch fixing the same problem has already been queued for the next vmwgfx-fixes!

/Thomas