Skip to contentSkip to conversation

ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

PATCH New Bryan Wu 2 participants 10 messages Feb 7, 2014 – Feb 13, 2014

Subsystems (3)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

---
 arch/arm/configs/tegra_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/tegra_defconfig +1 -0
index 995d434..efcf15f 100644
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
 CONFIG_SERIAL_OF_PLATFORM=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_MUX_PINCTRL=y
 CONFIG_I2C_TEGRA=y
 CONFIG_SPI=y
Signature · 1 line
1.8.3.2
author
#1 lore raw

PATCH 2/2 ARM: tegra: enable PCA9546 on Cardhu

Cardhu has a PCA9546 for I2C bus extension, which connects to 3 cameras. It's required for Tegra V4L2 soc camera driver and camera sensor drivers.

---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/tegra30-cardhu.dtsi +7 -0
index 9104224..004002c 100644
@@ -187,6 +187,13 @@
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		i2cmux at 70 {
+			compatible = "nxp,pca9546";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x70>;
+		};
 	};
 
 	i2c at 7000c700 {
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

In reply to Bryan Wu
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and applied patch 2/2 to Tegra's for-3.15/dt branch.

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

author
#3 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 5 lines · Stephen Warren
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

Quoted 8 lines

I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and applied patch 2/2 to Tegra's for-3.15/dt branch.

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

My bad. I need to update my git send-email script to use --from "Bryan Wu <[email protected]>" instead of --from "Bryan Wu <[email protected]>"

Need I resubmit this patchset?

Thanks,
-Bryan

#4 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 15 lines · Bryan Wu
Quoted 5 lines · Stephen Warren
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

Quoted 8 lines

I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and applied patch 2/2 to Tegra's for-3.15/dt branch.

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

Quoted 5 lines

My bad. I need to update my git send-email script to use --from "Bryan Wu <[email protected]>" instead of --from "Bryan Wu <[email protected]>"

Need I resubmit this patchset?

No need to resent; I fixed them up.

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email addresses and/or mail servers, so you can't make ~/.gitconfig static and universally correct? If you have a recent enough git, what I do is:

$ cat ~/.gitconfig
[include]
        path = .gitconfig-user
        path = .gitconfig-email-server
...
$ cat ~/.gitconfig-user-nvidia
[user]
	name = Stephen Warren
	email = swarren at nvidia.com
$ cat ~/.gitconfig-user-wwwdotorg
[user]
	name = Stephen Warren
	email = swarren at wwwdotorg.org

~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have a script that deletes the link and points it at a new location:

$ cat `which git-switch-user`
#!/bin/bash

cd $HOME
mainfile=.gitconfig-user
newlink=${mainfile}-$1
if [ ! -f ${newlink} ]; then

    echo ERROR: ${newlink} not found
    exit 1

fi

rm -f ${mainfile}
ln -s ${newlink} ${mainfile}

... and the same thing for email servers.

Then, I can run e.g.:

git-switch-email-server nvidia; \
git send-email --to internal at nvidia.com *.patch; \
git-switch-email-server severn-port-forwarded

author
#5 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 63 lines · Stephen Warren
Quoted 15 lines · Bryan Wu
Quoted 5 lines · Stephen Warren
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

Quoted 8 lines

I've squashed patch 1/2 into Tegra's for-3.15/defconfig branch, and applied patch 2/2 to Tegra's for-3.15/dt branch.

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

Quoted 5 lines

My bad. I need to update my git send-email script to use --from "Bryan Wu <[email protected]>" instead of --from "Bryan Wu <[email protected]>"

Need I resubmit this patchset?

No need to resent; I fixed them up.

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email addresses and/or mail servers, so you can't make ~/.gitconfig static and universally correct? If you have a recent enough git, what I do is:

$ cat ~/.gitconfig
[include]
        path = .gitconfig-user
        path = .gitconfig-email-server
...
$ cat ~/.gitconfig-user-nvidia
[user]
        name = Stephen Warren
        email = swarren at nvidia.com
$ cat ~/.gitconfig-user-wwwdotorg
[user]
        name = Stephen Warren
        email = swarren at wwwdotorg.org

~/.gitconfig-user is a symlink to one of ~/.gitconfig-user-*, and I have a script that deletes the link and points it at a new location:

$ cat `which git-switch-user`
#!/bin/bash

cd $HOME
mainfile=.gitconfig-user
newlink=${mainfile}-$1
if [ ! -f ${newlink} ]; then

    echo ERROR: ${newlink} not found
    exit 1

fi

rm -f ${mainfile}
ln -s ${newlink} ${mainfile}

Quoted 7 lines

... and the same thing for email servers.

Then, I can run e.g.:

git-switch-email-server nvidia; \
git send-email --to internal at nvidia.com *.patch; \
git-switch-email-server severn-port-forwarded

Awesome, I will firstly update my .gitconfig. Actually I basically just have one outbound server which is gmail server. Although I put
From: @nvidia.com, I still use gmail server to send out patch emails. Still don't wanna touch our internal email server.

Thanks a lot and it's really helpful.
-Bryan

#6 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 7 lines · Bryan Wu
Quoted 6 lines · Stephen Warren
Quoted 5 lines · Bryan Wu
Quoted 4 lines · Stephen Warren
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

...

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

...

Quoted 5 lines
Quoted 5 lines

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email addresses and/or mail servers, so you can't make ~/.gitconfig static and universally correct? If you have a recent enough git, what I do is:

...

Quoted 4 lines

Awesome, I will firstly update my .gitconfig. Actually I basically just have one outbound server which is gmail server. Although I put
From: @nvidia.com, I still use gmail server to send out patch emails. Still don't wanna touch our internal email server.

You shouldn't send email with a from address @nvidia.com from a server other than NVIDIA's servers. If you do, plenty of people will drop the email as SPAM, since NVIDIA publishes SPF[1] records (and perhaps other email configuration) for nvidia.com. Since there are good reasons not to use NVIDIA's email servers, that means: tell git the actual email address you're sending from (for the email settings; you should set the author/commit ID to your @nvidia.com address still).

[1] http://www.openspf.org/

$ dig -t spf nvidia.com
...
nvidia.com.		180	IN	SPF	\
	"v=spf1 mx/24 mx:nvidia.com/24 -all"
author
#7 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 34 lines · Stephen Warren
Quoted 7 lines · Bryan Wu
Quoted 6 lines · Stephen Warren
Quoted 5 lines · Bryan Wu
Quoted 4 lines · Stephen Warren
Quoted 3 lines · Bryan Wu

PCA9546 is used in Cardhu Tegra30 board to connect to 3 cameras. Enabling this driver for Tegra V4L2 soc camera driver and camera sensor drivers.

...

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Note that your patches were sent with an email "From" address that didn't match your signed-off-by tag, yet "git send-email" didn't insert a "From" header in the email body. Can you please check your git user ID and/or email settings. Consequently, I had to adjust the git author field in git to match your s-o-b line.

...

Quoted 5 lines
Quoted 5 lines

Why not just put the correct values in ~/.gitconfig?

Perhaps this is because you switch between NVIDIA and non-NVIDIA email addresses and/or mail servers, so you can't make ~/.gitconfig static and universally correct? If you have a recent enough git, what I do is:

...

Quoted 4 lines

Awesome, I will firstly update my .gitconfig. Actually I basically just have one outbound server which is gmail server. Although I put
From: @nvidia.com, I still use gmail server to send out patch emails. Still don't wanna touch our internal email server.

You shouldn't send email with a from address @nvidia.com from a server other than NVIDIA's servers. If you do, plenty of people will drop the email as SPAM, since NVIDIA publishes SPF[1] records (and perhaps other email configuration) for nvidia.com. Since there are good reasons not to use NVIDIA's email servers, that means: tell git the actual email address you're sending from (for the email settings; you should set the author/commit ID to your @nvidia.com address still).

Quoted 7 lines

[1] http://www.openspf.org/

$ dig -t spf nvidia.com
...
nvidia.com.             180     IN      SPF     \
        "v=spf1 mx/24 mx:nvidia.com/24 -all"

Sure, I think I just missed to set the author as @nvidia.com but SOB is @nvidia.com in this patchset. And I still should use --from "Bryan Wu <[email protected]>" for sending out email from gmail server. Right?

Thanks,
-Bryan

#8 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

On 02/12/2014 04:23 PM, Bryan Wu wrote:
...

Quoted 4 lines

Sure, I think I just missed to set the author as @nvidia.com but SOB is @nvidia.com in this patchset. And I still should use --from "Bryan Wu <[email protected]>" for sending out email from gmail server. Right?

I think you want the following in ~/.gitconfig:

[user]
name = Bryan Wu
email = pengw at nvidia.com
[sendemail]
from = Bryan Wu <[email protected]>

I assume "--from xxx" is the same as setting the last variable I listed above.

author
#9 lore raw

PATCH 1/2 ARM: tegra: enable I2C Mux driver for PCA9546 in defconfig

Quoted 7 lines · Stephen Warren

On 02/12/2014 04:23 PM, Bryan Wu wrote:
...

Quoted 4 lines

Sure, I think I just missed to set the author as @nvidia.com but SOB is @nvidia.com in this patchset. And I still should use --from "Bryan Wu <[email protected]>" for sending out email from gmail server. Right?

Quoted 5 lines

I think you want the following in ~/.gitconfig:

[user]
name = Bryan Wu
email = pengw at nvidia.com

I have these settings in my company machine.

Quoted 5 lines

[sendemail]
from = Bryan Wu <[email protected]>

I assume "--from xxx" is the same as setting the last variable I listed above.

Yeah, I didn't put this in my .gitconfig but put them in my script with "git send-mail".

Thanks,
-Bryan