Skip to contentSkip to conversation

drm/ttm: Fix memory leak in ttm_agp_backend.c

PATCH In review Masanari Iida 2 participants 2 messages Feb 12, 2014 – Feb 13, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/ttm: Fix memory leak in ttm_agp_backend.c

This patch fix a memory leak found by cppcheck.
[drivers/gpu/drm/ttm/ttm_agp_backend.c:129]:
(error) Memory leak: agp_be

---
 drivers/gpu/drm/ttm/ttm_agp_backend.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_agp_backend.c +1 -0
index 3302f99..764be36 100644
@@ -126,6 +126,7 @@ struct ttm_tt *ttm_agp_tt_create(struct ttm_bo_device *bdev,
 	agp_be->ttm.func = &ttm_agp_func;
 
 	if (ttm_tt_init(&agp_be->ttm, bdev, size, page_flags, dummy_read_page)) {
+		kfree(agp_be);
 		return NULL;
 	}
 
Signature · 1 line
1.9.rc1
#1 lore raw
Quoted 14 lines · Masanari Iida

This patch fix a memory leak found by cppcheck.
[drivers/gpu/drm/ttm/ttm_agp_backend.c:129]:
(error) Memory leak: agp_be

---
 drivers/gpu/drm/ttm/ttm_agp_backend.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_agp_backend.c +0 -0
index 3302f99..764be36 100644

drivers/gpu/drm/ttm/ttm_agp_backend.c struct ttm_tt *ttm_agp_tt_create(struct ttm_bo_device *bdev, · line 132

Quoted 7 lines
drivers/gpu/drm/ttm/ttm_agp_backend.c +1 -0
@@ -126,6 +126,7 @@ struct ttm_tt *ttm_agp_tt_create(struct ttm_bo_device *bdev,
 	agp_be->ttm.func = &ttm_agp_func;
 
 	if (ttm_tt_init(&agp_be->ttm, bdev, size, page_flags, dummy_read_page)) {
+		kfree(agp_be);
 		return NULL;
 	}
 

Thanks, I'll include in the next ttm-fixes pull request.

/Thomas