ARM: dts: exynos5250-arndale: Keep G3D regulator always on
Subsystems (2)
PATCH 1/1 ARM: dts: exynos5250-arndale: Keep G3D regulator always on
Apparently, if G3D regulator is powered off, the SoC cannot enter low power modes and just hangs. This patch fixes this by keeping the regulator always on when the system is running, as suggested by Exynos 4 User's Manual in case of Exynos4210/4x12 SoCs (Exynos5250 UM does not have such note, but observed behavior seems to confirm that it is true for this SoC as well).
This fixes an issue preventing Arndale board from entering sleep mode observed since commit
346f372f7b72a0 clk: exynos5250: Add CLK_IGNORE_UNUSED flag for pmu clock
that landed in kernel 3.11, which has fixed the clock driver to make the SoC actually try to enter the sleep mode.
--- arch/arm/boot/dts/exynos5250-arndale.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/exynos5250-arndale.dts +1 -0
@@ -287,6 +287,7 @@ regulator-name = "vdd_g3d"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-always-on; regulator-boot-on; op_mode = <1>; };
Signature · 1 line
1.8.5.2
PATCH 1/1 ARM: dts: exynos5250-arndale: Keep G3D regulator always on
Quoted 10 lines · Tomasz Figa
Apparently, if G3D regulator is powered off, the SoC cannot enter low power modes and just hangs. This patch fixes this by keeping the regulator always on when the system is running, as suggested by Exynos 4 User's Manual in case of Exynos4210/4x12 SoCs (Exynos5250 UM does not have such note, but observed behavior seems to confirm that it is true for this SoC as well).
This fixes an issue preventing Arndale board from entering sleep mode observed since commit
Quoted 8 lines
346f372f7b72a0clk: exynos5250: AddCLK_IGNORE_UNUSEDflag for pmu clockthat landed in kernel 3.11, which has fixed the clock driver to make the SoC actually try to enter the sleep mode.
Signed-off-by Tomasz Figa <[email protected]>Acked-by Kyungmin Park <[email protected]>Cc stable at vger.kernel.org
Thanks for the patch.
Signature · 1 line
Tushar Behera
PATCH 1/1 ARM: dts: exynos5250-arndale: Keep G3D regulator always on
In reply to Tomasz FigaQuoted 27 lines · Tomasz Figa
Apparently, if G3D regulator is powered off, the SoC cannot enter low power modes and just hangs. This patch fixes this by keeping the regulator always on when the system is running, as suggested by Exynos 4 User's Manual in case of Exynos4210/4x12 SoCs (Exynos5250 UM does not have such note, but observed behavior seems to confirm that it is true for this SoC as well).
This fixes an issue preventing Arndale board from entering sleep mode observed since commit
346f372f7b72a0clk: exynos5250: AddCLK_IGNORE_UNUSEDflag for pmu clockthat landed in kernel 3.11, which has fixed the clock driver to make the SoC actually try to enter the sleep mode.
Signed-off-by Tomasz Figa<[email protected]>Acked-by Kyungmin Park<[email protected]>Cc stable at vger.kernel.org--- arch/arm/boot/dts/exynos5250-arndale.dts | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/exynos5250-arndale.dts +0
-0
arch/arm/boot/dts/exynos5250-arndale.dts line 293
Quoted 7 lines
arch/arm/boot/dts/exynos5250-arndale.dts +1
-0@@ -287,6 +287,7 @@ regulator-name = "vdd_g3d"; regulator-min-microvolt =<1000000>; regulator-max-microvolt =<1000000>; + regulator-always-on; regulator-boot-on; op_mode =<1>; };
Looks good to me, applied. BTW, the patch you mentioned has been merged since v3.10 so I fixed it.
Thanks,
Kukjin