hwmon: (ntc_thermistor): Avoid overflow
PATCH 1/1 hwmon: (ntc_thermistor): Avoid overflow
The ntc thermistor code was doing math whose temporary result might have overflowed 32-bits. We need some casts in there to make it safe.
In one example I found:
- pullup_uV: 1800000
- result of iio_read_channel_raw: 3226
- 1800000 * 3226 => 0x15a1cbc80
Signed-off-by Doug Anderson <[email protected]>
--- drivers/hwmon/ntc_thermistor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/ntc_thermistor.c +3 -3
@@ -145,7 +145,7 @@ struct ntc_data {static int ntc_adc_iio_read (struct ntc_thermistor_platform_data *pdata) {struct iio_channel *channel = pdata->chan; -unsigned int result; +s64 result;int val, ret; ret =iio_read_channel_raw (channel, &val);
@@ -155,10 +155,10 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata) }/* unit: mV */ - result = pdata->pullup_uv * val; + result = pdata->pullup_uv * (s64 ) val; result >>=12 ; -return result; +return (int )result; }static const struct of_device_id ntc_match[] = {
Signature · 7 lines
1.9.0.rc1.175.g0b1dcb5 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 9 lines · Doug Anderson
The ntc thermistor code was doing math whose temporary result might have overflowed 32-bits. We need some casts in there to make it safe.
In one example I found:
-pullup_uV: 1800000
- result ofiio_read_channel_raw: 3226
- 1800000 * 3226 =>0x15a1cbc80Signed-off-by Doug Anderson <[email protected]>
Nice catch. Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors