KVM: x86: Remove AMX-TF32 enumeration
Subsystems (4)
PATCH v2 1/1 KVM: x86: Remove AMX-TF32 enumeration
AMX-TF32 enumeration was added based on the Intel documentation [1]. The recent update removed the feature, indicating that the feature is no longer planned for hardware implementation.
[1] Intel Architecture Instruction Set Extensions and Future Features
Note: The feature first appeared in the September 2025 revision of the document and was removed in the June 2026 revision.
---
V1 -> V2: Collect tags (Zhao, Binbin), put note (Binbu), and cc @stable
--- arch/x86/kvm/cpuid.c | 1 - arch/x86/kvm/reverse_cpuid.h | 1 - 2 files changed, 2 deletions(-)
arch/x86/kvm/cpuid.c +0 -1
@@ -1082,7 +1082,6 @@ void kvm_initialize_cpu_caps(void)F (AMX_COMPLEX_ALIAS ),F (AMX_FP16_ALIAS ),F (AMX_FP8 ), -F (AMX_TF32 ),F (AMX_AVX512 ), F(AMX_MOVRS), );
arch/x86/kvm/reverse_cpuid.h +0 -1
@@ -56,7 +56,6 @@#define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2)#define X86_FEATURE_AMX_FP16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 3)#define X86_FEATURE_AMX_FP8 KVM_X86_FEATURE(CPUID_1E_1_EAX, 4) -#define X86_FEATURE_AMX_TF32 KVM_X86_FEATURE(CPUID_1E_1_EAX, 6)#define X86_FEATURE_AMX_AVX512 KVM_X86_FEATURE(CPUID_1E_1_EAX, 7)#define X86_FEATURE_AMX_MOVRS KVM_X86_FEATURE(CPUID_1E_1_EAX, 8)
Signature · 1 line
2.53.0
Quoted 8 lines · Chang S. Bae
AMX-TF32 enumeration was added based on the Intel documentation [1]. The recent update removed the feature, indicating that the feature is no longer planned for hardware implementation.
[1] Intel Architecture Instruction Set Extensions and Future Features
Note: The feature first appeared in the September 2025 revision of the document and was removed in the June 2026 revision.
The feature was first introduced in revision 054, October 2024.
It's recorded in the revision history.
Quoted 4 lines
Cc [email protected] # v6.20+Reviewed-by Zhao Liu <[email protected]>Reviewed-by Binbin Wu <[email protected]>Signed-off-by Chang S. Bae <[email protected]>
Quoted 31 lines
---
V1 -> V2: Collect tags (Zhao, Binbin), put note (Binbu), and cc @stable--- arch/x86/kvm/cpuid.c | 1 - arch/x86/kvm/reverse_cpuid.h | 1 - 2 files changed, 2 deletions(-)arch/x86/kvm/cpuid.c +0
-1@@ -1082,7 +1082,6 @@ void kvm_initialize_cpu_caps(void)F (AMX_COMPLEX_ALIAS ),F (AMX_FP16_ALIAS ),F (AMX_FP8 ), -F (AMX_TF32 ),F (AMX_AVX512 ), F(AMX_MOVRS), );arch/x86/kvm/reverse_cpuid.h +0
-1@@ -56,7 +56,6 @@#define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2)#define X86_FEATURE_AMX_FP16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 3)#define X86_FEATURE_AMX_FP8 KVM_X86_FEATURE(CPUID_1E_1_EAX, 4) -#define X86_FEATURE_AMX_TF32 KVM_X86_FEATURE(CPUID_1E_1_EAX, 6)#define X86_FEATURE_AMX_AVX512 KVM_X86_FEATURE(CPUID_1E_1_EAX, 7)#define X86_FEATURE_AMX_MOVRS KVM_X86_FEATURE(CPUID_1E_1_EAX, 8)
Sean Christopherson
maintainerQuoted 10 lines · Chang S. Bae
AMX-TF32 enumeration was added based on the Intel documentation [1]. The recent update removed the feature, indicating that the feature is no longer planned for hardware implementation.
[1] Intel Architecture Instruction Set Extensions and Future Features
Note: The feature first appeared in the September 2025 revision of the document and was removed in the June 2026 revision.
Cc [email protected] # v6.20+
6.20 isn't a thing. And given that this is clearly associated with a specific commit, just do:
and let script magic sort out the rest. No need for another version, if we agree that ripping out support is the way to go, I'll fixup when applying.
Quoted 27 lines
Reviewed-by Zhao Liu <[email protected]>Reviewed-by Binbin Wu <[email protected]>Signed-off-by Chang S. Bae <[email protected]>---
V1 -> V2: Collect tags (Zhao, Binbin), put note (Binbu), and cc @stable--- arch/x86/kvm/cpuid.c | 1 - arch/x86/kvm/reverse_cpuid.h | 1 - 2 files changed, 2 deletions(-)arch/x86/kvm/cpuid.c +0
-1@@ -1082,7 +1082,6 @@ void kvm_initialize_cpu_caps(void)F (AMX_COMPLEX_ALIAS ),F (AMX_FP16_ALIAS ),F (AMX_FP8 ), -F (AMX_TF32 ),F (AMX_AVX512 ), F(AMX_MOVRS), );arch/x86/kvm/reverse_cpuid.h +0
-0
arch/x86/kvm/reverse_cpuid.h line 59
Quoted 4 lines
arch/x86/kvm/reverse_cpuid.h +0
-1@@ -56,7 +56,6 @@#define X86_FEATURE_AMX_COMPLEX_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 2)#define X86_FEATURE_AMX_FP16_ALIAS KVM_X86_FEATURE(CPUID_1E_1_EAX, 3)#define X86_FEATURE_AMX_FP8 KVM_X86_FEATURE(CPUID_1E_1_EAX, 4) -#define X86_FEATURE_AMX_TF32 KVM_X86_FEATURE(CPUID_1E_1_EAX, 6)
I'm not convinced that yanking out support is the right move. By publishing the feature, for several years, Intel pretty much burned that CPUID bit. E.g. it's not impossible that someone other than Intel has implemented TF32 instructions.
The opcodes are fair game in the future, because their use can be qualified and guarded, but the same doesn't hold true for enumeration. E.g. similar to how MPX got ripped out and its XSTATE assets got reused for APX, but the CPUID feature enumeration is forever reserved for MPX (I hope).
If the argument is that "Intel Architecture Instruction Set Extensions and Future Features" isn't binding documentation, i.e. that Intel can do take backs until a feature is documented in the SDM, then I honestly don't see any option but to refuse to accept new features until they land in the SDM. Which I don't think any of us want.
Quoted 6 lines
arch/x86/kvm/reverse_cpuid.h +0
-0#define X86_FEATURE_AMX_AVX512 KVM_X86_FEATURE(CPUID_1E_1_EAX, 7)#define X86_FEATURE_AMX_MOVRS KVM_X86_FEATURE(CPUID_1E_1_EAX, 8)Signature · 1 line
2.53.0
Quoted 10 lines · Sean Christopherson
I'm not convinced that yanking out support is the right move. By publishing the feature, for several years, Intel pretty much burned that CPUID bit. E.g. it's not impossible that someone other than Intel has implemented TF32 instructions.
The opcodes are fair game in the future, because their use can be qualified and guarded, but the same doesn't hold true for enumeration. E.g. similar to how MPX got ripped out and its XSTATE assets got reused for APX, but the CPUID feature enumeration is forever reserved for MPX (I hope).
Quoted 5 lines
If the argument is that "Intel Architecture Instruction Set Extensions and Future Features" isn't binding documentation, i.e. that Intel can do take backs until a feature is documented in the SDM, then I honestly don't see any option but to refuse to accept new features until they land in the SDM. Which I don't think any of us want.
One distinction I could think of is whether a feature ever ships in implementations. If a feature is actually implemented and is later deprecated or removed, then I agree the bit should remain reserved. That appears quite clear.
My understanding is that the revert was considered because TF32 never reached any implementation. If that's incorrect, I'd certainly welcome a correction. But if it holds true, then I also want to clarify the case is different from retiring a feature that was already in products.
That said though, I think you made a point. If new features are published there, we add support based on that, and are later asked to remove the support, it becomes harder to convince what level of stability the ISE doc can provide.
I don't think these decisions are made lightly. We humans may sometimes reconsider features before they ever ship. But cases like this inevitably damage the credibility. If this happens repeatedly, it becomes increasingly reasonable to take a more conservative approach -- perhaps even until there is hardware implementation at hand.
I'd relay this feedback to the relevant folks, as I do think this is an important point to consider. I'll cc you.
Thanks,
Chang
Sean Christopherson
maintainerQuoted 16 lines · Chang S. Bae
Quoted 10 lines · Sean Christopherson
I'm not convinced that yanking out support is the right move. By publishing the feature, for several years, Intel pretty much burned that CPUID bit. E.g. it's not impossible that someone other than Intel has implemented TF32 instructions.
The opcodes are fair game in the future, because their use can be qualified and guarded, but the same doesn't hold true for enumeration. E.g. similar to how MPX got ripped out and its XSTATE assets got reused for APX, but the CPUID feature enumeration is forever reserved for MPX (I hope).
Quoted 5 lines
If the argument is that "Intel Architecture Instruction Set Extensions and Future Features" isn't binding documentation, i.e. that Intel can do take backs until a feature is documented in the SDM, then I honestly don't see any option but to refuse to accept new features until they land in the SDM. Which I don't think any of us want.
Quoted 4 lines
One distinction I could think of is whether a feature ever ships in implementations. If a feature is actually implemented and is later deprecated or removed, then I agree the bit should remain reserved. That appears quite clear.
Per Christian, who's mail client apparently doesn't use In-Reply-To and breaks threading for me and lore, TF32 made it into a shipped product[*].
So "officially", NAK.
[*] https://lore.kernel.org/all/CAKSQd8V%3DwfVrUxeU%2BfDRgKJBLdiyCkkY2SRY%[email protected]