Skip to contentSkip to conversation

selftests/kvm: add get_msr_index_features

PATCH In review Emanuele Giuseppe Esposito 4 participants 8 messages Mar 18, 2021 – Mar 19, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/kvm: add get_msr_index_features

Test the KVM_GET_MSR_FEATURE_INDEX_LIST
and KVM_GET_MSR_INDEX_LIST ioctls.

---
 tools/testing/selftests/kvm/.gitignore        |   1 +
 tools/testing/selftests/kvm/Makefile          |   1 +
 .../kvm/x86_64/get_msr_index_features.c       | 124 ++++++++++++++++++
 3 files changed, 126 insertions(+)
 create mode 100644 tools/testing/selftests/kvm/x86_64/get_msr_index_features.c
tools/testing/selftests/kvm/.gitignore +1 -0
index 32b87cc77c8e..d99f3969d371 100644
@@ -5,6 +5,7 @@
 /s390x/resets
 /s390x/sync_regs_test
 /x86_64/cr4_cpuid_sync_test
+/x86_64/get_msr_index_features
 /x86_64/debug_regs
 /x86_64/evmcs_test
 /x86_64/get_cpuid_test
tools/testing/selftests/kvm/Makefile +1 -0
index a6d61f451f88..c748b9650e28 100644
@@ -39,6 +39,7 @@ LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c
 LIBKVM_s390x = lib/s390x/processor.c lib/s390x/ucall.c lib/s390x/diag318_test_handler.c
 
 TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features
 TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test
 TEST_GEN_PROGS_x86_64 += x86_64/get_cpuid_test
 TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +124 -0

124 lines not on this page · raw message

Signature · 1 line
2.29.2
maintainer
#1 lore raw
Quoted 4 lines · Emanuele Giuseppe Esposito

Test the KVM_GET_MSR_FEATURE_INDEX_LIST
and KVM_GET_MSR_INDEX_LIST ioctls.

Looks good, thanks.

I queued it with a little extra code to verify KVM_GET_MSR_INDEX_LIST in the case that does not return E2BIG.

Paolo

Quoted 162 lines
---
  tools/testing/selftests/kvm/.gitignore        |   1 +
  tools/testing/selftests/kvm/Makefile          |   1 +
  .../kvm/x86_64/get_msr_index_features.c       | 124 ++++++++++++++++++
  3 files changed, 126 insertions(+)

create mode 100644 tools/testing/selftests/kvm/x86_64/get_msr_index_features.c

tools/testing/selftests/kvm/.gitignore +1 -0
index 32b87cc77c8e..d99f3969d371 100644
@@ -5,6 +5,7 @@
  /s390x/resets
  /s390x/sync_regs_test
  /x86_64/cr4_cpuid_sync_test
+/x86_64/get_msr_index_features
  /x86_64/debug_regs
  /x86_64/evmcs_test
  /x86_64/get_cpuid_test
tools/testing/selftests/kvm/Makefile +1 -0
index a6d61f451f88..c748b9650e28 100644
@@ -39,6 +39,7 @@ LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c
  LIBKVM_s390x = lib/s390x/processor.c lib/s390x/ucall.c lib/s390x/diag318_test_handler.c
 
  TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features
  TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test
  TEST_GEN_PROGS_x86_64 += x86_64/get_cpuid_test
  TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +124 -0
new file mode 100644
index 000000000000..ad9972d99dfa
@@ -0,0 +1,124 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Test that KVM_GET_MSR_INDEX_LIST and
+ * KVM_GET_MSR_FEATURE_INDEX_LIST work as intended
+ *
+ * Copyright (C) 2020, Red Hat, Inc.
+ */
+#include <fcntl.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/ioctl.h>
+
+#include "test_util.h"
+#include "kvm_util.h"
+#include "processor.h"
+#include "../lib/kvm_util_internal.h"
+
+static int kvm_num_index_msrs(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_INDEX_LIST, list);
+	TEST_ASSERT(r == -1 && errno == E2BIG,
+				"Unexpected result from KVM_GET_MSR_INDEX_LIST probe, r: %i",
+				r);
+
+	r = list->nmsrs;
+	free(list);
+	return r;
+}
+
+static void test_get_msr_index(void)
+{
+	int old_res, res, kvm_fd;
+
+	kvm_fd = open(KVM_DEV_PATH, O_RDONLY);
+	if (kvm_fd < 0)
+		exit(KSFT_SKIP);
+
+	old_res = kvm_num_index_msrs(kvm_fd, 0);
+	TEST_ASSERT(old_res != 0, "Expecting nmsrs to be > 0");
+
+	if (old_res != 1) {
+		res = kvm_num_index_msrs(kvm_fd, 1);
+		TEST_ASSERT(res > 1, "Expecting nmsrs to be > 1");
+		TEST_ASSERT(res == old_res, "Expecting nmsrs to be identical");
+	}
+
+	close(kvm_fd);
+}
+
+static int kvm_num_feature_msrs(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_FEATURE_INDEX_LIST, list);
+	TEST_ASSERT(r == -1 && errno == E2BIG,
+		"Unexpected result from KVM_GET_MSR_FEATURE_INDEX_LIST probe, r: %i",
+				r);
+
+	r = list->nmsrs;
+	free(list);
+	return r;
+}
+
+struct kvm_msr_list *kvm_get_msr_feature_list(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_FEATURE_INDEX_LIST, list);
+
+	TEST_ASSERT(r == 0,
+		"Unexpected result from KVM_GET_MSR_FEATURE_INDEX_LIST, r: %i",
+		r);
+
+	return list;
+}
+
+static void test_get_msr_feature(void)
+{
+	int res, old_res, i, kvm_fd;
+	struct kvm_msr_list *feature_list;
+
+	kvm_fd = open(KVM_DEV_PATH, O_RDONLY);
+	if (kvm_fd < 0)
+		exit(KSFT_SKIP);
+
+	old_res = kvm_num_feature_msrs(kvm_fd, 0);
+	TEST_ASSERT(old_res != 0, "Expecting nmsrs to be > 0");
+
+	if (old_res != 1) {
+		res = kvm_num_feature_msrs(kvm_fd, 1);
+		TEST_ASSERT(res > 1, "Expecting nmsrs to be > 1");
+		TEST_ASSERT(res == old_res, "Expecting nmsrs to be identical");
+	}
+
+	feature_list = kvm_get_msr_feature_list(kvm_fd, old_res);
+	TEST_ASSERT(old_res == feature_list->nmsrs,
+				"Unmatching number of msr indexes");
+
+	for (i = 0; i < feature_list->nmsrs; i++)
+		kvm_get_feature_msr(feature_list->indices[i]);
+
+	free(feature_list);
+	close(kvm_fd);
+}
+
+int main(int argc, char *argv[])
+{
+	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
+		test_get_msr_feature();
+
+	test_get_msr_index();
+}
#2 lore raw
In reply to Emanuele Giuseppe Esposito
Quoted 28 lines · Emanuele Giuseppe Esposito

Test the KVM_GET_MSR_FEATURE_INDEX_LIST
and KVM_GET_MSR_INDEX_LIST ioctls.

---
 tools/testing/selftests/kvm/.gitignore        |   1 +
 tools/testing/selftests/kvm/Makefile          |   1 +
 .../kvm/x86_64/get_msr_index_features.c       | 124 ++++++++++++++++++
 3 files changed, 126 insertions(+)
 create mode 100644 tools/testing/selftests/kvm/x86_64/get_msr_index_features.c
tools/testing/selftests/kvm/.gitignore +1 -0
index 32b87cc77c8e..d99f3969d371 100644
@@ -5,6 +5,7 @@
 /s390x/resets
 /s390x/sync_regs_test
 /x86_64/cr4_cpuid_sync_test
+/x86_64/get_msr_index_features
 /x86_64/debug_regs
 /x86_64/evmcs_test
 /x86_64/get_cpuid_test
tools/testing/selftests/kvm/Makefile +0 -0
index a6d61f451f88..c748b9650e28 100644

tools/testing/selftests/kvm/Makefile LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c · line 42

Quoted 4 lines
tools/testing/selftests/kvm/Makefile +1 -0
@@ -39,6 +39,7 @@ LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c
 LIBKVM_s390x = lib/s390x/processor.c lib/s390x/ucall.c lib/s390x/diag318_test_handler.c
 
 TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features

Maybe we should give up trying to keep an alphabetic order.

Quoted 16 lines
tools/testing/selftests/kvm/Makefile +0 -0
 TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test
 TEST_GEN_PROGS_x86_64 += x86_64/get_cpuid_test
 TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +7 -0
new file mode 100644
index 000000000000..ad9972d99dfa
@@ -0,0 +1,124 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Test that KVM_GET_MSR_INDEX_LIST and
+ * KVM_GET_MSR_FEATURE_INDEX_LIST work as intended
+ *
+ * Copyright (C) 2020, Red Hat, Inc.
+ */

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 17

Quoted 10 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +10 -0
+#include <fcntl.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/ioctl.h>
+
+#include "test_util.h"
+#include "kvm_util.h"
+#include "processor.h"
+#include "../lib/kvm_util_internal.h"

I'm not sure why the original kvm selftests authors decided to do this internal stuff, but we should either kill that or avoid doing stuff like this.

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 29

Quoted 12 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +12 -0
+
+static int kvm_num_index_msrs(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_INDEX_LIST, list);
+	TEST_ASSERT(r == -1 && errno == E2BIG,
+				"Unexpected result from KVM_GET_MSR_INDEX_LIST probe, r: %i",
+				r);

Weird indentation

Quoted 27 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +27 -0
+
+	r = list->nmsrs;
+	free(list);
+	return r;
+}
+
+static void test_get_msr_index(void)
+{
+	int old_res, res, kvm_fd;
+
+	kvm_fd = open(KVM_DEV_PATH, O_RDONLY);
+	if (kvm_fd < 0)
+		exit(KSFT_SKIP);
+
+	old_res = kvm_num_index_msrs(kvm_fd, 0);
+	TEST_ASSERT(old_res != 0, "Expecting nmsrs to be > 0");
+
+	if (old_res != 1) {
+		res = kvm_num_index_msrs(kvm_fd, 1);
+		TEST_ASSERT(res > 1, "Expecting nmsrs to be > 1");
+		TEST_ASSERT(res == old_res, "Expecting nmsrs to be identical");
+	}
+
+	close(kvm_fd);
+}
+
+static int kvm_num_feature_msrs(int kvm_fd, int nmsrs)

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 66

Quoted 10 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +10 -0
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_FEATURE_INDEX_LIST, list);
+	TEST_ASSERT(r == -1 && errno == E2BIG,
+		"Unexpected result from KVM_GET_MSR_FEATURE_INDEX_LIST probe, r: %i",
+				r);

Weird indentation. I'd just leave it up on the last line. We don't care about long lines.

Quoted 33 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +33 -0
+
+	r = list->nmsrs;
+	free(list);
+	return r;
+}
+
+struct kvm_msr_list *kvm_get_msr_feature_list(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_FEATURE_INDEX_LIST, list);
+
+	TEST_ASSERT(r == 0,
+		"Unexpected result from KVM_GET_MSR_FEATURE_INDEX_LIST, r: %i",
+		r);
+
+	return list;
+}
+
+static void test_get_msr_feature(void)
+{
+	int res, old_res, i, kvm_fd;
+	struct kvm_msr_list *feature_list;
+
+	kvm_fd = open(KVM_DEV_PATH, O_RDONLY);
+	if (kvm_fd < 0)
+		exit(KSFT_SKIP);
+
+	old_res = kvm_num_feature_msrs(kvm_fd, 0);
+	TEST_ASSERT(old_res != 0, "Expecting nmsrs to be > 0");

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 109

Quoted 10 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +10 -0
+
+	if (old_res != 1) {
+		res = kvm_num_feature_msrs(kvm_fd, 1);
+		TEST_ASSERT(res > 1, "Expecting nmsrs to be > 1");
+		TEST_ASSERT(res == old_res, "Expecting nmsrs to be identical");
+	}
+
+	feature_list = kvm_get_msr_feature_list(kvm_fd, old_res);
+	TEST_ASSERT(old_res == feature_list->nmsrs,
+				"Unmatching number of msr indexes");

Weird indentation

Quoted 4 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +4 -0
+
+	for (i = 0; i < feature_list->nmsrs; i++)
+		kvm_get_feature_msr(feature_list->indices[i]);
+

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 123

Quoted 10 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +10 -0
+	free(feature_list);
+	close(kvm_fd);
+}
+
+int main(int argc, char *argv[])
+{
+	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
+		test_get_msr_feature();
+
+	test_get_msr_index();

Missing return

Quoted 4 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +1 -0
+}
Signature · 1 line
2.29.2

Thanks,
drew

maintainer
#3 lore raw
Quoted 5 lines · Andrew Jones
Quoted 3 lines

TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features

Maybe we should give up trying to keep an alphabetic order.

FWIW I had fixed that but yeah maybe we should just give up.

Quoted 9 lines

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 123

Quoted 6 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +6 -0
+int main(int argc, char *argv[])
+{
+	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
+		test_get_msr_feature();
+
+	test_get_msr_index();

Missing return

Quoted 1 line

+}

"main" is special, it's okay not to have a return there.

Paolo

#4 lore raw
Quoted 17 lines · Paolo Bonzini
Quoted 5 lines · Andrew Jones
Quoted 3 lines

TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features

Maybe we should give up trying to keep an alphabetic order.

FWIW I had fixed that but yeah maybe we should just give up.

Quoted 8 lines

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 123

Quoted 6 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +6 -0
+int main(int argc, char *argv[])
+{
+	if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
+		test_get_msr_feature();
+
+	test_get_msr_index();

Missing return

Quoted 3 lines
Quoted 1 line
Quoted 1 line

+}

"main" is special, it's okay not to have a return there.

Hmm, yeah. I always assumed the compiler would complain or that you'd end up with a garbage return code. But, I just checked, and indeed not only do you not get a warning, even with -Wall -Wextra, but the compiler actually emits code for a zero return value on your behalf. Looks weird to me though to end an int function without a return, so I don't think I'm going to adopt this practice myself.

Thanks,
drew

#5 lore raw
In reply to Paolo Bonzini
Quoted 8 lines · Paolo Bonzini
Quoted 5 lines · Andrew Jones
Quoted 3 lines

TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features

Maybe we should give up trying to keep an alphabetic order.

FWIW I had fixed that but yeah maybe we should just give up.

Never! What if we make offenders wear a dunce cap at the next KVM Forum?

#6 lore raw
In reply to Andrew Jones

Hi Andrew,

Thank you for the feedback (also in v1).

Quoted 31 lines · Andrew Jones
Quoted 30 lines · Emanuele Giuseppe Esposito

Test the KVM_GET_MSR_FEATURE_INDEX_LIST
and KVM_GET_MSR_INDEX_LIST ioctls.

---
  tools/testing/selftests/kvm/.gitignore        |   1 +
  tools/testing/selftests/kvm/Makefile          |   1 +
  .../kvm/x86_64/get_msr_index_features.c       | 124 ++++++++++++++++++
  3 files changed, 126 insertions(+)

create mode 100644 tools/testing/selftests/kvm/x86_64/get_msr_index_features.c

tools/testing/selftests/kvm/.gitignore +1 -0
index 32b87cc77c8e..d99f3969d371 100644
@@ -5,6 +5,7 @@
  /s390x/resets
  /s390x/sync_regs_test
  /x86_64/cr4_cpuid_sync_test
+/x86_64/get_msr_index_features
  /x86_64/debug_regs
  /x86_64/evmcs_test
  /x86_64/get_cpuid_test
tools/testing/selftests/kvm/Makefile +0 -0
index a6d61f451f88..c748b9650e28 100644
@@ -39,6 +39,7 @@ LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c
  LIBKVM_s390x = lib/s390x/processor.c lib/s390x/ucall.c lib/s390x/diag318_test_handler.c
 
Quoted 4 lines

tools/testing/selftests/kvm/Makefile LIBKVM_aarch64 = lib/aarch64/processor.c lib/aarch64/ucall.c · line 42

Quoted 2 lines
tools/testing/selftests/kvm/Makefile +1 -0
  TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
+TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features

Maybe we should give up trying to keep an alphabetic order.

My bad, I did not notice that it was in alphabetic order.

Quoted 23 lines
Quoted 23 lines
tools/testing/selftests/kvm/Makefile +0 -0
  TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test
  TEST_GEN_PROGS_x86_64 += x86_64/get_cpuid_test
  TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +13 -0
new file mode 100644
index 000000000000..ad9972d99dfa
@@ -0,0 +1,124 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Test that KVM_GET_MSR_INDEX_LIST and
+ * KVM_GET_MSR_FEATURE_INDEX_LIST work as intended
+ *
+ * Copyright (C) 2020, Red Hat, Inc.
+ */
+#include <fcntl.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/ioctl.h>
+
Quoted 8 lines

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 17

Quoted 4 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +4 -0
+#include "test_util.h"
+#include "kvm_util.h"
+#include "processor.h"
+#include "../lib/kvm_util_internal.h"

I'm not sure why the original kvm selftests authors decided to do this internal stuff, but we should either kill that or avoid doing stuff like this.

I need this include because of the KVM_DEV_PATH macro, to get the kvm_fd. No other reason for including it in this test.

Quoted 7 lines
Quoted 7 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +7 -0
+
+static int kvm_num_feature_msrs(int kvm_fd, int nmsrs)
+{
+	struct kvm_msr_list *list;
+	int r;
+
+	list = malloc(sizeof(*list) + nmsrs * sizeof(list->indices[0]));
Quoted 8 lines

tools/testing/selftests/kvm/x86_64/get_msr_index_features.c line 66

Quoted 5 lines
tools/testing/selftests/kvm/x86_64/get_msr_index_features.c new file +5 -0
+	list->nmsrs = nmsrs;
+	r = ioctl(kvm_fd, KVM_GET_MSR_FEATURE_INDEX_LIST, list);
+	TEST_ASSERT(r == -1 && errno == E2BIG,
+		"Unexpected result from KVM_GET_MSR_FEATURE_INDEX_LIST probe, r: %i",
+				r);

Weird indentation. I'd just leave it up on the last line. We don't care about long lines.

Ok. I wanted avoid warnings from the checkpatch script.

Paolo, do you want me to send v2 with fixed indentation or you already took care of it? I'll be happy to do so.

Emanuele

maintainer
#7 lore raw
Quoted 7 lines · Emanuele Giuseppe Esposito
Quoted 4 lines

I'm not sure why the original kvm selftests authors decided to do this internal stuff, but we should either kill that or avoid doing stuff like this.

I need this include because of the KVM_DEV_PATH macro, to get the kvm_fd. No other reason for including it in this test.

I'll take care of moving that macro to the non-internal kvm_util.h header, thanks.

No need to do anything, I'll send the pull request later today.

Paolo