blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE()
Subsystems (2)
Jens Axboe
maintainerPATCH 1/1 blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE()
A previous commit got rid of unnecessary rcu_read_lock() inside the IRQ disabling queue_lock, but this debug statement was left. It's now firing since we are indeed not inside a RCU read lock, but we don't need to be as we're still preempt safe.
Get rid of the check, as we have a lockdep assert for holding the queue lock right after it anyway.
Reported-by Marek Szyprowski <[email protected]>
Fixes 77c570a1ea85 ("blk-cgroup: Remove unnecessary rcu_read_lock/unlock()")
Signed-off-by Jens Axboe <[email protected]>
---
block/blk-cgroup.c +0 -1
@@ -298,7 +298,6 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg,struct blkcg_gq *blkg;int i, ret; -WARN_ON_ONCE (!rcu_read_lock_held ());lockdep_assert_held (&q->queue_lock);/* request_queue is dying, do not create/recreate a blkg */
Signature · 1 line
Jens Axboe