ext4: don't leave i_crtime.tv_sec uninitialized
Theodore Ts'o
maintainerPATCH 1/1 ext4: don't leave i_crtime.tv_sec uninitialized
If the i_crtime field is not present in the inode, don't leave the field uninitialized.
Reported-by Vegard Nossum <[email protected]>
Signed-off-by "Theodore Ts'o" <[email protected]>
--- fs/ext4/ext4.h | 2 ++ 1 file changed, 2 insertions(+)
fs/ext4/ext4.h +2 -0
@@ -771,6 +771,8 @@ do { \if (EXT4_FITS_IN_INODE (raw_inode, einode, xtime)) \ (einode)->xtime.tv_sec = \ (signed )le32_to_cpu ((raw_inode)->xtime); \ +else \ + (einode)->xtime.tv_sec =0 ; \ if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime ## _extra)) \ext4_decode_extra_time (&(einode)->xtime, \ raw_inode->xtime ## _extra); \
Signature · 1 line
1.9.0
Quoted 15 lines · Theodore Ts'o
If the
i_crtimefield is not present in the inode, don't leave the field uninitialized.Reported-by Vegard Nossum <[email protected]>Signed-off-by "Theodore Ts'o" <[email protected]>--- fs/ext4/ext4.h | 2 ++ 1 file changed, 2 insertions(+)fs/ext4/ext4.h +0
-0
fs/ext4/ext4.h do { \ · line 778
Quoted 8 lines
fs/ext4/ext4.h +2
-0@@ -771,6 +771,8 @@ do { \if (EXT4_FITS_IN_INODE (raw_inode, einode, xtime)) \ (einode)->xtime.tv_sec = \ (signed )le32_to_cpu ((raw_inode)->xtime); \ +else \ + (einode)->xtime.tv_sec =0 ; \ if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime ## _extra)) \ext4_decode_extra_time (&(einode)->xtime, \ raw_inode->xtime ## _extra); \
This fixes everything for me, thanks!
Vegard