arm: omap3: cm-t35: remove MACH_CM_T3730
Subsystems (3)
PATCH 1/1 arm: omap3: cm-t35: remove MACH_CM_T3730
The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been used. Setting it has no effect. There are no calls for machine_is_cm_t3730(). This symbol can safely be removed.
---
Tested only with "git grep".
arch/arm/mach-omap2/Kconfig | 4 ---- 1 file changed, 4 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -4
@@ -292,7 +292,6 @@ config MACH_CM_T35 bool "CompuLab CM-T35/CM-T3730 modules" depends on ARCH_OMAP3 default y - select MACH_CM_T3730 select OMAP_PACKAGE_CUS config MACH_CM_T3517
@@ -301,9 +300,6 @@ config MACH_CM_T3517 default y select OMAP_PACKAGE_CBB -config MACH_CM_T3730 - bool - config MACH_SBC3530 bool "OMAP3 SBC STALKER board" depends on ARCH_OMAP3
Signature · 1 line
1.8.5.3
Hi Paul,
Quoted 3 lines · Paul Bolle
The
KconfigsymbolMACH_CM_T3730was added in v3.1. It has never been used. Setting it has no effect. There are no calls formachine_is_cm_t3730(). This symbol can safely be removed.
Indeed...
Is it such a burden to keep it just until we switch OMAP3 to DT? Because, it makes a bit harder to hack on the kernel. Well, not too much as it can be reverted, but still one needs to remember to do this...
I'd like to keep it just until we remove the board files, please.
Quoted 31 lines
Signed-off-by Paul Bolle <[email protected]>---
Tested only with "git grep".arch/arm/mach-omap2/Kconfig | 4 ---- 1 file changed, 4 deletions(-)arch/arm/mach-omap2/Kconfig +0
-4@@ -292,7 +292,6 @@ config MACH_CM_T35 bool "CompuLab CM-T35/CM-T3730 modules" depends on ARCH_OMAP3 default y - select MACH_CM_T3730 select OMAP_PACKAGE_CUS config MACH_CM_T3517@@ -301,9 +300,6 @@ config MACH_CM_T3517 default y select OMAP_PACKAGE_CBB -config MACH_CM_T3730 - bool - config MACH_SBC3530 bool "OMAP3 SBC STALKER board" depends on ARCH_OMAP3
Signature · 2 lines
Regards, Igor.
Hi Igor,
Quoted 6 lines · Igor Grinberg
Quoted 3 lines · Paul Bolle
The
KconfigsymbolMACH_CM_T3730was added in v3.1. It has never been used. Setting it has no effect. There are no calls formachine_is_cm_t3730(). This symbol can safely be removed.Indeed...
Please note that I now doubt my reasoning was correct here. I'm going to revisit my recent batch of patches regarding, in short, arm Kconfig symbols used in mach-types.h. (lkml.org is sort of down, so I can't provide a link.)
Quoted 4 lines
Is it such a burden to keep it just until we switch OMAP3 to DT? Because, it makes a bit harder to hack on the kernel. Well, not too much as it can be reverted, but still one needs to remember to do this...
No, not really. The worst that could happen, from your perspective, is that if it turns out this was the right thing to do, I might send a reminder in a few months.
Quoted 1 line
I'd like to keep it just until we remove the board files, please.
Thanks,
Paul Bolle