Skip to contentSkip to conversation

uboot: build custom target if custom target selected

PATCH New Laurent Cans 3 participants 3 messages Feb 17, 2014 – Apr 20, 2014

lore
Share & tools
lore

Laurent Cans

author
#0 lore raw

PATCH 1/1 uboot: build custom target if custom target selected

When selecting custom uboot target the installation fail due to incorrect target built. So when configuring custom uboot target, build the target configured in buildroot configuration instead of legacy one.

Signed-off-by Laurent Cans <[email protected]>
---
 boot/uboot/uboot.mk |    1 +
 1 file changed, 1 insertion(+)
boot/uboot/uboot.mk +1 -0
index 2174584..3e16b7a 100644
@@ -51,6 +51,7 @@ UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 UBOOT_DEPENDENCIES += host-elftosb
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
 UBOOT_BIN          = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
+UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 else
 UBOOT_BIN          = u-boot.bin
 UBOOT_BIN_IFT      = $(UBOOT_BIN).ift
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 uboot: build custom target if custom target selected

Quoted 3 lines · Laurent Cans

When selecting custom uboot target the installation fail due to incorrect target built. So when configuring custom uboot target, build the target configured in buildroot configuration instead of legacy one.

The problem is that this doesn't always work - sometimes the file you
want to use as the image is built as a side-effect of the default target
- this is e.g. the case for the SPL.

So perhaps the solution is to add another config option to set the make
target.

Regards,
Arnout

Quoted 19 lines
Signed-off-by Laurent Cans <[email protected]>
---
 boot/uboot/uboot.mk |    1 +
 1 file changed, 1 insertion(+)
boot/uboot/uboot.mk +1 -0
index 2174584..3e16b7a 100644
@@ -51,6 +51,7 @@ UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 UBOOT_DEPENDENCIES += host-elftosb
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
 UBOOT_BIN          = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
+UBOOT_MAKE_TARGET  = $(UBOOT_BIN)
 else
 UBOOT_BIN          = u-boot.bin
 UBOOT_BIN_IFT      = $(UBOOT_BIN).ift
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 uboot: build custom target if custom target selected

In reply to Laurent Cans

Dear Laurent Cans,

Quoted 8 lines · Laurent Cans

When selecting custom uboot target the installation fail due to incorrect target built. So when configuring custom uboot target, build the target configured in buildroot configuration instead of legacy one.

Signed-off-by Laurent Cans <[email protected]>
---
 boot/uboot/uboot.mk |    1 +
 1 file changed, 1 insertion(+)

Two months ago you submitted this patch, and on the day of its submission, Arnout made some comments on it. However, you never came back with an updated version of the patch, and nobody else has stepped up to fix the problem.

Could you resend an updated version that takes into account Arnout's comment?

In the mean time, I'll mark your patch as "Changes requested" in our patchwork. This means we will no longer see it in the list of pending patches, so if you don't come back to us with an updated version, this change will never be applied.

Thanks a lot for your contribution!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com