Skip to contentSkip to conversation

hwmon: (max6639) Introduce local dev variable, and reduce noisiness

PATCH In review Guenter Roeck 2 participants 3 messages Feb 22, 2014 – Feb 23, 2014 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/2 hwmon: (max6639) Introduce local dev variable, and reduce noisiness

Introduce local variable 'dev' in probe function to make code easier to read. Also drop dev_info message in probe to reduce noisiness during boot.

---
 drivers/hwmon/max6639.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/hwmon/max6639.c +5 -7
index 066e587..52646bb 100644
@@ -545,11 +545,11 @@ static int max6639_detect(struct i2c_client *client,
 static int max6639_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
+	struct device *dev = &client->dev;
 	struct max6639_data *data;
 	int err;
 
-	data = devm_kzalloc(&client->dev, sizeof(struct max6639_data),
-			    GFP_KERNEL);
+	data = devm_kzalloc(dev, sizeof(struct max6639_data), GFP_KERNEL);
 	if (!data)
 		return -ENOMEM;
 
@@ -562,22 +562,20 @@ static int max6639_probe(struct i2c_client *client,
 		return err;
 
 	/* Register sysfs hooks */
-	err = sysfs_create_group(&client->dev.kobj, &max6639_group);
+	err = sysfs_create_group(&dev->kobj, &max6639_group);
 	if (err)
 		return err;
 
-	data->hwmon_dev = hwmon_device_register(&client->dev);
+	data->hwmon_dev = hwmon_device_register(dev);
 	if (IS_ERR(data->hwmon_dev)) {
 		err = PTR_ERR(data->hwmon_dev);
 		goto error_remove;
 	}
 
-	dev_info(&client->dev, "temperature sensor and fan control found\n");
-
 	return 0;
 
 error_remove:
-	sysfs_remove_group(&client->dev.kobj, &max6639_group);
+	sysfs_remove_group(&dev->kobj, &max6639_group);
 	return err;
 }
 
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Reviewed-by on v1 1/2
#1 lore raw
Quoted 9 lines · Guenter Roeck

Introduce local variable 'dev' in probe function to make code easier to read. Also drop dev_info message in probe to reduce noisiness during boot.

---
 drivers/hwmon/max6639.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(...)

Signature · 7 lines
Jean Delvare
Suse L3 Support

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
author maintainer
#2 lore raw
In reply to Guenter Roeck
Quoted 5 lines · Jean Delvare
Quoted 4 lines · Guenter Roeck

Introduce local variable 'dev' in probe function to make code easier to read. Also drop dev_info message in probe to reduce noisiness during boot.

Quoted 8 lines
Quoted 5 lines
---
  drivers/hwmon/max6639.c |   12 +++++-------
  1 file changed, 5 insertions(+), 7 deletions(-)

(...)

Thanks!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors