hwmon: (ltc4245) Drop debug messages
Guenter Roeck
maintainerPATCH v2 1/1 hwmon: (ltc4245) Drop debug messages
The debug messages in this driver have little if any value. Drop them.
---
v2: Drop debug messages instead of attaching them to the hwmon device.
drivers/hwmon/ltc4245.c | 3 --- 1 file changed, 3 deletions(-)
drivers/hwmon/ltc4245.c +0 -3
@@ -95,7 +95,6 @@ static void ltc4245_update_gpios(struct device *dev)* readings as stale by setting them to -EAGAIN */ if (time_after (jiffies, data->last_updated +5 *HZ )) { -dev_dbg (&client->dev,"Marking GPIOs invalid\n" );for (i =0 ; i <ARRAY_SIZE (data->gpios); i++) data->gpios[i] = -EAGAIN ; }
@@ -141,8 +140,6 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)if (time_after (jiffies, data->last_updated +HZ ) || !data->valid) { -dev_dbg (&client->dev,"Starting ltc4245 update\n" ); -/* Read control registers -- 0x00 to 0x07 */ for (i =0 ; i <ARRAY_SIZE (data->cregs); i++) { val =i2c_smbus_read_byte_data (client, i);
Signature · 7 lines
1.7.9.7 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 22 lines · Guenter Roeck
The debug messages in this driver have little if any value. Drop them.
Signed-off-by Guenter Roeck <[email protected]>---
v2: Drop debug messages instead of attaching them to the hwmon device.drivers/hwmon/ltc4245.c | 3 --- 1 file changed, 3 deletions(-)drivers/hwmon/ltc4245.c +0
-1@@ -95,7 +95,6 @@ static void ltc4245_update_gpios(struct device *dev)* readings as stale by setting them to -EAGAIN */ if (time_after (jiffies, data->last_updated +5 *HZ )) { -dev_dbg (&client->dev,"Marking GPIOs invalid\n" );for (i =0 ; i <ARRAY_SIZE (data->gpios); i++) data->gpios[i] = -EAGAIN ; }
drivers/hwmon/ltc4245.c static struct ltc4245_data *ltc4245_update_device(struct device *dev) · line 145
Quoted 8 lines
drivers/hwmon/ltc4245.c +0
-2@@ -141,8 +140,6 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)if (time_after (jiffies, data->last_updated +HZ ) || !data->valid) { -dev_dbg (&client->dev,"Starting ltc4245 update\n" ); -/* Read control registers -- 0x00 to 0x07 */ for (i =0 ; i <ARRAY_SIZE (data->cregs); i++) { val =i2c_smbus_read_byte_data (client, i);
Signature · 7 lines
Jean Delvare Suse L3 Support _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 26 lines · Jean Delvare
Quoted 25 lines · Guenter Roeck
The debug messages in this driver have little if any value. Drop them.
Signed-off-by Guenter Roeck <[email protected]>---
v2: Drop debug messages instead of attaching them to the hwmon device.drivers/hwmon/ltc4245.c | 3 --- 1 file changed, 3 deletions(-)drivers/hwmon/ltc4245.c +0
-1@@ -95,7 +95,6 @@ static void ltc4245_update_gpios(struct device *dev)* readings as stale by setting them to -EAGAIN */ if (time_after (jiffies, data->last_updated +5 *HZ )) { -dev_dbg (&client->dev,"Marking GPIOs invalid\n" );for (i =0 ; i <ARRAY_SIZE (data->gpios); i++) data->gpios[i] = -EAGAIN ; }@@ -141,8 +140,6 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)if (time_after (jiffies, data->last_updated +HZ ) || !data->valid) {
Quoted 8 lines
drivers/hwmon/ltc4245.c static struct ltc4245_data *ltc4245_update_device(struct device *dev) · line 145
Quoted 5 lines
drivers/hwmon/ltc4245.c +0
-2-dev_dbg (&client->dev,"Starting ltc4245 update\n" ); -/* Read control registers -- 0x00 to 0x07 */ for (i =0 ; i <ARRAY_SIZE (data->cregs); i++) { val =i2c_smbus_read_byte_data (client, i);Reviewed-by Jean Delvare <[email protected]>
Thanks!
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors