Skip to contentSkip to conversation

gspca_stv06xx: remove an unneeded check

PATCH In review Dan Carpenter 2 participants 2 messages Feb 18, 2014 – Feb 23, 2014

Subsystems (3)
Media (V4L/DVB) Kernel janitors Gspca USB webcam driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 gspca_stv06xx: remove an unneeded check

"err" is zero here so we don't need to check again.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c +1 -1
index bf3e5c317a26..e60cbb3aa609 100644
@@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
 
 	PDEBUG(D_STREAM, "Halting stream");
 
-	return (err < 0) ? err : 0;
+	return 0;
 }
 
 static int vv6410_dump(struct sd *sd)
#1 lore raw

Hi,

Quoted 10 lines · Dan Carpenter

"err" is zero here so we don't need to check again.

Signed-off-by Dan Carpenter <[email protected]>
drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c +0 -0
index bf3e5c317a26..e60cbb3aa609 100644

drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c static int vv6410_stop(struct sd *sd) · line 184

Quoted 8 lines
drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c +1 -1
@@ -178,7 +178,7 @@ static int vv6410_stop(struct sd *sd)
 
 	PDEBUG(D_STREAM, "Halting stream");
 
-	return (err < 0) ? err : 0;
+	return 0;
 }
 
 static int vv6410_dump(struct sd *sd)

Thanks I've added this to my gspca tree for 3.15.

Regards,

Hans