Skip to contentSkip to conversation

package/linux-headers: remove 2.6 snapshot

PATCH Superseded Yann E. MORIN 3 participants 5 messages Feb 23, 2014 – Feb 24, 2014

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/linux-headers: remove 2.6 snapshot

From: "Yann E. MORIN" <[email protected]>

As Thomas states:
It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.

Make it so! ;-)

Cc Thomas Petazzoni <[email protected]>
---
 package/linux-headers/Config.in.host | 4 ----
 1 file changed, 4 deletions(-)
package/linux-headers/Config.in.host +0 -4
index 134e338..fcecd62 100644
@@ -56,9 +56,6 @@ choice
 
 	config BR2_KERNEL_HEADERS_VERSION
 		bool "Manually specified Linux version"
-
-	config BR2_KERNEL_HEADERS_SNAP
-		bool "Local Linux snapshot (linux-2.6.tar.bz2)"
 endchoice
 
 config BR2_DEFAULT_KERNEL_VERSION
@@ -81,5 +78,4 @@ config BR2_DEFAULT_KERNEL_HEADERS
 	default "3.11.10"	if BR2_KERNEL_HEADERS_3_11
 	default "3.12.13"	if BR2_KERNEL_HEADERS_3_12
 	default "3.13.5"	if BR2_KERNEL_HEADERS_3_13
-	default "2.6"		if BR2_KERNEL_HEADERS_SNAP
 	default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 package/linux-headers: remove 2.6 snapshot

Quoted 30 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

As Thomas states:
It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.

Make it so! ;-)

Cc Thomas Petazzoni <[email protected]>
---
 package/linux-headers/Config.in.host | 4 ----
 1 file changed, 4 deletions(-)
package/linux-headers/Config.in.host +0 -3
index 134e338..fcecd62 100644
@@ -56,9 +56,6 @@ choice
 
 	config BR2_KERNEL_HEADERS_VERSION
 		bool "Manually specified Linux version"
-
-	config BR2_KERNEL_HEADERS_SNAP
-		bool "Local Linux snapshot (linux-2.6.tar.bz2)"
 endchoice
 
 config BR2_DEFAULT_KERNEL_VERSION

package/linux-headers/Config.in.host config BR2_DEFAULT_KERNEL_HEADERS · line 81

Quoted 5 lines
package/linux-headers/Config.in.host +0 -1
@@ -81,5 +78,4 @@ config BR2_DEFAULT_KERNEL_HEADERS
 	default "3.11.10"	if BR2_KERNEL_HEADERS_3_11
 	default "3.12.13"	if BR2_KERNEL_HEADERS_3_12
 	default "3.13.5"	if BR2_KERNEL_HEADERS_3_13
-	default "2.6"		if BR2_KERNEL_HEADERS_SNAP
 	default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION

This is missing Config.in.legacy support. The help text of the legacy
support should mention that the same can be achieved by using BR2_LINUX_KERNEL_CUSTOM_TARBALL.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 package/linux-headers: remove 2.6 snapshot

Arnout, All,

On 2014-02-24 08:07 +0100, Arnout Vandecappelle spake thusly:

Quoted 28 lines · Yann E. MORIN
Quoted 27 lines

From: "Yann E. MORIN" <[email protected]>

As Thomas states:
It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.

Make it so! ;-)

Cc Thomas Petazzoni <[email protected]>
---
 package/linux-headers/Config.in.host | 4 ----
 1 file changed, 4 deletions(-)
package/linux-headers/Config.in.host +0 -3
index 134e338..fcecd62 100644
@@ -56,9 +56,6 @@ choice
 
 	config BR2_KERNEL_HEADERS_VERSION
 		bool "Manually specified Linux version"
-
-	config BR2_KERNEL_HEADERS_SNAP
-		bool "Local Linux snapshot (linux-2.6.tar.bz2)"
 endchoice
 
Quoted 12 lines

package/linux-headers/Config.in.host config BR2_DEFAULT_KERNEL_HEADERS · line 81

Quoted 8 lines
package/linux-headers/Config.in.host +0 -1
 config BR2_DEFAULT_KERNEL_VERSION
@@ -81,5 +78,4 @@ config BR2_DEFAULT_KERNEL_HEADERS
 	default "3.11.10"	if BR2_KERNEL_HEADERS_3_11
 	default "3.12.13"	if BR2_KERNEL_HEADERS_3_12
 	default "3.13.5"	if BR2_KERNEL_HEADERS_3_13
-	default "2.6"		if BR2_KERNEL_HEADERS_SNAP
 	default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION

This is missing Config.in.legacy support. The help text of the legacy
support should mention that the same can be achieved by using BR2_LINUX_KERNEL_CUSTOM_TARBALL.

Right, I forgot that. Thanks for spotting it! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/linux-headers: remove 2.6 snapshot

In reply to Arnout Vandecappelle

Arnout, All,

On 2014-02-24 08:07 +0100, Arnout Vandecappelle spake thusly:

Quoted 28 lines · Yann E. MORIN
Quoted 27 lines

From: "Yann E. MORIN" <[email protected]>

As Thomas states:
It is completely weird to ask the tarball to be named exactly linux-2.6.tar.bz2. IMO, we should simply get rid of this feature.

Make it so! ;-)

Cc Thomas Petazzoni <[email protected]>
---
 package/linux-headers/Config.in.host | 4 ----
 1 file changed, 4 deletions(-)
package/linux-headers/Config.in.host +0 -3
index 134e338..fcecd62 100644
@@ -56,9 +56,6 @@ choice
 
 	config BR2_KERNEL_HEADERS_VERSION
 		bool "Manually specified Linux version"
-
-	config BR2_KERNEL_HEADERS_SNAP
-		bool "Local Linux snapshot (linux-2.6.tar.bz2)"
 endchoice
 
Quoted 12 lines

package/linux-headers/Config.in.host config BR2_DEFAULT_KERNEL_HEADERS · line 81

Quoted 8 lines
package/linux-headers/Config.in.host +0 -1
 config BR2_DEFAULT_KERNEL_VERSION
@@ -81,5 +78,4 @@ config BR2_DEFAULT_KERNEL_HEADERS
 	default "3.11.10"	if BR2_KERNEL_HEADERS_3_11
 	default "3.12.13"	if BR2_KERNEL_HEADERS_3_12
 	default "3.13.5"	if BR2_KERNEL_HEADERS_3_13
-	default "2.6"		if BR2_KERNEL_HEADERS_SNAP
 	default BR2_DEFAULT_KERNEL_VERSION if BR2_KERNEL_HEADERS_VERSION

This is missing Config.in.legacy support. The help text of the legacy
support should mention that the same can be achieved by using BR2_LINUX_KERNEL_CUSTOM_TARBALL.

In retrospect, BR2_LINUX_KERNEL_CUSTOM_TARBALL is for building the kernel. It is not used to install the headers, which is what we are doing here.

We still need to add a legacy option, though.

Regarrds,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/linux-headers: remove 2.6 snapshot

Quoted 9 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

This is missing Config.in.legacy support. The help text of the legacy support should mention that the same can be achieved by using BR2_LINUX_KERNEL_CUSTOM_TARBALL.

In retrospect, BR2_LINUX_KERNEL_CUSTOM_TARBALL is for building the kernel. It is not used to install the headers, which is what we are doing here.

True. A custom version (but still mainline kernel) can be handled through BR2_KERNEL_HEADERS_VERSION, but it isn't exactly the same as the custom tarball.

Signature · 1 line
Bye, Peter Korsgaard