Thermal: Allow first update of cooling device state
PATCH 1/1 Thermal: Allow first update of cooling device state
In initialization, if the cooling device is initialized at max cooling state, and the thermal zone temperature is below the first trip point, then the cooling state can't be updated to the right state, untill the first trip point be triggered.
To fix this issue, allow first update of cooling device state during registration, initialized "updated" device field as "false" (instead of "true").
--- drivers/thermal/thermal_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/thermal_core.c +1 -1
@@ -1107,7 +1107,7 @@ __thermal_cooling_device_register(struct device_node *np,INIT_LIST_HEAD (&cdev->thermal_instances); cdev->np = np; cdev->ops = ops; - cdev->updated = true; + cdev->updated = false; cdev->device.class = &thermal_class; cdev->devdata = devdata;dev_set_name (&cdev->device,"cooling_device%d" , cdev->id);
Signature · 1 line
1.7.9.5
Hi, Rui
Do you have any comment for it ?
Thanks.
Wei.
Quoted 28 lines · Wei Ni
In initialization, if the cooling device is initialized at max cooling state, and the thermal zone temperature is below the first trip point, then the cooling state can't be updated to the right state, untill the first trip point be triggered.
To fix this issue, allow first update of cooling device state during registration, initialized "updated" device field as "false" (instead of "true").
Signed-off-by Wei Ni <[email protected]>--- drivers/thermal/thermal_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/thermal_core.c +1
-1@@ -1107,7 +1107,7 @@ __thermal_cooling_device_register(struct device_node *np,INIT_LIST_HEAD (&cdev->thermal_instances); cdev->np = np; cdev->ops = ops; - cdev->updated = true; + cdev->updated = false; cdev->device.class = &thermal_class; cdev->devdata = devdata;dev_set_name (&cdev->device,"cooling_device%d" , cdev->id);
Quoted 10 lines · Wei Ni
In initialization, if the cooling device is initialized at max cooling state, and the thermal zone temperature is below the first trip point, then the cooling state can't be updated to the right state, untill the first trip point be triggered.
To fix this issue, allow first update of cooling device state during registration, initialized "updated" device field as "false" (instead of "true").
Signed-off-by Wei Ni <[email protected]>
applied.
thanks,
rui
Quoted 17 lines
--- drivers/thermal/thermal_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/thermal_core.c +1
-1@@ -1107,7 +1107,7 @@ __thermal_cooling_device_register(struct device_node *np,INIT_LIST_HEAD (&cdev->thermal_instances); cdev->np = np; cdev->ops = ops; - cdev->updated = true; + cdev->updated = false; cdev->device.class = &thermal_class; cdev->devdata = devdata;dev_set_name (&cdev->device,"cooling_device%d" , cdev->id);