Skip to contentSkip to conversation

ARM: tegra: add device tree for SHIELD

PATCH In review Alexandre Courbot 3 participants 10 messages Feb 24, 2014 – Feb 26, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: add device tree for SHIELD

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

A default kernel command-line as well as initrd addresses are hardcoded to match the static values the bootloader is known to use. This allows booting from an appended DTB without having to alter it at boot time, since the bootloader has no Device Tree support.

---
 arch/arm/boot/dts/Makefile          |    1 +
 arch/arm/boot/dts/tegra114-roth.dts | 1087 +++++++++++++++++++++++++++++++++++
 2 files changed, 1088 insertions(+)
 create mode 100644 arch/arm/boot/dts/tegra114-roth.dts
arch/arm/boot/dts/Makefile +1 -0
index 2f1c2184732b..8f00bf0d4128 100644
@@ -338,6 +338,7 @@ dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \
 	tegra30-cardhu-a02.dtb \
 	tegra30-cardhu-a04.dtb \
 	tegra114-dalmore.dtb \
+	tegra114-roth.dtb \
 	tegra124-venice2.dtb
 dtb-$(CONFIG_ARCH_VERSATILE) += versatile-ab.dtb \
 	versatile-pb.dtb
arch/arm/boot/dts/tegra114-roth.dts new file +1087 -0

1,087 lines not on this page · raw message

Signature · 1 line
1.9.0
#1 lore raw
Quoted 3 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

You could add a simple-framebuffer node for now, I think?

arch/arm/boot/dts/tegra114-roth.dts line 24

Quoted 4 lines
arch/arm/boot/dts/tegra114-roth.dts +2 -0
 
+	memory {
+		reg = <0x80000000 0x79600000>;

It might be worth a comment here pointing out that the rest of RAM is reserved for some carveouts/..., or at least that these values are set this way in order to match what the bootloader usually passes to downstream kernels in the command-line?

arch/arm/boot/dts/tegra114-roth.dts line 786

Quoted 7 lines
arch/arm/boot/dts/tegra114-roth.dts +6 -0
+	i2c at 7000d000 {
 
+		palmas: pmic at 58 {
+			compatible = "ti,palmas";
+			reg = <0x58>;
+			interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
+			ti,irq-externally-inverted;

Unfortunately, the patch I sent to document/implement that last property hasn't yet been ack'd/applied, so I'll hold off applying this until it has.

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 7 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+	/* Wifi */
+	sdhci at 78000000 {
+		status = "okay";
+		bus-width = <4>;
+		broken-cd;
+		keep-power-in-suspend;
+		cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

Should we add broken-cd and/or cap-sdio-irq to the SDIO WiFi on other boards (Springbank, Ventana, Cardhu)?

arch/arm/boot/dts/tegra114-roth.dts line 989

Quoted 7 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+	usb-phy at 7d000000 {
+		status = "okay";
+		nvidia,xcvr-setup = <7>;
+		nvidia,xcvr-lsfslew = <2>;
+		nvidia,xcvr-lsrslew = <2>;
+		interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+		dr_mode = "otg";

While opt is probably accurate, we don't actually support otg upstream, but only host. While the DT is supposed to represent HW rather than SW/OS details, I've tried to avoid putting otg into the DT, since I'm not sure that the DT binding for otg is stable, since we can't test it, whereas host probably is. Still, this is a pretty minor detail, and we can ignore that if you want ("otg" evidently /works/ fine on Seaboard, so it's OK if you keep this).

#2 lore raw
Quoted 6 lines · Stephen Warren
Quoted 3 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

You could add a simple-framebuffer node for now, I think?

That would not be useful I'm afraid, since the DSI clocks will be switched off in the absence of a dsi DT node in host1x, so you would end up with a blank screen. Our best shot at display for the moment would be HDMI, but I need to spend some more time on it.

Proper internal panel support would require a panel driver with the proper DSI initialization sequences. It is in my pipe.

Quoted 9 lines

arch/arm/boot/dts/tegra114-roth.dts line 24

Quoted 4 lines
arch/arm/boot/dts/tegra114-roth.dts +2 -0
 
+	memory {
+		reg = <0x80000000 0x79600000>;

It might be worth a comment here pointing out that the rest of RAM is reserved for some carveouts/..., or at least that these values are set this way in order to match what the bootloader usually passes to downstream kernels in the command-line?

Yes, absolutely right. On a more general note I feel like DTs could gain clarity if they had more comments (e.g. for pinmuxing which are a quite heavy block otherwise), do you have any objection to this? (I guess not, but so far the rule seems to be "no comment in DT" :P )

Quoted 11 lines

arch/arm/boot/dts/tegra114-roth.dts line 786

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts +6 -0
+	i2c at 7000d000 {
 
+		palmas: pmic at 58 {
+			compatible = "ti,palmas";
+			reg = <0x58>;
+			interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
+			ti,irq-externally-inverted;

Unfortunately, the patch I sent to document/implement that last property hasn't yet been ack'd/applied, so I'll hold off applying this until it has.

That's fine, I wanted to avoid sending another patch soon after just for that particular change.

Quoted 10 lines

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+	/* Wifi */
+	sdhci at 78000000 {
+		status = "okay";
+		bus-width = <4>;
+		broken-cd;
+		keep-power-in-suspend;
+		cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

Otherwise, Wifi works great with the brcmfmac driver and NVRAM file extracted from Android.

Quoted 2 lines

Should we add broken-cd and/or cap-sdio-irq to the SDIO WiFi on other boards (Springbank, Ventana, Cardhu)?

If they don't have the GPIO requirement that SHIELD has, I don't think it is necessary. non-removable is probably a better property for soldered Wifi chips.

I'm not sure about cap-sdio-irq, it doesn't seem to make a difference for SHIELD Wifi.

Quoted 16 lines

arch/arm/boot/dts/tegra114-roth.dts line 989

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+	usb-phy at 7d000000 {
+		status = "okay";
+		nvidia,xcvr-setup = <7>;
+		nvidia,xcvr-lsfslew = <2>;
+		nvidia,xcvr-lsrslew = <2>;
+		interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
+		dr_mode = "otg";

While opt is probably accurate, we don't actually support otg upstream, but only host. While the DT is supposed to represent HW rather than SW/OS details, I've tried to avoid putting otg into the DT, since I'm not sure that the DT binding for otg is stable, since we can't test it, whereas host probably is. Still, this is a pretty minor detail, and we can ignore that if you want ("otg" evidently /works/ fine on Seaboard, so it's OK if you keep this).

The setting works for me and the binding is documented, so maybe we can keep it as-is?

Thanks for the review - v2 will be on the way, as well as Tegra Note 7 hopefully.

Alex.

#3 lore raw
Quoted 22 lines · Alexandre Courbot
Quoted 10 lines

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts new file +7 -0
+    /* Wifi */
+    sdhci at 78000000 {
+        status = "okay";
+        bus-width = <4>;
+        broken-cd;
+        keep-power-in-suspend;
+        cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

Quoted 6 lines

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

Hi Alexandre,

I recently posted a proposal for brcmfmac DT binding [1]. I did receive some comments, but it would be great if you (and/or others involved) had a look at it as well and give me some feedback. DT work still needs to grow on me.

Quoted 2 lines

Otherwise, Wifi works great with the brcmfmac driver and NVRAM file extracted from Android.

With in-band interrupts, indeed. The HOST_WAKE signal is the OOB interrupt which would need to be provided in the device-tree.

Regards,
Arend

[1] http://mid.gmane.org/1392059868-8782-1-git-send-email-arend at broadcom.com

#4 lore raw
Quoted 30 lines · Arend van Spriel
Quoted 22 lines · Alexandre Courbot
Quoted 10 lines

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts new file +7 -0
+    /* Wifi */
+    sdhci at 78000000 {
+        status = "okay";
+        bus-width = <4>;
+        broken-cd;
+        keep-power-in-suspend;
+        cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

Quoted 6 lines

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

Quoted 6 lines

Hi Alexandre,

I recently posted a proposal for brcmfmac DT binding [1]. I did receive some comments, but it would be great if you (and/or others involved) had a look at it as well and give me some feedback. DT work still needs to grow on me.

Hi Arend, (and thanks again for all the help with getting the chip to work!)

Great, I'm not subscribed to the devicetree list and so have missed this thread, but I'm glad to see it.

I don't think I have much to add to the comments you already received there. I'd need it to reference the 32K clock (which I currently force-enable manually), the OOB interrupt, and the reset pin as a GPIO (as for SHIELD the device needs to be put out of reset using an active-low GPIO before anything can happen). That last property could be optional as I suspect most designs won't use it.

Getting the device out of reset should be done before the bus probes the non-removable device, so I wonder how this would fit wrt. the DT power-on sequencing series by Olof. Something tells me this could rather be a property of the bus, but physically speaking the pin is connected to the wifi chip, so... Maybe we could get the platform driver to ask the bus to probe again after enabling power/getting the device out of reset?

#5 lore raw
Quoted 51 lines · Alexandre Courbot
Quoted 30 lines · Arend van Spriel
Quoted 22 lines · Alexandre Courbot
Quoted 10 lines

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 8 lines
arch/arm/boot/dts/tegra114-roth.dts new file +7 -0
+    /* Wifi */
+    sdhci at 78000000 {
+        status = "okay";
+        bus-width = <4>;
+        broken-cd;
+        keep-power-in-suspend;
+        cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

Quoted 6 lines

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

Quoted 6 lines

Hi Alexandre,

I recently posted a proposal for brcmfmac DT binding [1]. I did receive some comments, but it would be great if you (and/or others involved) had a look at it as well and give me some feedback. DT work still needs to grow on me.

Hi Arend, (and thanks again for all the help with getting the chip to work!)

Great, I'm not subscribed to the devicetree list and so have missed this thread, but I'm glad to see it.

I don't think I have much to add to the comments you already received there. I'd need it to reference the 32K clock (which I currently force-enable manually), the OOB interrupt, and the reset pin as a GPIO (as for SHIELD the device needs to be put out of reset using an active-low GPIO before anything can happen). That last property could be optional as I suspect most designs won't use it.

Quoted 7 lines

Getting the device out of reset should be done before the bus probes the non-removable device, so I wonder how this would fit wrt. the DT power-on sequencing series by Olof. Something tells me this could rather be a property of the bus, but physically speaking the pin is connected to the wifi chip, so... Maybe we could get the platform driver to ask the bus to probe again after enabling power/getting the device out of reset?

Actually, brcmfmac provides a platform driver and a sdio driver. At the end of the platform probe it registers the sdio driver, which will trigger the bus to probe again. I am not sure how that would relate to the DT power-on sequencing you mentioned.

Regards,
Arend

#6 lore raw
In reply to Alexandre Courbot
Quoted 17 lines · Alexandre Courbot
Quoted 8 lines · Stephen Warren
Quoted 6 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

arch/arm/boot/dts/tegra114-roth.dts +0 -0
Quoted 7 lines

arch/arm/boot/dts/tegra114-roth.dts line 24

Quoted 2 lines
arch/arm/boot/dts/tegra114-roth.dts +2 -0
+    memory {
+        reg = <0x80000000 0x79600000>;

It might be worth a comment here pointing out that the rest of RAM is reserved for some carveouts/..., or at least that these values are set this way in order to match what the bootloader usually passes to downstream kernels in the command-line?

Quoted 4 lines

Yes, absolutely right. On a more general note I feel like DTs could gain clarity if they had more comments (e.g. for pinmuxing which are a quite heavy block otherwise), do you have any objection to this? (I guess not, but so far the rule seems to be "no comment in DT" :P )

I have no objection in particular. Specifically for pinmux, the values seem pretty obvious, so I'm not sure what extra the comment could convey, but I'll take a look at any proposed patch:-)

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+    /* Wifi */
+    sdhci at 78000000 {
+        status = "okay";
+        bus-width = <4>;
+        broken-cd;
+        keep-power-in-suspend;
+        cap-sdio-irq;
Quoted 6 lines
Quoted 1 line

Is non-removable better than broken-cd, or are they entirely unrelated?

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

It doesn't sound like that's what we want either; we should know exactly when the device is added/removed, based on when the relevant clocks/supplies/... are turned on/off.

Quoted 5 lines

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

How does that GPIO get manipulated right now? I assume you must be manually configuring it via sysfs after boot or something? If so, perhaps it's best to just leave out the WiFi node until it works automatically.

Quoted 6 lines

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

There was a thread on this topic on LAKML recently. I didn't really follow it, so I don't know if there was a useful resolution. I think it was "mmc: add support for power-on sequencing through DT", although there may have been other related threads. It was possibly tangentially related to power-sequences-in-DT...

...

Quoted 2 lines

I'm not sure about cap-sdio-irq, it doesn't seem to make a difference for SHIELD Wifi.

I'd tend to leave it out then.

#7 lore raw
Quoted 18 lines · Stephen Warren
Quoted 17 lines · Alexandre Courbot
Quoted 15 lines · Stephen Warren

arch/arm/boot/dts/tegra114-roth.dts line 24

Quoted 9 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

arch/arm/boot/dts/tegra114-roth.dts +2 -0
 
+    memory {
+        reg = <0x80000000 0x79600000>;

It might be worth a comment here pointing out that the rest of RAM is reserved for some carveouts/..., or at least that these values are set this way in order to match what the bootloader usually passes to downstream kernels in the command-line?

Quoted 8 lines
Quoted 4 lines

Yes, absolutely right. On a more general note I feel like DTs could gain clarity if they had more comments (e.g. for pinmuxing which are a quite heavy block otherwise), do you have any objection to this? (I guess not, but so far the rule seems to be "no comment in DT" :P )

I have no objection in particular. Specifically for pinmux, the values seem pretty obvious, so I'm not sure what extra the comment could convey, but I'll take a look at any proposed patch:-)

It would just make grouping of related pins according more visible than having to look at the "nvidia,function" property currently does - just a little added comfort.

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines

arch/arm/boot/dts/tegra114-roth.dts line 959

Quoted 7 lines
arch/arm/boot/dts/tegra114-roth.dts +7 -0
+    /* Wifi */
+    sdhci at 78000000 {
+        status = "okay";
+        bus-width = <4>;
+        broken-cd;
+        keep-power-in-suspend;
+        cap-sdio-irq;

Is non-removable better than broken-cd, or are they entirely unrelated?

Quoted 8 lines
Quoted 4 lines

They are unrelated actually. With non-removable the driver expects the device to always be there since boot, and does not check for the card to be removed/added after boot. broken-cd indicates there is no CD line and the device should be polled regularly.

It doesn't sound like that's what we want either; we should know exactly when the device is added/removed, based on when the relevant clocks/supplies/... are turned on/off.

Yes, I guess this will require a proper DT binding like what Arend proposed.

Quoted 10 lines
Quoted 5 lines

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

How does that GPIO get manipulated right now? I assume you must be manually configuring it via sysfs after boot or something? If so, perhaps it's best to just leave out the WiFi node until it works automatically.

The GPIO needs to be set from user-space, yes. But if we leave the Wifi node out, I'm concerned that wireless will not be usable at all, wouldn't it?

Quoted 13 lines
Quoted 6 lines

This also raises another, redundant problem with DT bindings: AFAIK we currently have no way to let the system know the device will only appear after a given GPIO is set. It would also be nice to be able to give some parameters to the Wifi driver through the DT (like the OOB interrupt). Right now the Wifi chip is brought up by exporting the GPIO and writing to it from user-space, and the OOB interrupt is not used.

There was a thread on this topic on LAKML recently. I didn't really follow it, so I don't know if there was a useful resolution. I think it was "mmc: add support for power-on sequencing through DT", although there may have been other related threads. It was possibly tangentially related to power-sequences-in-DT...

Quoted 5 lines

...

Quoted 2 lines

I'm not sure about cap-sdio-irq, it doesn't seem to make a difference for SHIELD Wifi.

I'd tend to leave it out then.

I will check whether it helps with the latency issues I have noticed and remove it if it doesn't.

Thanks,
Alex.

#8 lore raw
Quoted 7 lines · Alexandre Courbot
Quoted 6 lines · Stephen Warren
Quoted 5 lines · Alexandre Courbot
Quoted 4 lines · Stephen Warren
Quoted 3 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

...

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

Quoted 8 lines
Quoted 4 lines

How does that GPIO get manipulated right now? I assume you must be manually configuring it via sysfs after boot or something? If so, perhaps it's best to just leave out the WiFi node until it works automatically.

The GPIO needs to be set from user-space, yes. But if we leave the Wifi node out, I'm concerned that wireless will not be usable at all, wouldn't it?

True, but if we have no representation of the device in DT that works without manually enabling clocks and/or GPIOs, it's not a complete/accurate representation of the HW, so it doesn't make sense to add it to DT. Yes, I admit that sucks.

#9 lore raw
Quoted 20 lines · Stephen Warren
Quoted 7 lines · Alexandre Courbot
Quoted 6 lines · Stephen Warren
Quoted 5 lines · Alexandre Courbot
Quoted 4 lines · Stephen Warren
Quoted 3 lines · Alexandre Courbot

Add a device tree for NVIDIA SHIELD. The set of enabled features is still minimal with no display option (although HDMI should be easy to get to work) and USB requiring external power.

...

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines

For the Wifi chip, non-removable would be the correct setting hardware-wise, but there is a trap: the chip has its reset line asserted at boot-time, and you need to set GPIO 229 to de-assert it. Only after that will the device be detected on the SDIO bus. Since it lacks a CD line, it must be polled, hence the broken-cd property.

How does that GPIO get manipulated right now? I assume you must be manually configuring it via sysfs after boot or something? If so, perhaps it's best to just leave out the WiFi node until it works automatically.

Quoted 8 lines
Quoted 3 lines

The GPIO needs to be set from user-space, yes. But if we leave the Wifi node out, I'm concerned that wireless will not be usable at all, wouldn't it?

True, but if we have no representation of the device in DT that works without manually enabling clocks and/or GPIOs, it's not a complete/accurate representation of the HW, so it doesn't make sense to add it to DT. Yes, I admit that sucks.

Well, I can always enable it in my out-of-tree branch until we can push the complete binding in mainline, so I'm ok with taking it out of this patch for now.