Skip to contentSkip to conversation

thrift: needs host-bison

PATCH New Gustavo Zacarias 2 participants 3 messages Feb 25, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thrift: needs host-bison

Fixes:
http://autobuild.buildroot.net/results/d46/d46f9097780bdde68ec15f693281ee0b04667f98/

---
 package/thrift/thrift.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/thrift/thrift.mk +3 -2
index d61cc3a..728a67a 100644
@@ -6,10 +6,11 @@
 
 THRIFT_VERSION = 0.9.1
 THRIFT_SITE = http://www.us.apache.org/dist/thrift/$(THRIFT_VERSION)
-THRIFT_DEPENDENCIES = host-pkgconf host-thrift boost libevent openssl zlib
+THRIFT_DEPENDENCIES = host-bison host-pkgconf host-thrift boost libevent \
+	openssl zlib
 THRIFT_INSTALL_STAGING = YES
 HOST_THRIFT_DEPENDENCIES = host-boost host-libevent host-openssl host-pkgconf \
-	host-zlib
+	host-zlib host-bison
 THRIFT_CONF_OPT = --with-sysroot=$(STAGING_DIR) --with-tests=no \
 	--with-boost=$(STAGING_DIR)
 HOST_THRIFT_CONF_OPT = --with-sysroot=$(HOST_DIR) --with-tests=no
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 thrift: needs host-bison

Gustavo,

Gustavo Zacarias <[email protected]> wrote on 02/25/2014 06:55:28 AM:

Quoted 14 lines

Fixes:
http://autobuild.buildroot.net/results/d46/
d46f9097780bdde68ec15f693281ee0b04667f98/

---
 package/thrift/thrift.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/thrift/thrift.mk +0 -0
index d61cc3a..728a67a 100644

package/thrift/thrift.mk line 9

Quoted 4 lines
package/thrift/thrift.mk +0 -1
@@ -6,10 +6,11 @@
 
 THRIFT_VERSION = 0.9.1
 THRIFT_SITE = http://www.us.apache.org/dist/thrift/$(THRIFT_VERSION)
-THRIFT_DEPENDENCIES = host-pkgconf host-thrift boost libevent openssl 

zlib

package/thrift/thrift.mk line 9

Quoted 1 line
package/thrift/thrift.mk +1 -0
+THRIFT_DEPENDENCIES = host-bison host-pkgconf host-thrift boost 

libevent \

package/thrift/thrift.mk

Quoted 3 lines
package/thrift/thrift.mk +1 -0
+   openssl zlib
 THRIFT_INSTALL_STAGING = YES
 HOST_THRIFT_DEPENDENCIES = host-boost host-libevent host-openssl 

host-pkgconf \

package/thrift/thrift.mk line 16

Quoted 5 lines
package/thrift/thrift.mk +1 -1
-   host-zlib
+   host-zlib host-bison
 THRIFT_CONF_OPT = --with-sysroot=$(STAGING_DIR) --with-tests=no \
    --with-boost=$(STAGING_DIR)
 HOST_THRIFT_CONF_OPT = --with-sysroot=$(HOST_DIR) --with-tests=no

I believe Thomas P submitted a patch today or last night that does something similar and was accepted. However it doesn't appear that he added a dependancy on the thrift package itself.

http://patchwork.ozlabs.org/patch/323781/

Thanks,
-Ryan

#2 lore raw

PATCH 1/1 thrift: needs host-bison

Quoted 8 lines · Ryan Barnett

I believe Thomas P submitted a patch today or last night that does something similar and was accepted. However it doesn't appear that he added a dependancy on the thrift package itself.

http://patchwork.ozlabs.org/patch/323781/

Thanks,
-Ryan

Right, mail backlog and no morning pull got me.
I've already superseeded it in patchwork.
Having it for thrift itself is mostly correctness at the moment since it depends on host-thrift, just if in the (unlikely) future of that changing. Regards.