Skip to contentSkip to conversation

ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

PATCH In review Satoru Takeuchi 3 participants 6 messages Feb 23, 2014 – Feb 26, 2014 Ktest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

From: Satoru Takeuchi <[email protected]>

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL in the kvm.conf.

---
 tools/testing/ktest/examples/kvm.conf | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/ktest/examples/kvm.conf +4 -0
index 831c7c5..40356f7 100644
@@ -10,6 +10,10 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
 #*************************************#
 # This part is the same as test.conf  #
 #*************************************#
Signature · 1 line
1.8.4.2
maintainer
#1 lore raw
Quoted 17 lines · On Sun, 23 Feb 2014 10:19:28 +0900 Satoru Takeuchi <[email protected]>…

From: Satoru Takeuchi <[email protected]>

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL in the kvm.conf.

---
 tools/testing/ktest/examples/kvm.conf | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/ktest/examples/kvm.conf +0 -0
index 831c7c5..40356f7 100644

tools/testing/ktest/examples/kvm.conf MACHINE = Guest · line 16

Quoted 7 lines
tools/testing/ktest/examples/kvm.conf +4 -0
@@ -10,6 +10,10 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+

Thanks, I'll add this to my 3.15 queue.

-- Steve

Quoted 3 lines
tools/testing/ktest/examples/kvm.conf +0 -0
 #*************************************#
 # This part is the same as test.conf  #
 #*************************************#
#2 lore raw
Quoted 23 lines · Steven Rostedt
Quoted 20 lines · On Sun, 23 Feb 2014 10:19:28 +0900 Satoru Takeuchi <[email protected]>…

From: Satoru Takeuchi <[email protected]>

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL in the kvm.conf.

---
  tools/testing/ktest/examples/kvm.conf | 4 ++++
  1 file changed, 4 insertions(+)
tools/testing/ktest/examples/kvm.conf +0 -0
index 831c7c5..40356f7 100644
@@ -10,6 +10,10 @@ MACHINE = Guest
  # Use virsh to read the serial console of the guest
  CONSOLE =  virsh console ${MACHINE}
 
Quoted 6 lines

tools/testing/ktest/examples/kvm.conf MACHINE = Guest · line 16

Quoted 4 lines
tools/testing/ktest/examples/kvm.conf +4 -0
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+

Thanks, I'll add this to my 3.15 queue.

Hmm, it seems that we need a following patch as well. Or, please merge with the orignal patch.

Thanks,
Takahiro

======================================================================
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro <[email protected]>
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo

Cc Satoru Takeuchi <[email protected]>
Cc Steven Rostedt <[email protected]>
---
 tools/testing/ktest/examples/kvm.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/ktest/examples/kvm.conf +1 -1
index 40356f7..fbc134f 100644
@@ -10,7 +10,7 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 
-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
 # by the default signal, SIGINT.
 CLOSE_CONSOLE_SIGNAL = KILL
 
Signature · 1 line
1.8.3.1
#3 lore raw

At Tue, 25 Feb 2014 21:21:18 -0500,

Quoted 59 lines · MUNEDA Takahiro
Quoted 23 lines · Steven Rostedt
Quoted 20 lines · On Sun, 23 Feb 2014 10:19:28 +0900 Satoru Takeuchi <[email protected]>…

From: Satoru Takeuchi <[email protected]>

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL in the kvm.conf.

---
  tools/testing/ktest/examples/kvm.conf | 4 ++++
  1 file changed, 4 insertions(+)
tools/testing/ktest/examples/kvm.conf +0 -0
index 831c7c5..40356f7 100644
@@ -10,6 +10,10 @@ MACHINE = Guest
  # Use virsh to read the serial console of the guest
  CONSOLE =  virsh console ${MACHINE}
 
Quoted 6 lines

tools/testing/ktest/examples/kvm.conf MACHINE = Guest · line 16

Quoted 4 lines
tools/testing/ktest/examples/kvm.conf +4 -0
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+

Thanks, I'll add this to my 3.15 queue.

Hmm, it seems that we need a following patch as well. Or, please merge with the orignal patch.

Thanks,
Takahiro

======================================================================
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro <[email protected]>
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo

Cc Satoru Takeuchi <[email protected]>
Cc Steven Rostedt <[email protected]>
---
 tools/testing/ktest/examples/kvm.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/ktest/examples/kvm.conf +0 -0
index 40356f7..fbc134f 100644

tools/testing/ktest/examples/kvm.conf MACHINE = Guest · line 13

Quoted 4 lines
tools/testing/ktest/examples/kvm.conf +1 -0
@@ -10,7 +10,7 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 -# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console

Oops, it's a completely the different signal. Thanks Takahiro.

Satoru

Quoted 4 lines
tools/testing/ktest/examples/kvm.conf +0 -0
 # by the default signal, SIGINT.
 CLOSE_CONSOLE_SIGNAL = KILL
 -- 

1.8.3.1

maintainer
#4 lore raw
Quoted 4 lines · On Wed, 26 Feb 2014 20:43:16 +0900 Satoru Takeuchi <[email protected]>…
Quoted 2 lines

-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console

Oops, it's a completely the different signal. Thanks Takahiro.

Please be careful...
That one letter is the difference between the "Beastie Boys" and "007"

Sending the Beastie Boys out to serve for Her Majesty's Secret Service would be a disaster.

http://en.wikipedia.org/wiki/Licensed_to_Ill
http://en.wikipedia.org/wiki/Licensed_to_Kill_(1965_film)

-- Steve

maintainer
#5 lore raw
In reply to MUNEDA Takahiro
Quoted 2 lines · On Tue, 25 Feb 2014 21:21:18 -0500 MUNEDA Takahiro…

Hmm, it seems that we need a following patch as well. Or, please merge with the orignal patch.

I folded this fix in, here's the final:

Quoted 1 line

From 62183dcac539a14ed0a820b8392db353d72a7d7e Mon Sep 17 00:00:00 2001

From: Satoru Takeuchi <[email protected]>
Date: Sun, 23 Feb 2014 10:19:28 +0900
Subject: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf

As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL in the kvm.conf.

---
 tools/testing/ktest/examples/kvm.conf | 4 ++++
 1 file changed, 4 insertions(+)
tools/testing/ktest/examples/kvm.conf +4 -0
index 831c7c5..fbc134f 100644
@@ -10,6 +10,10 @@ MACHINE = Guest
 # Use virsh to read the serial console of the guest
 CONSOLE =  virsh console ${MACHINE}
 
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
 #*************************************#
 # This part is the same as test.conf  #
 #*************************************#
Signature · 1 line
1.8.5.3