Skip to contentSkip to conversation

fix: trats: clock setup: enable all clocks in clk_gate_block.

PATCH New Przemyslaw Marczak 2 participants 3 messages Feb 25, 2014 – Feb 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix: trats: clock setup: enable all clocks in clk_gate_block.

This change fixes kernel boot issue on trats. Some drivers in kernel 3.10 expects that proper clocks are enabled, e.g. mfc driver clock.

cc Lukasz Majewski <[email protected]>
cc Minkyu Kang <[email protected]>
cc Tom Rini <[email protected]>
---
 board/samsung/trats/setup.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/samsung/trats/setup.h +1 -1
index 2f5ccb1..efb392c 100644
@@ -611,7 +611,7 @@
 					  | (CLK_EN << BIT_PERIL_CLK_SLIMBUS)))
 #define CLK_GATE_IP_PERIR_VAL		(CLK_GATE_IP_PERIR_ALL_DIS \
 					| ~((CLK_EN << BIT_PERIR_CLK_KEYIF)))
-#define CLK_GATE_BLOCK_VAL		CLK_GATE_BLOCK_ALL_DIS
+#define CLK_GATE_BLOCK_VAL		CLK_GATE_BLOCK_ALL_EN
 
 /* PS_HOLD: Data Hight, Output En */
 #define BIT_DAT				8
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 fix: trats: clock setup: enable all clocks in clk_gate_block.

Quoted 7 lines · Przemyslaw Marczak

This change fixes kernel boot issue on trats. Some drivers in kernel 3.10 expects that proper clocks are enabled, e.g. mfc driver clock.

cc Lukasz Majewski <[email protected]>
cc Minkyu Kang <[email protected]>
cc Tom Rini <[email protected]>

My first inclination is NAK, the kernel is responsible for enabling clocks that it needs and we spent a while in TI-land dealing with the fallout in various ways of enabling everything in U-Boot (you run into various types of PM-related fun). If you have a vendor kernel you need to support this on, you need a vendor U-Boot with this work-around until the kernel is fixed.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140225/440d893e/attachment.pgp>
#2 lore raw

PATCH 1/1 fix: trats: clock setup: enable all clocks in clk_gate_block.

Hello Tom,

Quoted 10 lines · Tom Rini
Quoted 7 lines · Przemyslaw Marczak

This change fixes kernel boot issue on trats. Some drivers in kernel 3.10 expects that proper clocks are enabled, e.g. mfc driver clock.

cc Lukasz Majewski <[email protected]>
cc Minkyu Kang <[email protected]>
cc Tom Rini <[email protected]>
Quoted 7 lines

My first inclination is NAK, the kernel is responsible for enabling clocks that it needs and we spent a while in TI-land dealing with the fallout in various ways of enabling everything in U-Boot (you run into various types of PM-related fun). If you have a vendor kernel you need to support this on, you need a vendor U-Boot with this work-around until the kernel is fixed.

Thank you for reply. You're right, it wasn't good idea. So I will wait for such fix in mainline kernel.

Regards

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com