Skip to contentSkip to conversation

ARM: tegra: set CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

PATCH New Stephen Warren 2 participants 3 messages Feb 10, 2014 – Feb 27, 2014 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra: set CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

From: Stephen Warren <[email protected]>

Tegra's EHCI controllers only have a single PORTSC register. Configure U-Boot to know this. This prevents e.g. ehci_shutdown() from touching non-existent registers.

---
 include/configs/tegra114-common.h | 1 +
 include/configs/tegra124-common.h | 1 +
 include/configs/tegra20-common.h  | 1 +
 include/configs/tegra30-common.h  | 1 +
 4 files changed, 4 insertions(+)
include/configs/tegra114-common.h +1 -0
index bff5447fe421..555c237cbf1c 100644
@@ -82,5 +82,6 @@
 /* For USB EHCI controller */
 #define CONFIG_EHCI_IS_TDI
 #define CONFIG_USB_EHCI_TXFIFO_THRESH	0x10
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 1
 
 #endif /* _TEGRA114_COMMON_H_ */
include/configs/tegra124-common.h +1 -0
index 4568bc761ecd..61e50265740d 100644
@@ -74,5 +74,6 @@
 /* For USB EHCI controller */
 #define CONFIG_EHCI_IS_TDI
 #define CONFIG_USB_EHCI_TXFIFO_THRESH	0x10
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 1
 
 #endif /* _TEGRA124_COMMON_H_ */
include/configs/tegra20-common.h +1 -0
index 933130a405da..21bf97717424 100644
@@ -95,6 +95,7 @@
  */
 #define CONFIG_USB_EHCI_TXFIFO_THRESH	10
 #define CONFIG_EHCI_IS_TDI
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 1
 
 /* Total I2C ports on Tegra20 */
 #define TEGRA_I2C_NUM_CONTROLLERS	4
include/configs/tegra30-common.h +1 -0
index 4b6f8d128e63..443c842240ed 100644
@@ -79,5 +79,6 @@
 /* For USB EHCI controller */
 #define CONFIG_EHCI_IS_TDI
 #define CONFIG_USB_EHCI_TXFIFO_THRESH	0x10
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 1
 
 #endif /* _TEGRA30_COMMON_H_ */
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 ARM: tegra: set CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

Quoted 5 lines · Stephen Warren

From: Stephen Warren <[email protected]>

Tegra's EHCI controllers only have a single PORTSC register. Configure U-Boot to know this. This prevents e.g. ehci_shutdown() from touching non-existent registers.

Tom, does this patch look good? It's also needed so that U-Boot can run on our simulator, and I'd really like to get it into 2014.04. Thanks.

#2 lore raw

PATCH 1/1 ARM: tegra: set CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

I'll look at this (and the other two) this afternoon, other work permitting.

Quoted 8 lines

-----Original Message-----
From: Stephen Warren [mailto:swarren at wwwdotorg.org]
Sent: Thursday, February 27, 2014 10:23 AM
To: u-boot at lists.denx.de; Simon Glass; Tom Warren; Stephen Warren
Subject: Re: [U-Boot] [PATCH] ARM: tegra: set CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

On 02/10/2014 01:11 PM, Stephen Warren wrote:

Quoted 8 lines
Quoted 5 lines

From: Stephen Warren <[email protected]>

Tegra's EHCI controllers only have a single PORTSC register. Configure U-Boot to know this. This prevents e.g. ehci_shutdown() from touching non-existent registers.

Tom, does this patch look good? It's also needed so that U-Boot can run on our simulator, and I'd really like to get it into 2014.04. Thanks.

--
nvpublic