Skip to contentSkip to conversation

ARM: dts: Better support for Gumstix Overo

PATCH Superseded Florian Vaussard 2 participants 13 messages Feb 27, 2014 – Mar 3, 2014 Device tree bindings

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: Better support for Gumstix Overo

Hello Tony, Benoit,

This is the second version of my Overo series.
Compared to the first version [1], I decided to split it into three parts:

1) Extend current support for Overo/Tobi boards (this part)
2) Add new expansion boards
3) Add display support based on Tomi's DSS series

I will send 2) and 3) in a couple of days.

Most patches are pretty obvious. Patch 6 adds some specific timings for LAN9221 into a generic file. By using shorter timing, it is possible to double the Ethernet bandwidth. Thus is may interest people using a similar chip.

I tested this series with both the OMAP35xx Overo and the OMAP36xx Overo. Wifi is functional, HSUSB works.

Regards,

Florian

[1] http://thread.gmane.org/gmane.linux.ports.arm.omap/109589

Florian Vaussard (8):
ARM: dts: omap3-tobi: Add missing pinctrl
ARM: dts: omap3-overo: Add missing pinctrl
ARM: dts: omap3-overo: Use complete poweroff
ARM: dts: omap3-overo: Enable WiFi/BT combo
ARM: dts: omap3-overo: Add HSUSB PHY
ARM: dts: omap: Add common file for SMSC9221
ARM: dts: omap3-tobi: Use include file omap-gpmc-smsc9221
ARM: dts: omap3-tobi: Add AT24C01 EEPROM

 arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi      |  58 ++++++++++
 arch/arm/boot/dts/omap3-overo-storm-tobi.dts   |  24 +++++
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi |  48 ++++-----
 arch/arm/boot/dts/omap3-overo-tobi.dts         |  24 +++++
 arch/arm/boot/dts/omap3-overo.dtsi             | 143 +++++++++++++++++++++++--
 5 files changed, 263 insertions(+), 34 deletions(-)
 create mode 100644 arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH v2 1/8 ARM: dts: omap3-tobi: Add missing pinctrl

Add missing pinctrl entries:
- i2c3

---
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/omap3-overo-tobi-common.dtsi +11 -0
index 4edc013..da7d85b 100644
@@ -35,6 +35,15 @@
 	};
 };
 
+&omap3_pmx_core {
+	i2c3_pins: pinmux_i2c3_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x21c2, PIN_INPUT | MUX_MODE0)	/* i2c3_scl.i2c3_scl */
+			OMAP3_CORE1_IOPAD(0x21c4, PIN_INPUT | MUX_MODE0)	/* i2c3_sda.i2c3_sda */
+		>;
+	};
+};
+
 &gpmc {
 	ranges = <5 0 0x2c000000 0x1000000>;	/* CS5 */
 
@@ -72,6 +81,8 @@
 };
 
 &i2c3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c3_pins>;
 	clock-frequency = <100000>;
 };
 
Signature · 1 line
1.8.5.3
#2 lore raw

PATCH v2 2/8 ARM: dts: omap3-overo: Add missing pinctrl

In reply to Florian Vaussard

Add missing pinctrl entries for:
- i2c1
- mmc1

---
 arch/arm/boot/dts/omap3-overo.dtsi | 40 +++++++++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 9 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +31 -9
index 5970999..aea64c0 100644
@@ -31,7 +31,36 @@
 	};
 };
 
+&omap3_pmx_core {
+	uart3_pins: pinmux_uart3_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x219e, PIN_INPUT | PIN_OFF_WAKEUPENABLE | MUX_MODE0)	/* uart3_rx_irrx.uart3_rx_irrx */
+			OMAP3_CORE1_IOPAD(0x21a0, PIN_OUTPUT | MUX_MODE0)		/* uart3_tx_irtx.uart3_tx_irtx */
+		>;
+	};
+
+	i2c1_pins: pinmux_i2c1_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x21ba, PIN_INPUT | MUX_MODE0)		/* i2c1_scl.i2c1_scl */
+			OMAP3_CORE1_IOPAD(0x21bc, PIN_INPUT | MUX_MODE0)		/* i2c1_sda.i2c1_sda */
+		>;
+	};
+
+	mmc1_pins: pinmux_mmc1_pins {
+		pinctrl-single,pins = <
+			OMAP3_CORE1_IOPAD(0x2144, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_clk.sdmmc1_clk */
+			OMAP3_CORE1_IOPAD(0x2146, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_cmd.sdmmc1_cmd */
+			OMAP3_CORE1_IOPAD(0x2148, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_dat0.sdmmc1_dat0 */
+			OMAP3_CORE1_IOPAD(0x214a, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_dat1.sdmmc1_dat1 */
+			OMAP3_CORE1_IOPAD(0x214c, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_dat2.sdmmc1_dat2 */
+			OMAP3_CORE1_IOPAD(0x214e, PIN_INPUT_PULLUP | MUX_MODE0)		/* sdmmc1_dat3.sdmmc1_dat3 */
+		>;
+	};
+};
+
 &i2c1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1_pins>;
 	clock-frequency = <2600000>;
 
 	twl: twl at 48 {
@@ -57,6 +86,8 @@
 
 /* on board microSD slot */
 &mmc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc1_pins>;
 	vmmc-supply = <&vmmc1>;
 	bus-width = <4>;
 };
@@ -79,15 +110,6 @@
 	power = <50>;
 };
 
-&omap3_pmx_core {
-	uart3_pins: pinmux_uart3_pins {
-		pinctrl-single,pins = <
-			0x16e (PIN_INPUT | PIN_OFF_WAKEUPENABLE | MUX_MODE0) /* uart3_rx_irrx.uart3_rx_irrx */
-			0x170 (PIN_OUTPUT | MUX_MODE0) /* uart3_tx_irtx.uart3_tx_irtx */
-		>;
-	};
-};
-
 &uart3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart3_pins>;
Signature · 1 line
1.8.5.3
#3 lore raw

PATCH v2 3/8 ARM: dts: omap3-overo: Use complete poweroff

In reply to Florian Vaussard

Currently, the TWL4030 PMIC does not completely poweroff the processor. Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary binding to do this, so use it.

---
 arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3-overo.dtsi +5 -0
index aea64c0..018e1e0 100644
@@ -73,6 +73,11 @@
 			codec {
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 
Signature · 1 line
1.8.5.3
#4 lore raw

PATCH v2 3/8 ARM: dts: omap3-overo: Use complete poweroff

Quoted 16 lines · Florian Vaussard

Currently, the TWL4030 PMIC does not completely poweroff the processor. Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary binding to do this, so use it.

---
 arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index aea64c0..018e1e0 100644
@@ -73,6 +73,11 @@
 			codec {

arch/arm/boot/dts/omap3-overo.dtsi line 83

Quoted 10 lines
arch/arm/boot/dts/omap3-overo.dtsi +5 -0
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 

Urrgh.. this slipped past.. :(

ti,system-power-controller is traditionally used for other PMICs from TI to indicate that poweroff functionality will be provided by the PMIC driver. similar approach is taken by Maxim as well.. I know the commit introducing the binding has been around for long, but considering that we do not have a single dts using this yet, should we consider adding "ti,system-power-controller"(as against removing ti,use_poweroff - so that older down stream dtbs still work) and using it in the new code?

just proposing here.

Signature · 2 lines
Regards,
Nishanth Menon
#5 lore raw

PATCH v2 3/8 ARM: dts: omap3-overo: Use complete poweroff

Quoted 29 lines · Nishanth Menon
Quoted 16 lines · Florian Vaussard

Currently, the TWL4030 PMIC does not completely poweroff the processor. Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary binding to do this, so use it.

---
 arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index aea64c0..018e1e0 100644
@@ -73,6 +73,11 @@
 			codec {

arch/arm/boot/dts/omap3-overo.dtsi line 83

Quoted 10 lines
arch/arm/boot/dts/omap3-overo.dtsi +5 -0
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 

Urrgh.. this slipped past.. :(

Quoted 9 lines

ti,system-power-controller is traditionally used for other PMICs from TI to indicate that poweroff functionality will be provided by the PMIC driver. similar approach is taken by Maxim as well.. I know the commit introducing the binding has been around for long, but considering that we do not have a single dts using this yet, should we consider adding "ti,system-power-controller"(as against removing ti,use_poweroff - so that older down stream dtbs still work) and using it in the new code?

It does make sense, so I am not against it. My only concern is that I find the name to be slightly less easy to understand, but I can live with it :-)

I do not remember if DT maintainers came up with a clear policy to deprecate a binding.

Regards,
Florian

#6 lore raw

PATCH v2 3/8 ARM: dts: omap3-overo: Use complete poweroff

+devicetree list.

Quoted 40 lines · Florian Vaussard
Quoted 29 lines · Nishanth Menon
Quoted 16 lines · Florian Vaussard

Currently, the TWL4030 PMIC does not completely poweroff the processor. Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary binding to do this, so use it.

---
 arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index aea64c0..018e1e0 100644
@@ -73,6 +73,11 @@
 			codec {

arch/arm/boot/dts/omap3-overo.dtsi line 83

Quoted 10 lines
arch/arm/boot/dts/omap3-overo.dtsi +5 -0
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 

Urrgh.. this slipped past.. :(

Quoted 9 lines

ti,system-power-controller is traditionally used for other PMICs from TI to indicate that poweroff functionality will be provided by the PMIC driver. similar approach is taken by Maxim as well.. I know the commit introducing the binding has been around for long, but considering that we do not have a single dts using this yet, should we consider adding "ti,system-power-controller"(as against removing ti,use_poweroff - so that older down stream dtbs still work) and using it in the new code?

Quoted 3 lines

It does make sense, so I am not against it. My only concern is that I find the name to be slightly less easy to understand, but I can live with it :-)

:)

Quoted 3 lines

I do not remember if DT maintainers came up with a clear policy to deprecate a binding.

I dont think we can depreciate a binding [1] - as you mentioned - renaming the property is probably what is appropriate, but introducing a new one which has the same behavior as the old one does'nt seem covered either.. considering potential downstream kernel usage, I'd suggest additional property inline with today's convention.

[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2a9330010bea5982a5c6593824bc036bf62d67b7

Signature · 2 lines
Regards,
Nishanth Menon
#7 lore raw

PATCH v2 3/8 ARM: dts: omap3-overo: Use complete poweroff

Quoted 49 lines · Nishanth Menon

+devicetree list.

Quoted 40 lines · Florian Vaussard
Quoted 29 lines · Nishanth Menon
Quoted 16 lines · Florian Vaussard

Currently, the TWL4030 PMIC does not completely poweroff the processor. Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary binding to do this, so use it.

---
 arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index aea64c0..018e1e0 100644
@@ -73,6 +73,11 @@
 			codec {

arch/arm/boot/dts/omap3-overo.dtsi line 83

Quoted 10 lines
arch/arm/boot/dts/omap3-overo.dtsi +5 -0
 			};
 		};
+
+		twl_power: power {
+			compatible = "ti,twl4030-power";
+			ti,use_poweroff;
+		};
 	};
 };
 

Urrgh.. this slipped past.. :(

Quoted 9 lines

ti,system-power-controller is traditionally used for other PMICs from TI to indicate that poweroff functionality will be provided by the PMIC driver. similar approach is taken by Maxim as well.. I know the commit introducing the binding has been around for long, but considering that we do not have a single dts using this yet, should we consider adding "ti,system-power-controller"(as against removing ti,use_poweroff - so that older down stream dtbs still work) and using it in the new code?

Quoted 3 lines

It does make sense, so I am not against it. My only concern is that I find the name to be slightly less easy to understand, but I can live with it :-)

:)

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

I do not remember if DT maintainers came up with a clear policy to deprecate a binding.

I dont think we can depreciate a binding [1] - as you mentioned - renaming the property is probably what is appropriate, but introducing a new one which has the same behavior as the old one does'nt seem covered either.. considering potential downstream kernel usage, I'd suggest additional property inline with today's convention.

Ok, so I will drop this patch from the series, so that the other patches can hopefully go into 3.15. I will address this issue separately. Thank you for pointing out this binding issue.

Regards,
Florian

#8 lore raw

PATCH v2 4/8 ARM: dts: omap3-overo: Enable WiFi/BT combo

In reply to Florian Vaussard

MMC2 is used by the on-board WiFi module populated on some boards (based on Marvell Libertas 8688 SDIO). The Bluetooth is connected to UART2.

---
 arch/arm/boot/dts/omap3-overo-storm-tobi.dts |  8 ++++
 arch/arm/boot/dts/omap3-overo-tobi.dts       |  8 ++++
 arch/arm/boot/dts/omap3-overo.dtsi           | 58 ++++++++++++++++++++++++++++
 3 files changed, 74 insertions(+)
arch/arm/boot/dts/omap3-overo-storm-tobi.dts +8 -0
index 966b5c9..2033b52 100644
@@ -20,3 +20,11 @@
 	compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap36xx", "ti,omap3";
 };
 
+&omap3_pmx_core2 {
+	w3cbw003c_2_pins: pinmux_w3cbw003c_2_pins {
+		pinctrl-single,pins = <
+			OMAP3630_CORE2_IOPAD(0x25e0, PIN_OUTPUT | MUX_MODE4)		/* etk_d2.gpio_16 */
+		>;
+	};
+};
+
arch/arm/boot/dts/omap3-overo-tobi.dts +8 -0
index de5653e..21de31d 100644
@@ -20,3 +20,11 @@
 	compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3430", "ti,omap3";
 };
 
+&omap3_pmx_core2 {
+	w3cbw003c_2_pins: pinmux_w3cbw003c_2_pins {
+		pinctrl-single,pins = <
+			OMAP3430_CORE2_IOPAD(0x25e0, PIN_OUTPUT | MUX_MODE4)		/* etk_d2.gpio_16 */
+		>;
+	};
+};
+
arch/arm/boot/dts/omap3-overo.dtsi +58 -0

77 lines not on this page · raw message

Signature · 1 line
1.8.5.3
#9 lore raw

PATCH v2 5/8 ARM: dts: omap3-overo: Add HSUSB PHY

In reply to Florian Vaussard

Add the High-Speed USB PHY.

---
 arch/arm/boot/dts/omap3-overo-storm-tobi.dts | 16 ++++++++++
 arch/arm/boot/dts/omap3-overo-tobi.dts       | 16 ++++++++++
 arch/arm/boot/dts/omap3-overo.dtsi           | 44 ++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+)
arch/arm/boot/dts/omap3-overo-storm-tobi.dts +16 -0
index 2033b52..eb93e3a 100644
@@ -21,6 +21,22 @@
 };
 
 &omap3_pmx_core2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <
+			&hsusb2_2_pins
+	>;
+
+	hsusb2_2_pins: pinmux_hsusb2_2_pins {
+		pinctrl-single,pins = <
+			OMAP3630_CORE2_IOPAD(0x25f0, PIN_OUTPUT | MUX_MODE3)		/* etk_d10.hsusb2_clk */
+			OMAP3630_CORE2_IOPAD(0x25f2, PIN_OUTPUT | MUX_MODE3)		/* etk_d11.hsusb2_stp */
+			OMAP3630_CORE2_IOPAD(0x25f4, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d12.hsusb2_dir */
+			OMAP3630_CORE2_IOPAD(0x25f6, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d13.hsusb2_nxt */
+			OMAP3630_CORE2_IOPAD(0x25f8, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d14.hsusb2_data0 */
+			OMAP3630_CORE2_IOPAD(0x25fa, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d15.hsusb2_data1 */
+		>;
+	};
+
 	w3cbw003c_2_pins: pinmux_w3cbw003c_2_pins {
 		pinctrl-single,pins = <
 			OMAP3630_CORE2_IOPAD(0x25e0, PIN_OUTPUT | MUX_MODE4)		/* etk_d2.gpio_16 */
arch/arm/boot/dts/omap3-overo-tobi.dts +16 -0
index 21de31d..e77be26 100644
@@ -21,6 +21,22 @@
 };
 
 &omap3_pmx_core2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <
+			&hsusb2_2_pins
+	>;
+
+	hsusb2_2_pins: pinmux_hsusb2_2_pins {
+		pinctrl-single,pins = <
+			OMAP3430_CORE2_IOPAD(0x25f0, PIN_OUTPUT | MUX_MODE3)		/* etk_d10.hsusb2_clk */
+			OMAP3430_CORE2_IOPAD(0x25f2, PIN_OUTPUT | MUX_MODE3)		/* etk_d11.hsusb2_stp */
+			OMAP3430_CORE2_IOPAD(0x25f4, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d12.hsusb2_dir */
+			OMAP3430_CORE2_IOPAD(0x25f6, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d13.hsusb2_nxt */
+			OMAP3430_CORE2_IOPAD(0x25f8, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d14.hsusb2_data0 */
+			OMAP3430_CORE2_IOPAD(0x25fa, PIN_INPUT_PULLDOWN | MUX_MODE3)	/* etk_d15.hsusb2_data1 */
+		>;
+	};
+
 	w3cbw003c_2_pins: pinmux_w3cbw003c_2_pins {
 		pinctrl-single,pins = <
 			OMAP3430_CORE2_IOPAD(0x25e0, PIN_OUTPUT | MUX_MODE4)		/* etk_d2.gpio_16 */
arch/arm/boot/dts/omap3-overo.dtsi +44 -0

68 lines not on this page · raw message

Signature · 1 line
1.8.5.3
#10 lore raw

PATCH v2 6/8 ARM: dts: omap: Add common file for SMSC9221

In reply to Florian Vaussard

Some devices (SMSC9217, SMSC9218 and SMSC9221 at least) have better timings, allowing a higher transfer speed. Create a common file with these timings.

Performance results with iperf:

- omap-gpmc-smsc911x.dtsi => 54.9 Mbps
- omap-gpmc-smsc9221.dtsi => 92.7 Mbps

---
 arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi | 58 +++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi
arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi new file +58 -0
new file mode 100644
index 0000000..73e272f
@@ -0,0 +1,58 @@
+/*
+ * Common file for GPMC connected smsc9221 on omaps
+ *
+ * Compared to smsc911x, smsc9221 (and others like smsc9217
+ * or smsc 9218) has faster timings, leading to higher
+ * bandwidth.
+ *
+ * Note that the board specifc DTS file needs to specify
+ * ranges, pinctrl, reg, interrupt parent and interrupts.
+ */
+
+/ {
+	vddvario: regulator-vddvario {
+		  compatible = "regulator-fixed";
+		  regulator-name = "vddvario";
+		  regulator-always-on;
+	};
+
+	vdd33a: regulator-vdd33a {
+		compatible = "regulator-fixed";
+		regulator-name = "vdd33a";
+		regulator-always-on;
+	};
+};
+
+&gpmc {
+	ethernet at gpmc {
+		compatible = "smsc,lan9221","smsc,lan9115";
+		bank-width = <2>;
+
+		gpmc,mux-add-data;
+		gpmc,cs-on-ns = <0>;
+		gpmc,cs-rd-off-ns = <42>;
+		gpmc,cs-wr-off-ns = <36>;
+		gpmc,adv-on-ns = <6>;
+		gpmc,adv-rd-off-ns = <12>;
+		gpmc,adv-wr-off-ns = <12>;
+		gpmc,oe-on-ns = <0>;
+		gpmc,oe-off-ns = <42>;
+		gpmc,we-on-ns = <0>;
+		gpmc,we-off-ns = <36>;
+		gpmc,rd-cycle-ns = <60>;
+		gpmc,wr-cycle-ns = <54>;
+		gpmc,access-ns = <36>;
+		gpmc,page-burst-access-ns = <0>;
+		gpmc,bus-turnaround-ns = <0>;
+		gpmc,cycle2cycle-delay-ns = <0>;
+		gpmc,wr-data-mux-bus-ns = <18>;
+		gpmc,wr-access-ns = <42>;
+		gpmc,cycle2cycle-samecsen;
+		gpmc,cycle2cycle-diffcsen;
+
+		vddvario-supply = <&vddvario>;
+		vdd33a-supply = <&vdd33a>;
+		reg-io-width = <4>;
+		smsc,save-mac-address;
+	};
+};
Signature · 1 line
1.8.5.3
#11 lore raw

PATCH v2 7/8 ARM: dts: omap3-tobi: Use include file omap-gpmc-smsc9221

In reply to Florian Vaussard

Use the timings provided by omap-gpmc-smsc9221. This does not change the timings, but it avoids code duplication.

---
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi | 30 +++-----------------------
 1 file changed, 3 insertions(+), 27 deletions(-)
arch/arm/boot/dts/omap3-overo-tobi-common.dtsi +3 -27
index da7d85b..caddb8c 100644
@@ -44,39 +44,15 @@
 	};
 };
 
+#include "omap-gpmc-smsc9221.dtsi"
+
 &gpmc {
 	ranges = <5 0 0x2c000000 0x1000000>;	/* CS5 */
 
-	ethernet at 5,0 {
-		compatible = "smsc,lan9221", "smsc,lan9115";
+	ethernet at gpmc {
 		reg = <5 0 0xff>;
-		bank-width = <2>;
-
-		gpmc,mux-add-data;
-		gpmc,cs-on-ns = <0>;
-		gpmc,cs-rd-off-ns = <42>;
-		gpmc,cs-wr-off-ns = <36>;
-		gpmc,adv-on-ns = <6>;
-		gpmc,adv-rd-off-ns = <12>;
-		gpmc,adv-wr-off-ns = <12>;
-		gpmc,oe-on-ns = <0>;
-		gpmc,oe-off-ns = <42>;
-		gpmc,we-on-ns = <0>;
-		gpmc,we-off-ns = <36>;
-		gpmc,rd-cycle-ns = <60>;
-		gpmc,wr-cycle-ns = <54>;
-		gpmc,access-ns = <36>;
-		gpmc,page-burst-access-ns = <0>;
-		gpmc,bus-turnaround-ns = <0>;
-		gpmc,cycle2cycle-delay-ns = <0>;
-		gpmc,wr-data-mux-bus-ns = <18>;
-		gpmc,wr-access-ns = <42>;
-		gpmc,cycle2cycle-samecsen;
-		gpmc,cycle2cycle-diffcsen;
-
 		interrupt-parent = <&gpio6>;
 		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;	/* GPIO 176 */
-		reg-io-width = <4>;
 	};
 };
 
Signature · 1 line
1.8.5.3
#12 lore raw

PATCH v2 8/8 ARM: dts: omap3-tobi: Add AT24C01 EEPROM

In reply to Florian Vaussard

Add the AT24C01 EEPROM node populated on most Gumstix expansion board.

---
 arch/arm/boot/dts/omap3-overo-tobi-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/omap3-overo-tobi-common.dtsi +7 -0
index caddb8c..b5e1b15 100644
@@ -60,6 +60,13 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c3_pins>;
 	clock-frequency = <100000>;
+
+	/* optional 1K EEPROM with revision information */
+	eeprom at 51 {
+		compatible = "atmel,24c01";
+		reg = <0x51>;
+		pagesize = <8>;
+	};
 };
 
 &mmc3 {
Signature · 1 line
1.8.5.3