bluetooth: ath3k: added Atheros AR3012 with ID 0x0b05:0x17d0

PATCH In review Bela Hausmann 2 participants 5 messages Feb 27, 2014 – Feb 28, 2014 Bluetooth drivers

lore

Share & tools

lore

Bela Hausmann

author

2014-02-27 21:40 UTC #0 lore raw

PATCH 1/1 bluetooth: ath3k: added Atheros AR3012 with ID 0x0b05:0x17d0

This adds support for the Atheros AR3012 chipset on the ASUS Z87-Pro (C2) mainboard (ID 0x0b05:0x17d0).

Signed-off-by Bela Hausmann <[email protected]>

---

drivers/bluetooth/ath3k.c 2014-02-27 20:09:33.047878117 +0100 renamed from drivers/bluetooth/ath3k.c 2014-01-20 03:40:07.000000000 +0100 +2 -0

diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/ath3k.c linux-3.13.5-gentoo-bela/drivers/bluetooth/ath3k.c
@@ -97,6 +97,7 @@ static const struct usb_device_id ath3k_
     { USB_DEVICE(0x13d3, 0x3402) },
     { USB_DEVICE(0x0cf3, 0x3121) },
     { USB_DEVICE(0x0cf3, 0xe003) },
+    { USB_DEVICE(0x0b05, 0x17d0) },
 
     /* Atheros AR5BBU12 with sflash firmware */
     { USB_DEVICE(0x0489, 0xE02C) },

@@ -140,6 +141,7 @@ static const struct usb_device_id ath3k_
     { USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
     { USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
     { USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
+    { USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
 
     /* Atheros AR5BBU22 with sflash firmware */
     { USB_DEVICE(0x0489, 0xE03C), .driver_info = BTUSB_ATH3012 },

drivers/bluetooth/btusb.c 2014-02-27 20:10:20.825905643 +0100 renamed from drivers/bluetooth/btusb.c 2014-01-20 03:40:07.000000000 +0100 +1 -0

diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/btusb.c linux-3.13.5-gentoo-bela/drivers/bluetooth/btusb.c
@@ -164,6 +164,7 @@ static const struct usb_device_id blackl
     { USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
     { USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
     { USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
+    { USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
 
     /* Atheros AR5BBU12 with sflash firmware */
     { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },

Marcel Holtmann

maintainer

2014-02-27 22:43 UTC #1 lore raw

Hi Bela,

Quoted 1 line

This adds support for the Atheros AR3012 chipset on the ASUS Z87-Pro (C2) mainboard (ID 0x0b05:0x17d0).

include the content of /sys/kernel/debug/usb/devices for this controller.

drivers/bluetooth/ath3k.c 2014-02-27 20:09:33.047878117 +0100 static const struct usb_device_id ath3k_ · line 100

Quoted 11 lines

Signed-off-by Bela Hausmann <[email protected]>
---
diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/ath3k.c linux-3.13.5-gentoo-bela/drivers/bluetooth/ath3k.c
drivers/bluetooth/ath3k.c 2014-02-27 20:09:33.047878117 +0100 renamed from drivers/bluetooth/ath3k.c 2014-01-20 03:40:07.000000000 +0100 +1 -0
@@ -97,6 +97,7 @@ static const struct usb_device_id ath3k_
    { USB_DEVICE(0x13d3, 0x3402) },
    { USB_DEVICE(0x0cf3, 0x3121) },
    { USB_DEVICE(0x0cf3, 0xe003) },
+    { USB_DEVICE(0x0b05, 0x17d0) },

Make sure that you email client does not screw up tabs. This looks pretty much like it is messed up.

Regards

Marcel

Bela Hausmann

author

2014-02-27 22:54 UTC #2 lore raw

Hi Marcel,

sorry for the messed up tabs.

Here is /sys/kernel/debug/usb/devices:

T:  Bus=02 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#=  4 Spd=12   MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17d0 Rev= 0.02
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

An again the patch.

Best wishes,
Bela

This adds support for the Atheros AR3012 chipset on the ASUS Z87-Pro (C2) mainboard (ID 0x0b05:0x17d0).

Signed-off-by Bela Hausmann <[email protected]>

---

drivers/bluetooth/ath3k.c +2 -0

diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/ath3k.c linux-3.13.5-gentoo-bela/drivers/bluetooth/ath3k.c
@@ -97,6 +97,7 @@ static const struct usb_device_id ath3k_
 	{ USB_DEVICE(0x13d3, 0x3402) },
 	{ USB_DEVICE(0x0cf3, 0x3121) },
 	{ USB_DEVICE(0x0cf3, 0xe003) },
+	{ USB_DEVICE(0x0b05, 0x17d0) },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xE02C) },

@@ -140,6 +141,7 @@ static const struct usb_device_id ath3k_
 	{ USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU22 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xE03C), .driver_info = BTUSB_ATH3012 },

drivers/bluetooth/btusb.c +1 -0

diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/btusb.c linux-3.13.5-gentoo-bela/drivers/bluetooth/btusb.c
@@ -164,6 +164,7 @@ static const struct usb_device_id blackl
 	{ USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
 
 	/* Atheros AR5BBU12 with sflash firmware */
 	{ USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },

Quoted 25 lines · Marcel Holtmann

Hi Bela,
Quoted 1 line
This adds support for the Atheros AR3012 chipset on the ASUS Z87-Pro (C2) mainboard (ID 0x0b05:0x17d0).
include the content of /sys/kernel/debug/usb/devices for this controller.
drivers/bluetooth/ath3k.c 2014-02-27 20:09:33.047878117 +0100 static const struct usb_device_id ath3k_ · line 100
Quoted 11 lines
Signed-off-by Bela Hausmann <[email protected]>
---
diff -uprN -X linux-3.13.5-gentoo/Documentation/dontdiff linux-3.13.5-gentoo/drivers/bluetooth/ath3k.c linux-3.13.5-gentoo-bela/drivers/bluetooth/ath3k.c
drivers/bluetooth/ath3k.c 2014-02-27 20:09:33.047878117 +0100 renamed from drivers/bluetooth/ath3k.c 2014-01-20 03:40:07.000000000 +0100 +1 -0
@@ -97,6 +97,7 @@ static const struct usb_device_id ath3k_
    { USB_DEVICE(0x13d3, 0x3402) },
    { USB_DEVICE(0x0cf3, 0x3121) },
    { USB_DEVICE(0x0cf3, 0xe003) },
+    { USB_DEVICE(0x0b05, 0x17d0) },
Make sure that you email client does not screw up tabs. This looks pretty much like it is messed up.
Regards
Marcel

Marcel Holtmann

maintainer

2014-02-27 23:19 UTC #3 lore raw

Hi Bela,

Quoted 32 lines

Hi Marcel,

sorry for the messed up tabs.

Here is /sys/kernel/debug/usb/devices:

T:  Bus=02 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#=  4 Spd=12   MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=0b05 ProdID=17d0 Rev= 0.02
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

Quoted 4 lines

An again the patch.
Best wishes,
Bela

why don’t you use git-format-patch and git-send-email. Just save the email you send as raw text and see what happens if you apply it with git-am and then look at git-log.

Regards

Marcel

Bela Hausmann

author

2014-02-28 20:26 UTC #4 lore raw

Hi Marcel,

I would, but I just now noticed that you already added this device ID a few days ago in commit a735f9e22432899cee188d167966782c29246390 to linux-next [1]. Thank you!

Best wishes,
Bela

[1] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit=
/drivers/bluetooth?id=3Da735f9e22432899cee188d167966782c29246390

2014-02-28 0:19 GMT+01:00 Marcel Holtmann <[email protected]>:

Quoted 8 lines

Hi Bela,
Quoted 6 lines
Hi Marcel,
sorry for the messed up tabs.
Here is /sys/kernel/debug/usb/devices:
T: Bus=3D02 Lev=3D02 Prnt=3D02 Port=3D03 Cnt=3D02 Dev#=3D 4 Spd=3D12 =

MxCh=3D 0

Quoted 4 lines

Quoted 4 lines
D:  Ver=3D 1.10 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 MxPS=3D64 #Cfgs=3D  1
P:  Vendor=3D0b05 ProdID=3D17d0 Rev=3D 0.02
C:* #Ifs=3D 2 Cfg#=3D 1 Atr=3De0 MxPwr=3D100mA
I:* If#=3D 0 Alt=3D 0 #EPs=3D 3 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 4 lines

Quoted 4 lines
E:  Ad=3D81(I) Atr=3D03(Int.) MxPS=3D  16 Ivl=3D1ms
E:  Ad=3D82(I) Atr=3D02(Bulk) MxPS=3D  64 Ivl=3D0ms
E:  Ad=3D02(O) Atr=3D02(Bulk) MxPS=3D  64 Ivl=3D0ms
I:* If#=3D 1 Alt=3D 0 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 3 lines

E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D   0 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D   0 Ivl=3D1ms
I:  If#=3D 1 Alt=3D 1 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 3 lines

E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D   9 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D   9 Ivl=3D1ms
I:  If#=3D 1 Alt=3D 2 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 3 lines

E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D  17 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D  17 Ivl=3D1ms
I:  If#=3D 1 Alt=3D 3 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 3 lines

E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D  25 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D  25 Ivl=3D1ms
I:  If#=3D 1 Alt=3D 4 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 3 lines

E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D  33 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D  33 Ivl=3D1ms
I:  If#=3D 1 Alt=3D 5 #EPs=3D 2 Cls=3De0(wlcon) Sub=3D01 Prot=3D01 Drive=

r=3Dbtusb

Quoted 9 lines

Quoted 7 lines
E:  Ad=3D83(I) Atr=3D01(Isoc) MxPS=3D  49 Ivl=3D1ms
E:  Ad=3D03(O) Atr=3D01(Isoc) MxPS=3D  49 Ivl=3D1ms
An again the patch.
Best wishes,
Bela
why don=E2=80=99t you use git-format-patch and git-send-email. Just save =

the email you send as raw text and see what happens if you apply it with gi= t-am and then look at git-log.

Quoted 5 lines

Regards
Marcel