mmc: dw_mmc: replace the bus_hz checking point
Subsystems (2)
Jaehoon Chung
maintainerPATCH v4 2/7 mmc: dw_mmc: replace the bus_hz checking point
It's right that check immediately whether host->bus_hz is assigned or not.
Signed-off-by Jaehoon Chung <[email protected]>
---
Changelog V4:
- Fixed the compile warning.
Changelog V3:
- Maintained original place for the drv_data->setup_clock
Changelog V2:
- When drv_data->setup_clock is present, set to bus_hz with it.
drivers/mmc/host/dw_mmc.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)
drivers/mmc/host/dw_mmc.c +8 -10
@@ -2427,12 +2427,19 @@ int dw_mci_probe(struct dw_mci *host) ret =clk_set_rate (host->ciu_clk, host->pdata->bus_hz);if (ret)dev_warn (host->dev, -"Unable to set bus rate to %ul\n" , +"Unable to set bus rate to %uHz\n" , host->pdata->bus_hz); } host->bus_hz =clk_get_rate (host->ciu_clk); } +if (!host->bus_hz) { +dev_err (host->dev, +"Platform data must supply bus speed\n" ); + ret = -ENODEV ; + goto err_clk_ciu; + } +if (drv_data && drv_data->init) { ret = drv_data->init (host);if (ret) {
@@ -2469,13 +2476,6 @@ int dw_mci_probe(struct dw_mci *host) } } -if (!host->bus_hz) { -dev_err (host->dev, -"Platform data must supply bus speed\n" ); - ret = -ENODEV ; - goto err_regulator; - } - host->quirks = host->pdata->quirks;spin_lock_init (&host->lock);
@@ -2619,8 +2619,6 @@ err_workqueue: err_dmaunmap:if (host->use_dma && host->dma_ops->exit) host->dma_ops->exit (host); - -err_regulator:if (host->vmmc)regulator_disable (host->vmmc);
Signature · 1 line
1.7.9.5
Quoted 3 lines · Jaehoon Chung
It's right that check immediately whether
host->bus_hzis assigned or not.Signed-off-by Jaehoon Chung <[email protected]>
Acked-by Ulf Hansson <[email protected]>
Quoted 61 lines
---
Changelog V4:
- Fixed the compile warning.
Changelog V3:
- Maintained original place for thedrv_data->setup_clock
Changelog V2:
- Whendrv_data->setup_clockis present, set tobus_hzwith it.drivers/mmc/host/dw_mmc.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-)drivers/mmc/host/dw_mmc.c +8
-11@@ -2427,12 +2427,19 @@ int dw_mci_probe(struct dw_mci *host) ret =clk_set_rate (host->ciu_clk, host->pdata->bus_hz);if (ret)dev_warn (host->dev, -"Unable to set bus rate to %ul\n" , +"Unable to set bus rate to %uHz\n" , host->pdata->bus_hz); } host->bus_hz =clk_get_rate (host->ciu_clk); } +if (!host->bus_hz) { +dev_err (host->dev, +"Platform data must supply bus speed\n" ); + ret = -ENODEV ; + goto err_clk_ciu; + } +if (drv_data && drv_data->init) { ret = drv_data->init (host);if (ret) {@@ -2469,13 +2476,6 @@ int dw_mci_probe(struct dw_mci *host) } } -if (!host->bus_hz) { -dev_err (host->dev, -"Platform data must supply bus speed\n" ); - ret = -ENODEV ; - goto err_regulator; - } - host->quirks = host->pdata->quirks;spin_lock_init (&host->lock);@@ -2619,8 +2619,6 @@ err_workqueue: err_dmaunmap:if (host->use_dma && host->dma_ops->exit) host->dma_ops->exit (host); - -err_regulator:if (host->vmmc)regulator_disable (host->vmmc); --1.7.9.5