Skip to contentSkip to conversation

toolchain/wrapper: rename BR_DEBUG_WRAPPER

PATCH New Yann E. MORIN 3 participants 3 messages Mar 3, 2014 – Mar 5, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/wrapper: rename BR_DEBUG_WRAPPER

From: "Yann E. MORIN" <[email protected]>

The user-facing variables should be prefixed with BR2_, not BR_.

Also quote the variable in the manual.

Cc Thomas Petazzoni <[email protected]>
---
 docs/manual/customize-toolchain.txt                  | 2 +-
 toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/manual/customize-toolchain.txt +1 -1
index 4f3fe23..55a0480 100644
@@ -21,7 +21,7 @@ When using an external toolchain, Buildroot generates a wrapper program,
 that transparently passes the appropriate options (according to the
 configuration) to the external toolchain programs. In case you need to
 debug this wrapper to check exactly what arguments are passed, you can
-set the environment variable BR_DEBUG_WRAPPER to either one of:
+set the environment variable +BR2_DEBUG_WRAPPER+ to either one of:
 
 * +0+, empty or not set: no debug
 
toolchain/toolchain-external/ext-toolchain-wrapper.c +1 -1
index 81c6ed1..db49784 100644
@@ -191,7 +191,7 @@ int main(int argc, char **argv)
 	 * set to 1          : trace all arguments on a single line
 	 * set to 2          : trace one argument per line
 	 */
-	if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
+	if ((env_debug = getenv("BR2_DEBUG_WRAPPER"))) {
 		debug = atoi(env_debug);
 		if (debug > 0) {
 			fprintf(stderr, "Toolchain wrapper executing:");
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 toolchain/wrapper: rename BR_DEBUG_WRAPPER

Quoted 8 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

The user-facing variables should be prefixed with BR2_, not BR_.

Also quote the variable in the manual.

Cc Thomas Petazzoni <[email protected]>

Regards,
Arnout

Quoted 32 lines
---
 docs/manual/customize-toolchain.txt                  | 2 +-
 toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
docs/manual/customize-toolchain.txt +1 -1
index 4f3fe23..55a0480 100644
@@ -21,7 +21,7 @@ When using an external toolchain, Buildroot generates a wrapper program,
 that transparently passes the appropriate options (according to the
 configuration) to the external toolchain programs. In case you need to
 debug this wrapper to check exactly what arguments are passed, you can
-set the environment variable BR_DEBUG_WRAPPER to either one of:
+set the environment variable +BR2_DEBUG_WRAPPER+ to either one of:
 
 * +0+, empty or not set: no debug
 
toolchain/toolchain-external/ext-toolchain-wrapper.c +1 -1
index 81c6ed1..db49784 100644
@@ -191,7 +191,7 @@ int main(int argc, char **argv)
 	 * set to 1          : trace all arguments on a single line
 	 * set to 2          : trace one argument per line
 	 */
-	if ((env_debug = getenv("BR_DEBUG_WRAPPER"))) {
+	if ((env_debug = getenv("BR2_DEBUG_WRAPPER"))) {
 		debug = atoi(env_debug);
 		if (debug > 0) {
 			fprintf(stderr, "Toolchain wrapper executing:");
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 toolchain/wrapper: rename BR_DEBUG_WRAPPER

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 4 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

The user-facing variables should be prefixed with BR2_, not BR_.

Quoted 8 lines

Also quote the variable in the manual.

Cc Thomas Petazzoni <[email protected]>
---
 docs/manual/customize-toolchain.txt                  | 2 +-
 toolchain/toolchain-external/ext-toolchain-wrapper.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com