Skip to contentSkip to conversation

Too much memory consumption by powertop

Powertop Alexandra Yates 1 participant 1 message Apr 29, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Alexandra Yates

author
#1 lore raw
Quoted 58 lines

At Tue, 28 Apr 2015 10:14:17 -0700 (PDT),

Quoted 44 lines · Alexandra Yates
Quoted 44 lines

As powertop list is for subscribers only, here Takashi's findings concerning a big memory waste fowarded:

---------- Forwarded Message ----------

Subject: Too much memory consumption by powertop
Date: Tuesday, April 28, 2015, 05:32:41 PM
From: Takashi Iwai <tiwai(a)suse.de>
To: powertop(a)lists.01.org
CC: trenn(a)suse.de

Hi,

I noticed that powertop consumes way too much memory than needed. It constantly takes over 170MB RES, sometimes over 200MB.

Then I looked at profile, and it showed that most of memory is allocated for newpad_sp(). Indeed, the current code allocates a pad of the fixed size of 1000x1000 (!) for each tab, and we have five tabs, so five times of that. No wonder that such a small neat CUI program is so hungry.

For example, a hack like below already reduces the memory footprint to around 20MB, 90% cut. Not bad.

src/display.cpp +1 -1
@@ -48,7 +48,7 @@ void create_tab(const string &name, cons
        if (!w)
                w = new(class tab_window);
 
-       w->win = newpad(1000,1000);
+       w->win = newpad(80,160); // XXX FIXME XXX
        tab_names.push_back(name);
        tab_windows[name] = w;
        tab_translations[name] = translation;

Can anyone look into this and give a better / smarter solution?

thanks,

Quoted 10 lines
Quoted 7 lines

Takashi
-----------------------------------------
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop

To avoid the high memory consumption on testing run it on HTML mode so that the powertop.html report is generated in the background.

Quoted 5 lines

Yeah, starting firefox is smaller than powertop, indeed :)

Takashi

Now if you really want save resources you could go by having your output on a .txt file.

Thank you,
Alexandra.