Cleanups and fix for video/pxa3xx-gcu
cover Cleanups and fix for video/pxa3xx-gcu
Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually a real bugfix that is needed since the misc code doesn't set file->private_data for us implicitly anymore.
The rest are just straight-forward cleanups.
Thanks,
Daniel
Daniel Mack (4):
video: pxa3xx-gcu: rename some symbols
video: pxa3xx-gcu: pass around struct device *
video: pxa3xx-gcu: provide an empty .open call
video: pxa3xx-gcu: switch to devres functions
drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 110 deletions(-)
Signature · 1 line
1.8.5.3
Quoted 16 lines · Daniel Mack
Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually a real bugfix that is needed since the misc code doesn't set
file->private_datafor us implicitly anymore.The rest are just straight-forward cleanups.
Thanks,
DanielDaniel Mack (4):
video: pxa3xx-gcu: rename some symbols
video: pxa3xx-gcu: pass around struct device *
video: pxa3xx-gcu: provide an empty .open call
video: pxa3xx-gcu: switch to devres functions
Quoted 6 lines
drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 110 deletions(-)--
1.8.5.3
Quoted 17 lines · Haojian Zhuang
Quoted 16 lines · Daniel Mack
Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually a real bugfix that is needed since the misc code doesn't set
file->private_datafor us implicitly anymore.The rest are just straight-forward cleanups.
Thanks,
DanielDaniel Mack (4):
video: pxa3xx-gcu: rename some symbols
video: pxa3xx-gcu: pass around struct device *
video: pxa3xx-gcu: provide an empty .open call
video: pxa3xx-gcu: switch to devres functions
Quoted 5 lines
Quoted 3 lines
drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 110 deletions(-)Acked-by Haojian Zhuang <[email protected]>
Thanks Haojian!
Given that this driver doesn't actually have any connection points to the framebuffer or video subsystem (despite its location) maybe you can just take these patches through your pxa tree? It's a PXA3xx specific device, after all. Jean-Christophe, Tomi - any objections?
The driver is also broken since awhile, and the fact that nobody noticed tells me that our platform is most probably the only real user.
Thanks,
Daniel
Quoted 22 lines · Daniel Mack
Quoted 20 lines · Haojian Zhuang
Quoted 19 lines · Daniel Mack
Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually a real bugfix that is needed since the misc code doesn't set
file->private_datafor us implicitly anymore.The rest are just straight-forward cleanups.
Thanks,
DanielDaniel Mack (4):
video: pxa3xx-gcu: rename some symbols
video: pxa3xx-gcu: pass around struct device *
video: pxa3xx-gcu: provide an empty .open call
video: pxa3xx-gcu: switch to devres functionsdrivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 110 deletions(-)
Quoted 9 lines
Quoted 1 line
Acked-by Haojian Zhuang <[email protected]>Thanks Haojian!
Given that this driver doesn't actually have any connection points to the framebuffer or video subsystem (despite its location) maybe you can just take these patches through your pxa tree? It's a PXA3xx specific device, after all. Jean-Christophe, Tomi - any objections?
If Jean or Tomi acked on this series, I can merge them into my pxa tree.
Best Regards
Haojian
Quoted 26 lines · Daniel Mack
Quoted 17 lines · Haojian Zhuang
Quoted 16 lines · Daniel Mack
Here are some cleanups for the pxa3xx-gcu driver. Patch 3/4 is actually a real bugfix that is needed since the misc code doesn't set
file->private_datafor us implicitly anymore.The rest are just straight-forward cleanups.
Thanks,
DanielDaniel Mack (4):
video: pxa3xx-gcu: rename some symbols
video: pxa3xx-gcu: pass around struct device *
video: pxa3xx-gcu: provide an empty .open call
video: pxa3xx-gcu: switch to devres functionsQuoted 5 lines
Quoted 3 lines
drivers/video/pxa3xx-gcu.c | 191 +++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 110 deletions(-)Acked-by Haojian Zhuang <[email protected]>Thanks Haojian!
Quoted 7 lines
Given that this driver doesn't actually have any connection points to the framebuffer or video subsystem (despite its location) maybe you can just take these patches through your pxa tree? It's a PXA3xx specific device, after all. Jean-Christophe, Tomi - any objections?
The driver is also broken since awhile, and the fact that nobody noticed tells me that our platform is most probably the only real user.
If these do not have any dependencies to non-fbdev patches, and nothing else has dependencies to these patches, I'd rather take them via fbdev tree, based on the file location. There shouldn't be any conflicts, but just in case...
As a side note, I've got a drivers/video/ reorg patch series, possibly headed for v3.15, which moves the pxa3xx-gcu file to drivers/video/fbdev/. That's clearly not the right place for it, but I think it's easier to move it along the other files, and later move it back to drivers/video/.
Tomi
Quoted 7 lines · Tomi Valkeinen
Quoted 5 lines · Daniel Mack
Given that this driver doesn't actually have any connection points to the framebuffer or video subsystem (despite its location) maybe you can just take these patches through your pxa tree? It's a PXA3xx specific device, after all. Jean-Christophe, Tomi - any objections?
Quoted 7 lines
Quoted 2 lines
The driver is also broken since awhile, and the fact that nobody noticed tells me that our platform is most probably the only real user.
If these do not have any dependencies to non-fbdev patches, and nothing else has dependencies to these patches, I'd rather take them via fbdev tree, based on the file location. There shouldn't be any conflicts, but just in case...
Ok for me. I really don't mind :)
Quoted 3 lines
As a side note, I've got a
drivers/video/reorg patch series, possibly headed for v3.15, which moves the pxa3xx-gcu file todrivers/video/fbdev/.
Ah, ok. So then they really better go via your tree then.
Quoted 3 lines
That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it back todrivers/video/.
Maybe it might be worth adding a subdirectory for hardware accelerators? Because this is what the pxa3xx-gcu thing is all about really. And it's only a tiny transport layer that passed commands between the hardware block and a DirectFB userspace driver.
Thanks,
Daniel
Quoted 5 lines · Daniel Mack
Quoted 3 lines
As a side note, I've got a
drivers/video/reorg patch series, possibly headed for v3.15, which moves the pxa3xx-gcu file todrivers/video/fbdev/.Ah, ok. So then they really better go via your tree then.
Git should handle it fine, so it's not mandatory here. Still, I'd rather have them via fbdev tree.
Quoted 8 lines
Quoted 3 lines
That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it back todrivers/video/.Maybe it might be worth adding a subdirectory for hardware accelerators? Because this is what the pxa3xx-gcu thing is all about really. And it's only a tiny transport layer that passed commands between the hardware block and a DirectFB userspace driver.
Well, there's drivers/gpu/. It sounds like a good match, and by "sounds" I mean the word "gpu" sounds like a good match. I'm not sure if other people have opinions on what drivers/gpu/ should contain, though.
Tomi
Quoted 6 lines · Tomi Valkeinen
Quoted 4 lines · Daniel Mack
Quoted 3 lines
That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it back todrivers/video/.
Quoted 8 lines
Quoted 4 lines
Maybe it might be worth adding a subdirectory for hardware accelerators? Because this is what the pxa3xx-gcu thing is all about really. And it's only a tiny transport layer that passed commands between the hardware block and a DirectFB userspace driver.
Well, there's
drivers/gpu/. It sounds like a good match, and by "sounds" I mean the word "gpu" sounds like a good match. I'm not sure if other people have opinions on whatdrivers/gpu/should contain, though.
Yes, you're right. Do you think we should do that in a 2nd step maybe, after 3.15?
Daniel
Tomi Valkeinen
AppliedQuoted 7 lines · Daniel Mack
Quoted 6 lines · Tomi Valkeinen
Quoted 4 lines · Daniel Mack
Quoted 3 lines
That's clearly not the right place for it, but I
think it's easier to move it along the other files, and later move it back todrivers/video/.
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Maybe it might be worth adding a subdirectory for hardware accelerators? Because this is what the pxa3xx-gcu thing is all about really. And it's only a tiny transport layer that passed commands between the hardware block and a DirectFB userspace driver.
Well, there's
drivers/gpu/. It sounds like a good match, and by "sounds" I mean the word "gpu" sounds like a good match. I'm not sure if other people have opinions on whatdrivers/gpu/should contain, though.
I have applied this series to fbdev tree for 3.15.
Quoted 2 lines
Yes, you're right. Do you think we should do that in a 2nd step maybe, after 3.15?
Maybe. Then again, drivers/video is not so bad a location, after fbdev stuff has been moved to drivers/video/fbdev/. drivers/gpu doesn't seem to have a specific maintainer, but I guess that goes through drm maintainer.
Tomi