gst1-plugins-bad: add missing opencv ml module dependency

PATCH New Samuel Martin 3 participants 6 messages Mar 5, 2014 – Mar 6, 2014

Share & tools

Samuel Martin

author

2014-03-05 22:55 UTC #0 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.

However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.

Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.

Fixes:
http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/

Signed-off-by Samuel Martin <[email protected]>

---
 package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
 1 file changed, 1 insertion(+)

package/gstreamer1/gst1-plugins-bad/Config.in +1 -0

index 0685322..2c5c290 100644
@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
 	select BR2_PACKAGE_OPENCV_LIB_FLANN
 	select BR2_PACKAGE_OPENCV_LIB_IMGPROC
 	select BR2_PACKAGE_OPENCV_LIB_LEGACY
+	select BR2_PACKAGE_OPENCV_LIB_ML
 	select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
 	select BR2_PACKAGE_OPENCV_LIB_VIDEO
 	help

Signature · 1 line

1.9.0

Vicente Olivert Riera

2014-03-06 09:57 UTC #1 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

Quoted 24 lines · Samuel Martin

gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.
Fixes:
   http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by Samuel Martin <[email protected]>
---
  package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/gstreamer1/gst1-plugins-bad/Config.in +0 -0
index 0685322..2c5c290 100644

package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV · line 440

Quoted 7 lines

package/gstreamer1/gst1-plugins-bad/Config.in +1 -0

@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
  	select BR2_PACKAGE_OPENCV_LIB_FLANN
  	select BR2_PACKAGE_OPENCV_LIB_IMGPROC
  	select BR2_PACKAGE_OPENCV_LIB_LEGACY
+	select BR2_PACKAGE_OPENCV_LIB_ML
  	select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
  	select BR2_PACKAGE_OPENCV_LIB_VIDEO
  	help

Maybe your BR tree wasn't up to date in the moment to write this patch. Look at this:

http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce

Signature · 1 line

Vincent

Thomas Petazzoni

2014-03-06 10:31 UTC #2 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

Dear Vicente Olivert Riera,

Quoted 36 lines · Vicente Olivert Riera

Quoted 24 lines · Samuel Martin
gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.
Fixes:
   http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by Samuel Martin <[email protected]>
---
  package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/gstreamer1/gst1-plugins-bad/Config.in +0 -0
index 0685322..2c5c290 100644
package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV · line 440
Quoted 7 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1 -0
@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
  	select BR2_PACKAGE_OPENCV_LIB_FLANN
  	select BR2_PACKAGE_OPENCV_LIB_IMGPROC
  	select BR2_PACKAGE_OPENCV_LIB_LEGACY
+	select BR2_PACKAGE_OPENCV_LIB_ML
  	select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
  	select BR2_PACKAGE_OPENCV_LIB_VIDEO
  	help
Maybe your BR tree wasn't up to date in the moment to write this patch. Look at this:

Quoted 1 line

http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce

And? Samuel is just adding one more line here, in addition to the lines you added in the commit you're pointing at.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Vicente Olivert Riera

2014-03-06 10:34 UTC #3 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

Quoted 39 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,
Quoted 36 lines · Vicente Olivert Riera
Quoted 24 lines · Samuel Martin
gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.
Fixes:
    http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by Samuel Martin <[email protected]>
---
   package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
   1 file changed, 1 insertion(+)
package/gstreamer1/gst1-plugins-bad/Config.in +0 -0
index 0685322..2c5c290 100644
package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV · line 440
Quoted 7 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1 -0
@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
   	select BR2_PACKAGE_OPENCV_LIB_FLANN
   	select BR2_PACKAGE_OPENCV_LIB_IMGPROC
   	select BR2_PACKAGE_OPENCV_LIB_LEGACY
+	select BR2_PACKAGE_OPENCV_LIB_ML
   	select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
   	select BR2_PACKAGE_OPENCV_LIB_VIDEO
   	help
Maybe your BR tree wasn't up to date in the moment to write this patch. Look at this:

Quoted 7 lines

Quoted 1 line
http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
And? Samuel is just adding one more line here, in addition to the lines you added in the commit you're pointing at.
Thomas

You are right, sorry.

Signature · 1 line

Vincent

Samuel Martin

author

2014-03-06 10:35 UTC #4 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

In reply to Vicente Olivert Riera

Hi Vincente,

Quoted 39 lines · Vicente Olivert Riera

Quoted 27 lines · Samuel Martin
gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.
Fixes:
http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by Samuel Martin <[email protected]>
---
  package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/gstreamer1/gst1-plugins-bad/Config.in +0 -0
index 0685322..2c5c290 100644
package/gstreamer1/gst1-plugins-bad/Config.in config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV · line 440
Quoted 7 lines
package/gstreamer1/gst1-plugins-bad/Config.in +1 -0
@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
        select BR2_PACKAGE_OPENCV_LIB_FLANN
        select BR2_PACKAGE_OPENCV_LIB_IMGPROC
        select BR2_PACKAGE_OPENCV_LIB_LEGACY
+       select BR2_PACKAGE_OPENCV_LIB_ML
        select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
        select BR2_PACKAGE_OPENCV_LIB_VIDEO
        help
Maybe your BR tree wasn't up to date in the moment to write this patch. Look at this:

Quoted 1 line

http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce

The worktree was up-to-date and includes this commit.

It's just an opencv module interdependency problem, see this opencv configure log [1], the legacy module is "disabled by dependency" because the ml one is disabled.

I've post a patch fixing this issue [2] in another series.

[1] http://code.bulix.org/oxmmde-85789
[2] http://patchwork.ozlabs.org/patch/320821/

Regards,

Signature · 1 line

Samuel

Thomas Petazzoni

Applied

2014-03-06 17:25 UTC #5 lore raw

PATCH 1/1 gst1-plugins-bad: add missing opencv ml module dependency

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 10 lines · Samuel Martin

gst1-plugins-bad source code does include the old-style global opencv header "opencv/cv.h", which includes headers from the core, imgproc, video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy one, so the gst-plugins-bad's opencv plugin.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by Samuel Martin <[email protected]>
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com